From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Robert Richter <rrichter@amd.com>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands
Date: Thu, 26 Jan 2023 15:58:51 -0800 [thread overview]
Message-ID: <63d313bb874a7_ea222294a3@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230125085728.234697-1-rrichter@amd.com>
Robert Richter wrote:
> Only unsupported mailbox commands are reported in debug messages. A
> list of enabled commands is useful too. Change debug messages to also
> report the opcodes of enabled commands. Esp. if card initialization
> fails there is no way to get this information from userland.
>
> On that occasion also add missing trailing newlines.
>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
> v2:
> * Changed message to "Opcode 0x%04x enabled\n". Updated patch
> description accordingly.
Thanks Robert, replaced v1 with v2 in my tree. Should show up on
cxl/pending shortly.
prev parent reply other threads:[~2023-01-26 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 8:57 Robert Richter
2023-01-25 10:29 ` Jonathan Cameron
2023-01-25 15:52 ` Alison Schofield
2023-01-26 23:58 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d313bb874a7_ea222294a3@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®