mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Manaf Meethalavalappu Pallikunhi
	<manaf.pallikunhi@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: power: limits: Describe Qualcomm SPEL hardware
Date: Wed, 24 Jun 2026 22:41:08 +0200	[thread overview]
Message-ID: <63d42dd6-862f-4a9c-a950-5bc90ffab391@oss.qualcomm.com> (raw)
In-Reply-To: <d0528339-8be9-4895-a054-625df96ca926@kernel.org>


Hi Krzysztof,

Le 24/06/2026 à 12:45, Krzysztof Kozlowski a écrit :
> On 23/06/2026 11:47, Manaf Meethalavalappu Pallikunhi wrote:
>> Hi Krzysztof,
>>
>>
>> On 6/22/2026 5:58 PM, Krzysztof Kozlowski wrote:
>>> On Sat, Jun 20, 2026 at 02:09:08AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
>>>> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware
>>>> based power monitoring and limiting capabilities for various domains.
>>>>
>>>> Add a DeviceTree binding to describe the SPEL block on Qualcomm's SoC.
>>>>
>>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
>>>> ---
>>>>    .../bindings/power/limits/qcom,spel.yaml           | 47 ++++++++++++++++++++++
>>>>    MAINTAINERS                                        |  6 +++
>>>>    2 files changed, 53 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml b/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml
>>>
>>> What is "limits" directory for? What sort of class of devices fit there?
>>
>> Added for devices that integrate with the powercap framework (exposed
>> via sys/class/powercap). These devices are responsible for enforcing and
> 
> That's a driver answer. I asked about class of devices. powercap
> framework is Linux thing, not a class of devices.
> 
> Please describe hardware, not Linux frameworks.>>> monitoring power consumption limits across different domains, such as
>> the system, SoC, or specific subsystems. Any other better directory ?
> 
> I don't know what is this hardware doing and commit msg is quite short
> on explanation. Power monitoring is usually hwmon, but probably this is
> not a hwmon.
Right, it is relatively new in the device tree bindings. There is the 
Intel RAPL which is the same device but it does not belong to the DT 
namespace.

RAPL : Running Average Power Limit
SPEL : SoC Power and Electrical Limits

It allows power capping and read the average power consumption for a 
specific device (or/and an energy counter)

Basically you can set a power constraint (power limit) to a device and 
this one won't consume more than that power (the power limitation 
strategy is managed under the hood by the firmware depending on the 
device - lower OPP, idle injection, modem weaker signal, etc ...).

The RAPL or the SPEL have a hierarchical power limitation. For example:

                                     SoC
                                      |
                           ------------------------
                          |                        |
                      Cluster0                 Cluster1
                          |                        |
                 -----------------        -----------------
                |     |     |     |      |     |     |     |
              CPU0  CPU1  CPU2  CPU3   CPU4  CPU5  CPU6  CPU7


If you specify a power limit to 'SoC', then the power consumption of 
Cluster0 + Cluster1 <= SoC

If Cluster0 power consumption decreases, then Cluster1 is allowed to use 
more power until Cluster0 + Cluster1 <= SoC

For me it sounds reasonable to put the device description under power/limits



  reply	other threads:[~2026-06-24 20:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 20:39 [PATCH v2 0/3] Add Qualcomm SPEL powercap driver Manaf Meethalavalappu Pallikunhi
2026-06-19 20:39 ` [PATCH v2 1/3] dt-bindings: power: limits: Describe Qualcomm SPEL hardware Manaf Meethalavalappu Pallikunhi
2026-06-22 11:02   ` Konrad Dybcio
2026-06-22 15:11     ` Manaf Meethalavalappu Pallikunhi
2026-06-22 12:28   ` Krzysztof Kozlowski
2026-06-23  9:47     ` Manaf Meethalavalappu Pallikunhi
2026-06-24 10:45       ` Krzysztof Kozlowski
2026-06-24 20:41         ` Daniel Lezcano [this message]
2026-06-25  6:45           ` Krzysztof Kozlowski
2026-06-19 20:39 ` [PATCH v2 2/3] powercap: qcom: Add SPEL powercap driver Manaf Meethalavalappu Pallikunhi
2026-06-22 11:01   ` Konrad Dybcio
2026-06-23 10:58     ` Manaf Meethalavalappu Pallikunhi
2026-06-23 11:11       ` Konrad Dybcio
2026-06-19 20:39 ` [PATCH v2 3/3] arm64: dts: qcom: glymur: Enable " Manaf Meethalavalappu Pallikunhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d42dd6-862f-4a9c-a950-5bc90ffab391@oss.qualcomm.com \
    --to=daniel.lezcano@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gaurav.kohli@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manaf.pallikunhi@oss.qualcomm.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome