From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tom Rix <trix@redhat.com>,
s.nawrocki@samsung.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, arnd@arndb.de
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: change neo1973_audio from a global to static
Date: Thu, 30 Jun 2022 09:00:14 +0200 [thread overview]
Message-ID: <63d495de-588b-0568-a4d6-31e24ef50377@linaro.org> (raw)
In-Reply-To: <20220629201811.2537853-1-trix@redhat.com>
On 29/06/2022 22:18, Tom Rix wrote:
> sparse reports
> sound/soc/samsung/neo1973_wm8753.c:347:24: warning: symbol 'neo1973_audio' was not declared. Should it be static?
>
> neo1973_audio is only used in neo1973_wm8753.c, so it's
> storage class specifier should be static.
>
> Fixes: e26a2abcc246 ("ASoC: samsung: neo1973: turn into platform driver")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Compile testing works!
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-30 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 20:18 Tom Rix
2022-06-30 7:00 ` Krzysztof Kozlowski [this message]
2022-06-30 15:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d495de-588b-0568-a4d6-31e24ef50377@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®