From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933709AbcKVRr6 (ORCPT ); Tue, 22 Nov 2016 12:47:58 -0500 Received: from mleia.com ([178.79.152.223]:33503 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933003AbcKVRr4 (ORCPT ); Tue, 22 Nov 2016 12:47:56 -0500 Subject: Re: [PATCH] misc: sram: remove useless #ifdef To: Arnd Bergmann , Greg Kroah-Hartman References: <20161122143103.1835294-1-arnd@arndb.de> Cc: Alexandre Belloni , "David S. Miller" , Marcin Wojtas , linux-kernel@vger.kernel.org From: Vladimir Zapolskiy Message-ID: <63d62ef3-66dc-bca5-fb12-a14dd1ad324d@mleia.com> Date: Tue, 22 Nov 2016 19:47:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161122143103.1835294-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20161122_174753_737142_B080B188 X-CRM114-Status: GOOD ( 15.72 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 11/22/2016 04:30 PM, Arnd Bergmann wrote: > A recent patch added a new function that is now unused whenever > CONFIG_OF is disabled: > > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function] > > There is actually no reason for the #ifdef, because the driver > currently cannot be used in a meaningful way without CONFIG_OF, > and there is no compile-time dependency. > > Removing that #ifdef and the respective of_match_ptr() avoids the > warning and simplifies the driver slightly. > > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support") I can not find the referenced commit on Torvald's branch, won't it be rebased and get a changed commit hash after merge? > Signed-off-by: Arnd Bergmann > --- The change itself is good, thank you for the fix. Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir