From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D83F3321A1 for ; Mon, 20 Oct 2025 17:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760982138; cv=none; b=AtC+AbQwdgROS3peRGVUKPFHS/auYhq8UyBS5q9uoibPj+0iXtK13diDd+AyeiqZuUBofRHaaEiZunx2lOLzod2xyd9Aoy4I31lsLo1Jn4nF1ZJzWWJhsI75vI8zHPPN2FB6m5OgHECQVuPVQpMfxtJkfFijuBYsWt+3j3KoAFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760982138; c=relaxed/simple; bh=9qA6BuFeIx5fHAIGIw0nel7ZY5DQlvVmFai+iklLtRI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k3YYWXeBkE3eCsNvRc1HKV2yas2djYuXXM0SxkZpd6+oK4uQ1y7BjJdy0xoK305ux7y+ThVbUG0f2w/dd3SKuJtYHTHhWAX3HN0YhFK/ORQzCzpJ7yiMYcZ+xwPsYn2lvz8e8UHv8u1o2vhbnKUMix1QXHIQJaB+iYMexDEiWiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WHyLNtPh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WHyLNtPh" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59KBArSC015603 for ; Mon, 20 Oct 2025 17:42:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wuH6NKm3t0y7yTW2TM5liGhGfdwbrDlainmDiWhRs0g=; b=WHyLNtPhuwLKPt2f l46aPJiAmy9GaLuPuLg5rUH09NC/JYrKTf3gQsiHkIlVhN55/kld2WCIKBYKHNpm Rs9K4+PfLVVqWabGUAtVhwz6kjve4f1/FLjAe3+OVS8HEJYuWGXPJ/5rKELh2/hI yY25V/ZuSq0YqmFF9z92HgAgxufq+Y5wHofNqdIrcsae9rbrRHuu8OFcbEQGnWLq pOnVrr2qltSfiVIf+B8sL16AOd0QX2hsJtYedIafB6EQLsxcx7DJdF7y4RwJrXeF JmVl/2zpMFPrCcwKpXfY3HbTSTgF70yZrQqzL17Usu842Ma7+0YPgNVx2Z4OdjmP 7s/XRg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v3985h9y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 20 Oct 2025 17:42:15 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b6097ca315bso8210675a12.3 for ; Mon, 20 Oct 2025 10:42:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760982134; x=1761586934; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wuH6NKm3t0y7yTW2TM5liGhGfdwbrDlainmDiWhRs0g=; b=tUs3IofqG+It8EDeYGLrgh6hMH+DatFgmfQzRJDn6phXs3e/0UGEmJZSkFC7qTbvW/ 0irxgvgl9EBB6sd4EIbLGngf7Rl9qZya5rBNPgiy2sMe0X568CAqo8xfyTpMIUlmbHif TX65v7zoshxzx+2j/FckqLHjqdPhehzhbhDe77ZgY00jNDWPZZL9URzKr7FmFC7Baeq5 L+msyK/pP4apegwJ8eLrjqkVWFvbi9+VI5MyeKpUtnElEVCEyqWrH9d+vpWESNVuhcxu 3i/b4ibxDRe12V4kUwlIu3Ye4Vsj3SfoKQCaUbWi5ZwgIcxzOwobPZ0H6NJfANyQKh6q xxdA== X-Forwarded-Encrypted: i=1; AJvYcCX9LCYRAx4OYCCblRYDk7rwV4zaSpDEFOHr3GHUtiX7qx6tBR/YSEYxTPOgVxDxjkk1CD3EO97XJpLP6zg=@vger.kernel.org X-Gm-Message-State: AOJu0YzHCLdzRR4NwIWs9fae/kOIFSyMq6SF2M8yOzkSlEXcwKhuIwHK bPqhn66lBkeCqJt12DPl6NNKcXFVul22lbJA278TREjUvaOIN0PEVM5FLhe9ONxpD5d26P2BG2e HqHXQrWgfb0+fc22NDUpVwa/lJU/lcRgt6kRpdDelZXPuH241DnJUm0fIAL6fDXPdp6k= X-Gm-Gg: ASbGncv1tX1iyfBEm3pj0C89i5KdzMk5wHaA0CSUuA8E+jtcqLjcMJBMC6YLUsHd92f CoSYC0UHuhJiX6iRYI/mooutVTH2GWQgvLUNpXfoe/b5HSmmO7CkAPmxXahFi12dQpInIEErEAe hpi0D2ls5D00hAbGZzSl7ukds3czPLJf0+amPMhViR7AKFkpvlnqD8uRrR9Xhlf8Ean+0R3liSk dC5KvLAwGi4zpqHW4s0I772Tj2Dmeb6AztBIPihbIx37CKdJCCQ3QvHpvf6CiTfUhigJONQKYmJ Lin7zODG/oQSRu4Z0byjGhWduFePLANmIdZDPizafeUcPp+9D2iGHRVPS/aBQ2lPVZhOxlEKriV Q6GErrqfuxvV//nOBAYK0oJ5+EFyvNbxTe87ByH4qsFvPLSQKkYJs2Q== X-Received: by 2002:a17:902:d4c4:b0:269:9ae5:26af with SMTP id d9443c01a7336-290c9d1b4d0mr172936215ad.13.1760982133868; Mon, 20 Oct 2025 10:42:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmgh6tUXTbf1pGfo1ASimL2b+7pT6kMnii6yInuvVAI5pWnTr0w6G4M9GWEUp4lc/J1jtUyQ== X-Received: by 2002:a17:902:d4c4:b0:269:9ae5:26af with SMTP id d9443c01a7336-290c9d1b4d0mr172935595ad.13.1760982133165; Mon, 20 Oct 2025 10:42:13 -0700 (PDT) Received: from [10.62.37.19] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246ebcf67sm85874235ad.15.2025.10.20.10.42.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 10:42:12 -0700 (PDT) Message-ID: <63d9252c-77d5-4405-a395-d7664c35ea12@oss.qualcomm.com> Date: Mon, 20 Oct 2025 10:42:09 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding To: Bryan O'Donoghue , Krzysztof Kozlowski , Loic Poulain Cc: Hangxiang Ma , Jingyi Wang , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-cam-v1-0-b72d6deea054@oss.qualcomm.com> <20250924-knp-cam-v1-2-b72d6deea054@oss.qualcomm.com> <7140b8a8-1380-4859-84a3-681b3f1ce505@kernel.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=KcvfcAYD c=1 sm=1 tr=0 ts=68f67477 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=_kPCHQoBruyNaNDuvIAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyNSBTYWx0ZWRfX2USErmjgpwT+ HrboZzI31UGen1K3cREVfELpMqR1ixFftPXLQsQ6/MIgnLB7lmkBxZGeJyuM7se/eC1v0M72R+M QQRkWt0grmVwbnnMF3j2vvThNTLKgej+luu1FFXg8BHnz+i/jmAwLq3h+Uqh9Bcnu/mn24SVJ74 FlSzPnjd3+MX48xUCSqRbvVT6/osmFlNl4+0LuYXNA2mJe4Dim6Cp1w0W58EU6chM7hoe/nWIx+ JdyfBBgm6k20EHjBPUQnN8ox+Fg2kjfVU5R29QBnmoTRQ+qyOKoyrft99NPNiQr5CBQj6pNtL2D ahkGgd+vZwzQL/uCSGHfhSS2oofggRERJ7LxYDKZq3vGn/6fa7xhC7vHMiYC9puaWorMkmdMune 3CCXwptM5OBpvjlypq3rukiu2eMFBw== X-Proofpoint-GUID: YcTm4qIdPbwmjQOqJsqsHl_vFYgyebZh X-Proofpoint-ORIG-GUID: YcTm4qIdPbwmjQOqJsqsHl_vFYgyebZh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_05,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180025 On 10/20/2025 3:56 AM, Bryan O'Donoghue wrote: > On 20/10/2025 11:16, Krzysztof Kozlowski wrote: >> On 16/10/2025 12:43, Krzysztof Kozlowski wrote: >>> On 16/10/2025 10:47, Loic Poulain wrote: >>>> On Thu, Oct 16, 2025 at 7:52 AM Krzysztof Kozlowski >>>> wrote: >>>>> >>>>> On 15/10/2025 05:21, Hangxiang Ma wrote: >>>>>>>> +      - const: csiphy4 >>>>>>>> +      - const: csiphy5 >>>>>>>> +      - const: vfe0 >>>>>>>> +      - const: vfe1 >>>>>>>> +      - const: vfe2 >>>>>>>> +      - const: vfe_lite0 >>>>>>>> +      - const: vfe_lite1 >>>>>>> Wouldn't it make sense to simplify this and have different camss >>>>>>> nodes >>>>>>> for the 'main' and 'lite' paths? >>>>>>> >>>>>>> [...] >>>>>> No such plan till now. Other series may take this into >>>>>> consideration. >>>>> >>>>> We don't care much about your plan. You are expected to send correct >>>>> hardware description. >>>> >>>> To be fair, other platforms like sc8280xp-camss already have the >>>> all-in big camss node. >>>> Point is that if Lite and Main blocks are distinct enough we could >>>> have two simpler nodes. >>>> Would it make things any better from a dts and camss perspective? >>>> >>>>   camss: isp@9253000 { >>>>      compatible = "qcom,kaanapali-camss"; >>>>      [...] >>>> } >>>> >>>> camss-lite:ips@9273000 { >>>>     compatible = "qcom,kaanapali-lite-camss"; >>>>      [...] >>>> } >>>> >>>> That approach would create two distinct CAMSS instances and separate >>>> media pipelines. >>>> However, it may not work with the current implementation, as the CSI >>>> PHYs would need to be shared between them. >>>> >>>> I guess this should be part of the broader discussion around >>>> splitting/busifying CAMSS. >>> >>> And this discussion CAN happen now, stopping this camss and any future >>> camss till we conclude the discussion. Whatever internal plans of that >>> teams are, rejecting technical discussion based on "no plans for that" >>> is a really bad argument, only stalling this patchset and raising >>> eyebrows. >> >> >> To be clear, I expect Loic's comment to be fully and technically >> addressed, not with "no plan for that". >> >> This blocks this patchset and any new versions. >> >> Best regards, >> Krzysztof > > I think we should stick with the existing bindings. > > There is no "lite" ISP there are so-called lite blocks within the > CAMSS block. > > It makes sense to split out the PHYs from this block as they have > their own power-rails but, if you look at the block diagrams for this > IP there is no specific ISP lite, there are merely blocks within the > camera called lite. > > It might be nice to structure things like this > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi with each component > separated out into its own node with its own compat string but, I'd > have a hard time justifying changing up the bindings we already have > for that reason - aside from anything else - all of those components > in CAMSS live inside of the TITAN_TOP_GDSC which is the power-domain > for the whole camera system. > > So not meaning to answer for Hangxiang but, I think the compelling > logic here is to stick to and extend the existing bindings. > > So in fact I have no problem with the bindings as submitted - not > including the regular fixups these types of submissions entail. > > --- > bod > Hi @Bryan, @Krzysztof, just my two cents. I think we should consider separating CSIPHY, CSID, IFE and IFE Lite into distinct DT nodes. Having a modular DT structure brings in several advantages,     1. Simple to manage with much better readability.     2. Better control to disable certain HW modules from DT.     3. Less error prone as we don't need to maintain long lists of clocks or other resources against their names. Accordingly, easy to review.     4. No need to maintain resource lists within the CAMSS driver to identify the resources specific to the HW block. Offers centralized control for the HW resources.     5. Allows re use between the platforms when a same version of a subset of HW modules is carried over to future chip sets.     6. Is more scalable when we add more functionality to the CAMSS driver.     7. Finally, it brings in parallel development ability with engineers (within the local teams) working on different HW modules within camera subsystem. If not for the current patches in the pipeline, if you are comfortable with this approach, we will try to push the changes for the future chip sets with the modular bindings, leaving the existing SOC drivers and bindings untouched (if that's recommended). Please let us know your thoughts. Thanks. > >