From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9F2835C1B2 for ; Thu, 11 Jun 2026 16:20:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781194819; cv=none; b=WsoO01DTR6CuCITQrmQVJMfU/JuTzA6hdZP7Zym6UjXaqKLaA5mmtI4kAAmZFiAK8Md6o6NW4/WKQwGgASgZHTYCF9ksg/OzS8N1D6WaOyJowQEMq5eb9EuuAe9mG95VwwJVbdhdwiEJoaV7H3H3tdz+AKz439yH+PgU3Mi0kYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781194819; c=relaxed/simple; bh=PVl5+vfAaXABhxTJQ755xbsIawHfGW60RCxPr+Rk2zs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=fQg8TYGZRW5rnhRWuzkvz/ol8nEjjfnMCvMgxTWJR+/bhkpPq1SEa/L2xLfHgA2aDUkyx+cF5B5nyk4UXHQnoYK/ou0LL6xD4/b2aOlcJUrMCNOh6LdmesnO8aMZRHQFI9X2I7bZLCYcSEzoZguOIoLIQnxeULqAv7m5SS1CxY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sy/wCK/g; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sy/wCK/g" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4905529b933so86914395e9.0 for ; Thu, 11 Jun 2026 09:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781194816; x=1781799616; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=V6VrIsXLgQCkKWMrOqHoF2i7eZVI1PRZ8nVh86Q86hc=; b=Sy/wCK/gI5ItcDVjYPh/YY7thNK/HDIiPAIDIb9ci2GpBmR4gxIDGpcXvT54mhumPD mUptuyGcee+TNqSYuXpnx7XNrMNnE995F5CNa7wGeEV9ZVPYw5Jd3Y96DLyFrNxDmArz 6bUlyVrOLeyaBWt4b/li6tPdb0/U8z4TmmV9wF9PmKlrpt1JDk4V/SeJ/LF7tRdXmSAX oz5CR84/ZX183VyRzzJKGD2Ky079o81VgIRjKLGuGqGc+s48voZXSszMIn641AdGC8tG 4qI7gIiLMhSWoH8wcInogkwG5htYMmiNZd/Y+JnTR/c2DltDkZz979g17VNL4ZPzImPb ACDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781194816; x=1781799616; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V6VrIsXLgQCkKWMrOqHoF2i7eZVI1PRZ8nVh86Q86hc=; b=Gksm2z9SLS0Klxh3SbeiQRzxc/EvdOzzvzgqwI3whmuMCRL/2PBEub2tFkWZErfgTU rmJLb4qEzJiZhlocXPJl0QWdsXPI7+GupO94uTMMKSrFqinbGSSOMNxkdqp2xgWzmXmw X3r7X4L6Uh12YcIEcCMV85+ftwGk/zPFIkszJiGT+jHbrsKxet9xR6wF6h4GO0nOLfUV qeZoD2WFIyDPdWS27XAK9KhBjFEevc/vw8P/mwl7IH50ioqj4oJML1I48ZVshfEEhHip rJudkQbrSNP4HCYpNvViO0rQ1mIIdRkzxUEFZFmmPQjr3VQbtSt57zMyWffoJABBRFx9 9mfQ== X-Gm-Message-State: AOJu0Yw6oNV4OPN2ygsoYrLfBsFd7wsVmqd2Axwfnige5ftaGPMpF44J UTghubjoOIjcBVJqyguAoKQzpRlfRbJ38npzWsVbN/R/7/D0VcKg9jNb X-Gm-Gg: Acq92OHWkKFCrQJ4gJw8yh7HzZ8chm1l3+khf6seQ0yGkl+Zt6bhpvyop0Ef6Wm0D1J CElptMp/OxuDygpTYhXCVCgT4DX+HpcJxLMeChCUc9uAK3kF43dgE1F2BDbJ1JFvt5xsqYoU6hH bpKirAwDo5jC02cZt+vJtTadC66Wv4IxbpIwgnLlmxQD/LbpOCvKX/SFYN7gVcjDUtGWwTHj3VH uoA/267sgp6s8H3zjD6cR1QYdTVR2tK+PDzlJ9mMvtshJL37wkVFACV5YYA+4HBfotHeR0yWlXZ AFbqByN4pveY1/rQA9CBvmqyUbZOMiuZ90SpwlPLulgdRH7LFkaMhyewJ+RXAagAvMoLpkeEv0p sql4vBafl45Ady9LCmN/hFNwFecUfVDhuk1PGVZpQ/bj10y2I59NNeDH0rmbQfnegi3TgJP8neg O9SIy0iB3HwdIiCPYkjkEEZkUwAI7YWv86Z2tnrjQNxUU7 X-Received: by 2002:a05:600c:1f90:b0:488:a882:c7 with SMTP id 5b1f17b1804b1-490e561d82bmr46263535e9.25.1781194815893; Thu, 11 Jun 2026 09:20:15 -0700 (PDT) Received: from [10.250.112.109] ([64.176.167.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2cf5537sm92889925e9.9.2026.06.11.09.20.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 09:20:14 -0700 (PDT) Message-ID: <63df046e-7dcd-4a0b-a41a-12aa578b69a9@gmail.com> Date: Thu, 11 Jun 2026 19:20:11 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Nadav Amit Subject: Re: [PATCH v7 12/14] x86/mm: Move flush_tlb_info back to the stack To: Chuyi Zhou , tglx@kernel.org, mingo@redhat.com, luto@kernel.org, peterz@infradead.org, paulmck@kernel.org, muchun.song@linux.dev, bp@alien8.de, dave.hansen@linux.intel.com, pbonzini@redhat.com, bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org, vkuznets@redhat.com Cc: linux-kernel@vger.kernel.org References: <20260609091710.404083-1-zhouchuyi@bytedance.com> <20260609091710.404083-13-zhouchuyi@bytedance.com> Content-Language: en-US Autocrypt: addr=nadav.amit@gmail.com; keydata= xsFNBF3nSCQBEACinGNWCLb3Iptvg066zPUQCFfR0nIX+j/pjxlLd094zOKLJ7Z1wKNNTQgb +Y1GQYwKurK1hFHISPc1T7xk2twzov5niFqQp1/E0I6t/92rxo7C26tKMrCHgqXpFXXBaOvq t0QN8B83o3sfS3OZyc0F5hWoJijhKQ+h7dJHMPpBBeTWiZzYVlMNz/wRzYrh1nvesbGJtV1w Wk96qoQAOagczRaSRWouJ1O2JbHqQarLJG657hqtPZctQ1mkXQcJedT1c8ejWBdIiU0rIpV/ R2uTgM5NSjVrY5OxiS2G4C/bDcI4Q6ApWxqu1zRGffKWRFJdQvttSv+JbW2q6OCvJReJs1i6 nTovpfJb3g9d7U76LtAw7HE5iIl5CmyFoTMMH+sDc5PG7JRboiofku9DWeDGK4rB2s97GuA9 BXJDHBbH1AI+Y0H6oz/Dri1sQSayUU8Xj/jCkwxpwDle1qYYE0UM4PqDTUoeejURR/h/AREt bCecfxNUYNz2jY8PUL0YXj6yex2p1otMy5sy7djrTqhC02AXLQ3Oab2UJuMZnf4cTbN2sGXu CRXcCSsoyhxIFtwpgdVIDqkPMCOEPvUwy9hWs0N9Xy+jOebpH6FYxq83pP3IhyBdaoexoyGL IkSzrO4+0bVk5voh5SIYVkLEooMSEQT9rfSdrJmRRuM7S/PowwARAQABzSFOYWRhdiBBbWl0 IDxuYWRhdi5hbWl0QGdtYWlsLmNvbT7CwZcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQRIkveiyXlibH/D0jUdoCpJptoPWgUCaipVlAUJEAZArAAKCRAdoCpJptoP WkyQD/wIM3n5MgDTIRuEqE5aiEUC35kZdEr2bt1XdfC/iIc76HmNWsG7IIGHpVROGh/tCrxr luDCkZXBOwht2rz4oA/DrkVucJ4lh38Ot/nd4PbYNtDEtJPHN5LTtI3A0mwpAuRYMETu39rC X8poZRD78QDwuBsWPd73iVMOy6IB8JOzx7LJ2ELC2ptI08pKQGYYOoIt+jB8RDJQthnMQjjs KCWPmCDCwxeGNIKls7GFoazjEV4V3JUsyOPPuTJwbFhk70rtY9pZdIVUzCJAHnqxU4BZ6bIi JMWL0xHVtF0lKQX147yFo/TPNVhddGvNz9yIYyGMiSbsGu1Rd7AuAeXLCGnISXPxsXHCMDLm +vH/uqMIwQ4zg2BNxBzwfUR9liV7WD6kLzPgDjGBdA105doiu9L1oW5UTqw3rfTOghhdS6aK TL/mACnG7pj+gv7+g8YvPUUKDLvTy5Loe4yHdMklHzjMDPnjGe8+UfQjZOpskIvEs/KFDaHK iMBQ4y4De0P9mZZ3cy/5rscwQatmHdPO2c2rERB/5P6AEBsdML9DCKx/YpBx/SZseCJlTd8Z Y4eEwyfSBxHFK7f67G9H1jWqGnWxUKRadZOx4VxkbSQHTk5r/qKYxJIvmIsyJc4gs4Ai0jsn 9AmfJXnfQvYgGQXrLsAPnW0up+JPC2SPIh3ChxQYG87BTQRd50gkARAAt/NqfDSMph828JIn VOck27zsyT12AHRLIhsCCatw+zYbdMSLTW6hd/sChStdndAQlqOOW3mpm6bA+jl59c4OhkBW 8fDKgaWjVq8kBm4Z61zhzk3oXMmxgQ3cqMEfN36PCpcfs5MtLiMoa2JxaqFMQbKkmcZqz8fw qGIID/SMI5qdk+yWZSmR+6RdzXfppEIeqs78qTFxaEl+0MlAcgo2AjrMPLIjNK3k4jNAVCix KjMfkkPk6xVmP5Q7cr1st0xTTa1APt0y966oa6CZIdHY76D/jLpjJlfalctmEAxmyBqK0ZkK WDkEF+qCqqZ7oSkC1Q0ogBuBffIZb5srleqMz++IutiE4r/LELs7RanXXCRK5JYzZc/uAnxN fCJzqKR5/JxoSnCh0yQNU4FHa78DeD/SLnCu8JwTGkcX9ZUW/ZQ+5Nsimy+SlZb0UyaWA+vr Q7+F7OAL6PFsE8v+Q2u2EHwa8e2KmsL0sC+enBXbaogLFFfKi4I13vOk+76nCZTNetRhAubM etLe1PZZ0IDzgGhjFg+cc/jptq3qYjK+3jzhdKaqmoibAoea3E/5HsTVVbxUiYEdk2crTqf9 Mr5S5AzQfH19xU7uUduBvjN3L0dRKP0wJEqgCIB5gZBjD8AYmKSgdEujDAPQNXTJgwB99C+r F0XoHEmO6m9vI6djzDsAEQEAAcLBfAQYAQgAJgIbDBYhBEiS96LJeWJsf8PSNR2gKkmm2g9a BQJqKlWUBQkQBkCsAAoJEB2gKkmm2g9ac24P/RnndwYbhQIwCBttSsqwhiIW0bH2mO3T0EXN ihustp+Nudn3Vgr/uEPBnqoGIWB7sWdwU5Dj89TOiRk4RrlvRjndqieqbxXDhX0FwLA/jblZ iBS8OgLtmp8c8NHEst9t8pk3E9oRUw29Jbr8ZbRVxIE8fh2Vq7uVKz/hIN1/xzDVWi3p8bNV Y9cUD2XwlohphM353OwUROd1dJRWfDN4TWFJnA5YkVWNUHnT2ngoJS1Bk82iTontTBG8u9TM 2pC/hxv/Gl15hVqTUiiINcxFUJgisnKFRTrkpbg0QrVr+8C1PY1b6rTBa2sB1k+L8eR74J/T u2Jl06bmlX6j5M/NDmvewR7zqlWmKTupUAMdeDPVymvkJhDO1HmO1oWyhdlFwS7w2d1PCxhy RU6i4kax103OA0h8tyk1vPesgXcYidSG82+BGxjmfvA82MCWM5GE1jUGAyI+bOhT8hQ5eERM bxbe1Rkjh5DpHv+o8QVdFFla7hRWC3ICLYMS1o8Jyt54U8bUqkE2nUBqDhtt8L3UaiPv72Lo 5g1XBwZ1ctl5SxT1EUFoS1PA0UQAHZEOqNV68P4tPtse6SkeHXLCqzh+PfdbtFyGEpMqaCJc 8g4oFTx8lVsWY+hxO88MnOmIu97a1USEe/cqW60yG4qJYWY8Kv5XBto97HZDa+HUNTap2Zt4 In-Reply-To: <20260609091710.404083-13-zhouchuyi@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/06/2026 12:17, Chuyi Zhou wrote: > - > void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, > unsigned long end, unsigned int stride_shift, > bool freed_tables) > { > - struct flush_tlb_info *info; > + struct flush_tlb_info _info; > + struct flush_tlb_info *info = &_info; > int cpu = get_cpu(); > u64 new_tlb_gen; > > /* This is also a barrier that synchronizes with switch_mm(). */ > new_tlb_gen = inc_mm_tlb_gen(mm); > > - info = get_flush_tlb_info(mm, start, end, stride_shift, freed_tables, > - new_tlb_gen); > + init_flush_tlb_info(&_info, mm, start, end, stride_shift, freed_tables, > + new_tlb_gen); You use here &_info instead of info. At the same time kernel_tlb_flush_range() and friends use info for the struct itself, not the pointer, so maybe just get rid of _info and call it info?