From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 157BF3BBA17 for ; Tue, 20 Jan 2026 08:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768896069; cv=none; b=kPLQWGTgnqG9HDBuUIlmH7RpjnEUUf23qT/g09npBs7j+twpbS0g8Nrtc37mq3EZksD2GvmkmPSQYWZrdKMWn4+WUbdDklAnkAXit/rgnhCbA14iYj432fDJro4bbW11g51uJeLLP/S9+SJdIXMDvIJeBFTDpXBBwL79zeISigc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768896069; c=relaxed/simple; bh=xTRa0o3xOsfjH2gIPBCSvZ2S1Pumgzmfp//GVvSXTIQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CssrQRkZxhamZQDrajUAEWTVFkO+A35d26c97j1ueInutYDX0qmtzEqQxjysmTjiXyNFpg+Ov/gRJOw9EGias8FBR3L+ds7F23x0T7oMN1rteceE00NlInK3nvye1sxkcZQirlhPJbP9DSmoZ3Lqcy9ivRRERztxdBfXlRuV1aY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=en22/rg1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LI4/c9u1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="en22/rg1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LI4/c9u1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768896065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xTRa0o3xOsfjH2gIPBCSvZ2S1Pumgzmfp//GVvSXTIQ=; b=en22/rg1ky3Lo3E3Cw6AsuOia/lvkhQCqYGFqzKd271hE5QLa1nnfyEBLOZltVkLasmop+ 8y5Tu//MaZg4ex1SEN45OLPaHgZ3ooTiwGm1ogvhvanIjKeJtyRrDwsZ97D3Sq0ec9ZHv8 4JYXPS7IRFdlHrlgRIeOZ+WdH/NFDS0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-ksaD0mb7PFeqN0iM6TQbdQ-1; Tue, 20 Jan 2026 03:01:04 -0500 X-MC-Unique: ksaD0mb7PFeqN0iM6TQbdQ-1 X-Mimecast-MFC-AGG-ID: ksaD0mb7PFeqN0iM6TQbdQ_1768896063 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47edee0b11cso26139445e9.1 for ; Tue, 20 Jan 2026 00:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768896063; x=1769500863; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=xTRa0o3xOsfjH2gIPBCSvZ2S1Pumgzmfp//GVvSXTIQ=; b=LI4/c9u1qCnXIqEN0x8jhSKgR4IU7kWdY8XFjiC5DfGBzq0xCbcAU/d7CZb+dQVRaS IgujTpdl4ICE9LV2Ds7nnWfiIZDHBp4PvSpM15BsCbiFVtE5pu3/N5Fu7x2Z/1INzxZF b2/PqjiNwLCKwqwYlSinhywf6V+k1yykq9FNTx9JHw/lwg75ph45AIo98A1f2kh8i393 CHoYa3J5itZXENWknFuhWpwl64XtyA+O3pGIQgiw1miZGMuezQH4D/mSYydcUd6Wz/k7 yzTRUNNVYNt7m3TkG3fpTgxs1rYtxdyblC+JpHQCs4vlaeOfgt8XR9/Mr0/TS4rDSgrG jYng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768896063; x=1769500863; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xTRa0o3xOsfjH2gIPBCSvZ2S1Pumgzmfp//GVvSXTIQ=; b=VJ78SDluFfx/LkJACl923YMvAh/zT4G2R714PdKd8ReK/41TYZVtaOOTymglCTqff4 TonEFviSn3MGL+flm6vMRStPJO5Pl0ht6wtDXT6J+TkD7xlOhddBDFTM2iSiBDPTU+qw AV1N/sa2z1tsb2AcupM9OFyFecYztB/UG0nztsfSF7Kck68QzWfi95gt75cr3BYUUAHX s85SS1I7R3y7fGPEpOVV2r0r376pLElnEInOM1eIN5uwiW9EZX9bxd1iiowFpI6mm7OL yxn9Ia3PA9Nevbu8itr8W/7iMfZeHDkG0RiggiyaKVkNf5IZlJjW2XyoJPYI541hxWRU NMZA== X-Forwarded-Encrypted: i=1; AJvYcCUFtosoObMCS1PLUEmpXjDvbn8CnMiiAORZy421sn/fP4xMCuibCbXgzvm43FpVJCjDNezW+7YN4Ty1670=@vger.kernel.org X-Gm-Message-State: AOJu0YyagWD1CtJHYDQvTHoETFqM5K4UzVdypI2NMB3LH0DEPxO8gJMH tGnpvJ0AtQAX27G3lWOB/eZiHRe6ogbhbM/+81tOnyw8RsxcLZWsyUk7XecLeB3wyIOjGk7m0TK QhLFlwhpIuyZs/SpQ+0KV3yEXSGm5APZsVMj+1Ls8E/M2R8lTp7TzuQsuCsncy8t7cyjZNXmlSH /z X-Gm-Gg: AY/fxX4h2pf7yE4fzcMA3PYw4A+Wr5njLIKtzt31fYf3ruapOwX//9YQbR2nQnvLe16 qzp8MX3ZmioZ9zFAITqcIzpQKNTEXa049mxaq2WJsaITenU+manMIp1YoeYn0Q1HIK6VRB/256u +6FZGeokPjEkQYSMpgWgZEICRTRugdXiWsf4pxE5T+XwPCeNfw7gUvuT8XzthkPlw3sgjWSLuH4 uzveCMOeqy7ROpbEfy9aId7wujLXfDm4QZW2SWaqriB8DXEaBjp6RuCYaBSdmiqlkpXLXB7cq3X OeF+TUbayDzUyF1SIwyUQIkTob7arTz05sDAOJ+dSP9pQrkk7CIolGBchUhLxrJvaDuwE6fr81U Jxlso51jYVp6gECtLup4Gp30NDJnmmiKC7YY5JArYm47St+yuajNfjjZ1hwk0IJzodpjTk8iKNQ 28eMTLAhLD X-Received: by 2002:a05:600c:8b64:b0:47a:8cce:2940 with SMTP id 5b1f17b1804b1-4801eac0f22mr163463275e9.14.1768896062834; Tue, 20 Jan 2026 00:01:02 -0800 (PST) X-Received: by 2002:a05:600c:8b64:b0:47a:8cce:2940 with SMTP id 5b1f17b1804b1-4801eac0f22mr163462915e9.14.1768896062437; Tue, 20 Jan 2026 00:01:02 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f4b2672d6sm295520805e9.14.2026.01.20.00.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 00:01:02 -0800 (PST) Message-ID: <63e032341807f9ece73937d5e20eee9e3162fb61.camel@redhat.com> Subject: Re: [PATCH 14/26] rv/rvgen: remove redundant initial_state removal From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 09:01:01 +0100 In-Reply-To: <20260119205601.105821-15-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-15-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > Remove an unnecessary and incorrect list removal operation in the > automata state variable processing. The code attempted to remove > initial_state from the states list, but this element was never > added to the list in the first place. States with the __init_ > prefix are explicitly excluded from the states list during the > parsing loop, with only the initial_state variable being set > from them. The initial state is not the state with __init_, but the state pointed to b= y that, the purpose of removing it after sorting and putting it back is for i= t to be the first (we may argue there are better ways to do that, but it works). After this change, the initial state is duplicated.. I think we should just drop this. Thanks, Gabriele >=20 > Calling remove() on an element that does not exist in a list > raises a ValueError. This code would have failed during execution > when processing any DOT file containing an initial state marker. > The subsequent insert operation at index 0 correctly adds the > initial_state to the beginning of the states list, making the > removal operation both incorrect and redundant. >=20 > Signed-off-by: Wander Lairson Costa > --- > =C2=A0tools/verification/rvgen/rvgen/automata.py | 1 - > =C2=A01 file changed, 1 deletion(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/automata.py > b/tools/verification/rvgen/rvgen/automata.py > index 7841a6e70bad2..b302af3e5133e 100644 > --- a/tools/verification/rvgen/rvgen/automata.py > +++ b/tools/verification/rvgen/rvgen/automata.py > @@ -111,7 +111,6 @@ class Automata: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = cursor +=3D 1 > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states =3D sorted(set(st= ates)) > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states.remove(initial_state) > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Insert the initial sta= te at the beginning of the states > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 states.insert(0, initial= _state)