From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38C13156F3A for ; Mon, 14 Oct 2024 09:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728896792; cv=none; b=iXrNOt3wr2yhZbOUw+ZAYWKMRkapQ7UqIH9CDGNYC2Zr5PZFnxsMqtXZL7FSpf45oV4PeaciEP2BIRHoOLEzJSvTpH6D3uaDFWd6mLsKz3MqAYHr+dySlXH6p0PDWz+6JAkZBGYZt14PaWxY8SHPBd8cScIPXGF3addSCT02Wz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728896792; c=relaxed/simple; bh=/6AkSe9ZsMWGEegbX5mWdCWRk8oikiSE5pvH24z3A2w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jxqLIx36vFI2S3tmk2NvKYQsg1/buH6Nx6hJ6bxNDbi5Ao5ly9rLrVbYICPplrKvYS2avsVVLdZ2s1s+sQe9kz+GjrgsUS4Ys4v5CfiW1LAWQd1PhAMM1saz6bvqzf14ElQAUQ0dsgLiTe3cUl+yPEC/a/Uz5yJ2HYlERkUvuGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S+cvuAl+; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S+cvuAl+" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c949d60d84so3347287a12.1 for ; Mon, 14 Oct 2024 02:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728896789; x=1729501589; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yQ7N4NGsrBS9erfMRFf3mr/u/TsgsOX0nwQxEKrF5/8=; b=S+cvuAl+91joN9GXT+YyP9LFuzkI7splVK5fOl4dzdY3NNElizERuhq+rqx3AMIrK/ mtaWUN4N0zWtjQlRQYOv/C34jeyK/V0ZtXMtjcHXOYFp3yVszwW2WvonnGzUQcGvAGPu apm/zW6+v/mrTkAp9n7dc6DuyeMOGw8O1v91YLser01r+URuwm1Iwm1fvwpLZfdr0Gka Q37hs2VLlxqVD8kLu789V5YCOkCzVdWWwZzSkKYGU9tizV/EE8SaH1tKPfJOVL2SNeQ1 pAOaeIXZRyZ4C6WCtvaNS5Gw7K5lsL1HhlWMB54BUQD4o46nWmprd8oWfkb1+2rPHGGt 0CBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728896789; x=1729501589; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yQ7N4NGsrBS9erfMRFf3mr/u/TsgsOX0nwQxEKrF5/8=; b=xLPjj6fOXbmQd0V+doZRPRGOvFqFfpISXEIY5+Srl9jSA3ATF8mjO8afGLWapFXvyI nQOuiyZeKrwm2NHnjNxJnwNWYS1f3y7rHX70kC/8RaysEKQrOnJ/sVh7UTlB5Kp8aMnB 2uQBSd4odTJvhqB20iHBlG6IR2BDGrz+we8RzeOdT1qd9erjJaprCTSZm48WM5suOWC2 LEo0cXPEAUcQ5bMpm7/zunqoHGSm/ABJn6PoIDq2hP06ooMlLmnyd5PafnWtXCIw4iTZ hnySajqWFwCNuPRAiFjV7VxrmKehw4wS8do9qXCUBwWRY+CkLh/KFqDb8lNLDZbgocJx 8XaQ== X-Forwarded-Encrypted: i=1; AJvYcCWdXtUVyKj7w4cEj4duNMSnzBF1t4GJgfGOBWhDmTE9m7b7eiZq5AkINNeN1AyVZ8SZIIW7Mm0/HyP+Nn8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw726/fdWxdmVgVCEAlhTIHbZlTxqR3wQK6OmE8zCN2Jx7nlUz2 fj9W6YjwGcFymLp1/I0PF2eg3NlCe72AyLmU4377IEqFnmejR+2eAKwdDGVQYPA= X-Google-Smtp-Source: AGHT+IG3luq/hzR8Bl5xe7C7iS7FVcUq7MLtlNd/M/noM85vm/NAE/kbPKiFAuv1GvAh9JyzUb1NfA== X-Received: by 2002:a05:6402:3207:b0:5c8:f905:9fe4 with SMTP id 4fb4d7f45d1cf-5c948d6a54fmr9188289a12.28.1728896789469; Mon, 14 Oct 2024 02:06:29 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c9370d25e8sm4699269a12.4.2024.10.14.02.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 02:06:29 -0700 (PDT) Date: Mon, 14 Oct 2024 12:06:25 +0300 From: Dan Carpenter To: Javier Carrasco Cc: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Umang Jain , Laurent Pinchart , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node Message-ID: <63e1351e-d8f3-4b98-8abe-a2541f95281a@stanley.mountain> References: <20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com> <47c7694c-25e1-4fe1-ae3c-855178d3d065@gmail.com> <767f08b7-be82-4b5e-bf82-3aa012a2ca5a@stanley.mountain> <8c0bbde9-aba9-433f-b36b-2d467f6a1b66@gmail.com> <20d12a96-c06b-4204-9a57-69a4bac02867@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 14, 2024 at 10:49:28AM +0200, Javier Carrasco wrote: > In this particular case, and as Greg pointed out, that is not a real > threat anyway. My digression comes to an end, and v2 is on its way. > I mean the other thing that we would accept is if you moved the NULL check to be the first thing after the declaration block... regards, dan carpenter