From: Yang Yingliang <yangyingliang@huawei.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>
Cc: <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] thermal: core: Use device_unregister() instead of device_del/put()
Date: Thu, 19 Jan 2023 16:25:50 +0800 [thread overview]
Message-ID: <63e19339-78fb-8107-1f41-418ec83a7bfe@huawei.com> (raw)
In-Reply-To: <b31022f186287075f60f42facde01b3b42b06d7d.1674030722.git.viresh.kumar@linaro.org>
On 2023/1/18 16:38, Viresh Kumar wrote:
> Lets not open code device_unregister() unnecessarily.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
> drivers/thermal/thermal_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 1fb109a97ff6..9fb37c5d9c4f 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1109,8 +1109,7 @@ void thermal_cooling_device_unregister(struct thermal_cooling_device *cdev)
>
> mutex_unlock(&thermal_list_lock);
>
> - device_del(&cdev->device);
> - put_device(&cdev->device);
> + device_unregister(&cdev->device);
> }
> EXPORT_SYMBOL_GPL(thermal_cooling_device_unregister);
>
prev parent reply other threads:[~2023-01-19 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 8:38 [PATCH 0/3] thermal: Fix/cleanup error paths in __thermal_cooling_device_register() Viresh Kumar
2023-01-18 8:38 ` [PATCH V4 1/3] thermal: core: call put_device() only after device_register() fails Viresh Kumar
2023-01-18 19:57 ` Frank Rowand
2023-01-18 19:58 ` Rafael J. Wysocki
2023-01-19 5:16 ` Viresh Kumar
2023-01-19 20:09 ` Rafael J. Wysocki
2023-01-24 19:26 ` Rafael J. Wysocki
2023-01-19 8:13 ` Yang Yingliang
2023-01-19 15:02 ` Caleb Connolly
2023-01-18 8:38 ` [PATCH 2/3] thermal: core: Move cdev cleanup to thermal_release() Viresh Kumar
2023-01-19 8:25 ` Yang Yingliang
2023-01-18 8:38 ` [PATCH 3/3] thermal: core: Use device_unregister() instead of device_del/put() Viresh Kumar
2023-01-19 8:25 ` Yang Yingliang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e19339-78fb-8107-1f41-418ec83a7bfe@huawei.com \
--to=yangyingliang@huawei.com \
--cc=amitk@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®