From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Raphael Gallais-Pou <rgallaispou@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: st-asc: fix typo in property name
Date: Mon, 5 Jun 2023 14:08:49 +0200 [thread overview]
Message-ID: <63e2c1bc-4a80-4857-899a-dd87d92c6f7e@foss.st.com> (raw)
In-Reply-To: <20230604083558.16661-1-rgallaispou@gmail.com>
Hi Raphael
On 6/4/23 10:35, Raphael Gallais-Pou wrote:
> Changes the property name read in the driver according to the YAML.
> According to device-tree documentation, property names should not
> include underscores.
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> drivers/tty/serial/st-asc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index 5215e6910f68..6ef99a037a9b 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>
> asc_ports[id].hw_flow_control = of_property_read_bool(np,
> "uart-has-rtscts");
> - asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1");
> + asc_ports[id].force_m1 = of_property_read_bool(np, "st,force-m1");
> asc_ports[id].port.line = id;
> asc_ports[id].rts = NULL;
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
prev parent reply other threads:[~2023-06-05 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 8:35 Raphael Gallais-Pou
2023-06-05 12:08 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e2c1bc-4a80-4857-899a-dd87d92c6f7e@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rgallaispou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®