From: Randy Dunlap <rdunlap@infradead.org>
To: Andres Rodriguez <andresx7@gmail.com>, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, mcgrof@kernel.org,
alexdeucher@gmail.com, ckoenig.leichtzumerken@gmail.com,
kvalo@codeaurora.org, arend.vanspriel@broadcom.com,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/9] firmware: some documentation fixes
Date: Tue, 17 Apr 2018 13:59:54 -0700 [thread overview]
Message-ID: <63e446c5-fbbb-cdbb-446c-43577c82f157@infradead.org> (raw)
In-Reply-To: <20180417153307.3693-2-andresx7@gmail.com>
On 04/17/18 08:32, Andres Rodriguez wrote:
> Including:
> - Fixup outdated kernel-doc paths
> - Slightly too short title underline
> - Some typos
>
> Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
BTW, Hans de Goede <hdegoede@redhat.com> has already submitted a patch to
handle the file rename(s) for Documentation.
> ---
> Documentation/driver-api/firmware/request_firmware.rst | 16 ++++++++--------
> drivers/base/firmware_loader/fallback.c | 4 ++--
> drivers/base/firmware_loader/fallback.h | 2 +-
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/driver-api/firmware/request_firmware.rst b/Documentation/driver-api/firmware/request_firmware.rst
> index 9305bf4db38e..7632f8807472 100644
> --- a/Documentation/driver-api/firmware/request_firmware.rst
> +++ b/Documentation/driver-api/firmware/request_firmware.rst
> @@ -17,17 +17,17 @@ an error is returned.
>
> firmware_request
> ----------------
> -.. kernel-doc:: drivers/base/firmware_class.c
> +.. kernel-doc:: drivers/base/firmware_loader/main.c
> :functions: firmware_request
>
> firmware_request_direct
> -----------------------
> -.. kernel-doc:: drivers/base/firmware_class.c
> +.. kernel-doc:: drivers/base/firmware_loader/main.c
> :functions: firmware_request_direct
>
> firmware_request_into_buf
> -------------------------
> -.. kernel-doc:: drivers/base/firmware_class.c
> +.. kernel-doc:: drivers/base/firmware_loader/main.c
> :functions: firmware_request_into_buf
>
> Asynchronous firmware requests
> @@ -41,7 +41,7 @@ in atomic contexts.
>
> firmware_request_nowait
> -----------------------
> -.. kernel-doc:: drivers/base/firmware_class.c
> +.. kernel-doc:: drivers/base/firmware_loader/main.c
> :functions: firmware_request_nowait
>
> Special optimizations on reboot
> @@ -50,12 +50,12 @@ Special optimizations on reboot
> Some devices have an optimization in place to enable the firmware to be
> retained during system reboot. When such optimizations are used the driver
> author must ensure the firmware is still available on resume from suspend,
> -this can be done with firmware_request_cache() insted of requesting for the
> -firmare to be loaded.
> +this can be done with firmware_request_cache() instead of requesting for the
> +firmware to be loaded.
>
> firmware_request_cache()
> ------------------------
> -.. kernel-doc:: drivers/base/firmware_class.c
> +------------------------
> +.. kernel-doc:: drivers/base/firmware_loader/main.c
> :functions: firmware_request_cache
>
> request firmware API expected driver use
> diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c
> index 71f529de5243..da97fc26119c 100644
> --- a/drivers/base/firmware_loader/fallback.c
> +++ b/drivers/base/firmware_loader/fallback.c
> @@ -536,8 +536,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
> }
>
> /**
> - * fw_load_sysfs_fallback - load a firmware via the syfs fallback mechanism
> - * @fw_sysfs: firmware syfs information for the firmware to load
> + * fw_load_sysfs_fallback - load a firmware via the sysfs fallback mechanism
> + * @fw_sysfs: firmware sysfs information for the firmware to load
> * @opt_flags: flags of options, FW_OPT_*
> * @timeout: timeout to wait for the load
> *
> diff --git a/drivers/base/firmware_loader/fallback.h b/drivers/base/firmware_loader/fallback.h
> index dfebc644ed35..f8255670a663 100644
> --- a/drivers/base/firmware_loader/fallback.h
> +++ b/drivers/base/firmware_loader/fallback.h
> @@ -6,7 +6,7 @@
> #include <linux/device.h>
>
> /**
> - * struct firmware_fallback_config - firmware fallback configuratioon settings
> + * struct firmware_fallback_config - firmware fallback configuration settings
> *
> * Helps describe and fine tune the fallback mechanism.
> *
>
--
~Randy
next prev parent reply other threads:[~2018-04-17 20:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 15:32 [PATCH 0/9] Loading optional firmware v3 Andres Rodriguez
2018-04-17 15:32 ` [PATCH 1/9] firmware: some documentation fixes Andres Rodriguez
2018-04-17 20:59 ` Randy Dunlap [this message]
2018-04-17 15:33 ` [PATCH 2/9] firmware: wrap FW_OPT_* into an enum Andres Rodriguez
2018-04-21 13:57 ` Luis R. Rodriguez
2018-04-17 15:33 ` [PATCH 3/9] firmware: add kernel-doc for enum fw_opt Andres Rodriguez
2018-04-21 14:26 ` Luis R. Rodriguez
2018-04-17 15:33 ` [PATCH 4/9] firmware: use () to terminate kernel-doc function names Andres Rodriguez
2018-04-17 20:56 ` Randy Dunlap
2018-04-17 15:33 ` [PATCH 5/9] firmware: add functions to load firmware without warnings v4 Andres Rodriguez
2018-04-20 10:28 ` Kalle Valo
2018-04-21 14:32 ` Luis R. Rodriguez
2018-04-21 14:49 ` Luis R. Rodriguez
2018-04-21 15:11 ` Kees Cook
2018-04-21 15:32 ` Linus Torvalds
2018-04-21 17:36 ` Luis R. Rodriguez
2018-04-22 20:26 ` Luis R. Rodriguez
2018-04-17 15:33 ` [PATCH 6/9] firmware: print firmware name on fallback path Andres Rodriguez
2018-04-17 15:33 ` [PATCH 7/9] drm/amdgpu: use firmware_request_nowarn to load firmware Andres Rodriguez
2018-04-17 15:33 ` [PATCH 8/9] ath10k: use request_firmware_nowarn " Andres Rodriguez
2018-04-20 10:19 ` Kalle Valo
2018-04-17 15:33 ` [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings Andres Rodriguez
2018-04-20 10:26 ` Kalle Valo
2018-04-20 19:33 ` Andres Rodriguez
2018-04-21 7:19 ` Kalle Valo
2018-04-21 8:04 ` Arend van Spriel
2018-04-23 13:54 ` Kalle Valo
2018-04-23 20:11 [PATCH 0/9] Loading optional firmware v4 Andres Rodriguez
2018-04-23 20:11 ` [PATCH 1/9] firmware: some documentation fixes Andres Rodriguez
2018-04-25 15:25 ` Greg KH
2018-04-25 15:26 ` Greg KH
2018-05-03 23:31 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e446c5-fbbb-cdbb-446c-43577c82f157@infradead.org \
--to=rdunlap@infradead.org \
--cc=alexdeucher@gmail.com \
--cc=andresx7@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®