From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751009AbdAQDhF (ORCPT ); Mon, 16 Jan 2017 22:37:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:57840 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbdAQDhD (ORCPT ); Mon, 16 Jan 2017 22:37:03 -0500 Subject: Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro To: linux-amlogic@lists.infradead.org References: <20170117030611.23827-1-afaerber@suse.de> <20170117030611.23827-2-afaerber@suse.de> Cc: Mark Rutland , devicetree@vger.kernel.org, Kevin Hilman , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Catalin Marinas , Carlo Caione , linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> Date: Tue, 17 Jan 2017 04:35:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170117030611.23827-2-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 17.01.2017 um 04:06 schrieb Andreas Färber: > + leds { > + compatible = "gpio-leds"; > + > + blue { > + label = "rbox-pro:blue:on"; > + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; > + default-state = "on"; > + }; > + > + red { > + label = "rbox-pro:red:standby"; > + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + retain-state-suspended; > + panic-indicator; > + }; > + }; The original property names for these two were led and red. If anyone has better label names than the above, please speak up. Ditto for vega-s95. On the odroidc2 it's called alive but uses heartbeat there. The vendor device tree had a third "mcu" GPIO in the sysled node, GPIOAO_6, which leads to immediate power-off. I tried using "gpio-poweroff" to configure this pin, but that driver fails to initialize because some pm callback is already registered - I assume from psci, which apparently succeeds to power-off the system, too. For comparison, the S905 based Vega S95 Telos has no such mcu property. Any thoughts? Also, any ideas how best to switch from blue to red for suspend? Add pinctrl properties above? systemd service doing echo from userspace? I assume in Android the Amlogic sysled driver handles all that logic - didn't find any suspend equivalent to gpio-poweroff. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)