From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F8BCE79B0 for ; Wed, 20 Sep 2023 10:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234422AbjITKo4 (ORCPT ); Wed, 20 Sep 2023 06:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234338AbjITKos (ORCPT ); Wed, 20 Sep 2023 06:44:48 -0400 Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [IPv6:2605:2700:0:5::4713:9cab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46336129 for ; Wed, 20 Sep 2023 03:44:31 -0700 (PDT) Received: from hatter.bewilderbeest.net (unknown [IPv6:2602:61:7e5d:5300::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id BD67D8A; Wed, 20 Sep 2023 03:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1695206670; bh=b2qKXwiiTxiZFaNZFNXiVuOFMKiJAATH/ohlZELbYyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gFbmEm38xmaD/J0VzHt33MnGzt7J3URxwDj0TpIZn+YUzo7yq8RE5Y5dNTQvDBFZh neZAIXQNF6ctr1dEkq7fzTcYAOfZVTUXMrtvnZdDgDZI40e/jzgBP1K0Fz27rVPr86 Dv40B5aQ5Zr205GaphdUN8cdtkLfyvzIpA8SN3AE= Date: Wed, 20 Sep 2023 03:44:29 -0700 From: Zev Weiss To: Greg Kroah-Hartman Cc: Mark Brown , Naresh Solanki , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Documentation: ABI: sysfs-driver-regulator-output Message-ID: <63fe0803-8120-41a8-8998-a4e6aa32308e@hatter.bewilderbeest.net> References: <20230831121412.2359239-1-Naresh.Solanki@9elements.com> <20230831121412.2359239-3-Naresh.Solanki@9elements.com> <90b1af83-cb03-476f-9147-eb06247bf09c@hatter.bewilderbeest.net> <2023090330-bling-mammary-3177@gregkh> <6eb78818-7838-4616-bf44-05c215bfa8b3@hatter.bewilderbeest.net> <763bd845-d8d6-489c-bd31-305ed14bc40f@sirena.org.uk> <1518370c-e0cd-4d78-af54-3e2cf4dd6e3c@hatter.bewilderbeest.net> <5282acd1-3c7a-4948-83f2-2829910ab841@sirena.org.uk> <25844d80-fadb-44c3-a0e6-334aa6e4afd7@hatter.bewilderbeest.net> <2023092037-denote-enslave-0a3f@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2023092037-denote-enslave-0a3f@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 20, 2023 at 02:29:15AM PDT, Greg Kroah-Hartman wrote: >On Wed, Sep 20, 2023 at 02:02:49AM -0700, Zev Weiss wrote: >> static int regulator_userspace_notify(struct notifier_block *nb, >> unsigned long event, >> void *ignored) >> { >> struct userspace_consumer_data *data = >> container_of(nb, struct userspace_consumer_data, nb); >> - static const char * const *envp[] = { "NAME=events", NULL }; > >You removed this user/kernel api value, what will break if you do that? > Sorry, I don't follow -- what removal are you referring to? The envp array still has a NAME entry -- I changed its value from "events" to "event", but I wrote that part before I realized that the 'event' parameter of the function was actually a bitmask that might convey multiple events and just forgot to change it back, so keeping it pluralized is probably more appropriate. And FWIW, I didn't intend for the exact format of the EVENT parameter that I sketched there to be something that had to be kept; given that there might be multiple entries perhaps it'd be better to use separate parameters more like NUMEVENTS, EVENT0, EVENT1, etc? (Or omit NUMEVENTS and just let the consumer count upward until it doesn't find a match.) Zev