From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60AC830F95E for ; Thu, 20 Nov 2025 09:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763629729; cv=none; b=mkHcrrL2+clcZ2vaBOTJ3u0E6IZ3is9kOaJh7yQiX2wydZLS6VEgIM/KEx/PDlDuhwwpr+msAoKsQIrbGqBhhNlJM2fu4SMObTSHuaq9jWcMY27RGPbmoiTkY6UJ06fj2OUafj+3pzA94CIImmqQcIIr7dU0snSECXSccsCOZTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763629729; c=relaxed/simple; bh=3XgE8nzjlFnG5w7yTHIlKYeLdGWsQdHgYXqGvq3XWQ8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=UOQAx/eyCiE9tvMh91pnR+yRrlzdvtDYy94K3yvK7KFPxoTeFVITFwZNIj0m9VJoHjOzJuQOHRetiwws7YFzLm05evlYpKj24w/yNy1HSNTi6D2dqHma8RARGEuBoXvoR9dQ844LRRBXDdz8aQ/O7FaCCNcLjxfU4N+C1wQB4GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i03Wa1Kl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GwPkzBjW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i03Wa1Kl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GwPkzBjW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK56khC4026682 for ; Thu, 20 Nov 2025 09:08:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ai+/yCdmM2wE0r8VW/1OQ/CHWsFY0swhqxkIqvv02i0=; b=i03Wa1KlHJrtWRKm nsovooCjguse9mFoVqtRbJg3Msy981FmCPDEPs18DxSXnZ4eDwKbv7+dVVTcZ7pC A9yV5s6UwYKxCUM2PU2fcs9xXCRHlMV2Nq3pkmKg7cEQf+khcbohPHUgKOyu1MWx Kgbkt6ilT3cCTBZLt0VrFDCchE+S4zumi3QqVC+mXWRtLOoBfCT3gJlqX6qLUdTx JaBNXk0xFD9Vap9+83okzpaybwgC0R8KT2C7ckDDgV9hxWxFk8GQkiN7qYvUM3fQ vqnR51XDk0XM5iSGPtJiNE2n7tAhcnKpurYwo/bwYDV+uHKKUpe/dkjA1Ll+XQdo QduR9A== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahvj3gnxg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 09:08:45 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2958c80fcabso21861325ad.0 for ; Thu, 20 Nov 2025 01:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763629725; x=1764234525; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ai+/yCdmM2wE0r8VW/1OQ/CHWsFY0swhqxkIqvv02i0=; b=GwPkzBjWIb8m3R2DX7AHvzJFLl2krroo9gLJhI6uHqnkBa0t5+xdWmGnZzb94yZLsC LgXocREToYhiuHjYSArd7XadG4zPzIjAPbQ23KDh2sVZb2nDfRlNFiE8LFkyb4L4qjEQ Fb5iEXwiW5P7VyYLCtxgv4nDkqNive61QxygjXWBY3434Gu4RoptVYOA612OQcXMBk0V 3bgTDeoZAudUcMh1CBkXKudVX8X5kv9OYQRJka8DicB3SEld9IhWInnlXBKXrKFksVOB cpJZsdzxJ86+Bb5zHKrOIF06MK4Y8BQe12r8WRCPGFpci5VZl8Muse39Ef81dbYfPqZ9 kpGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763629725; x=1764234525; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ai+/yCdmM2wE0r8VW/1OQ/CHWsFY0swhqxkIqvv02i0=; b=j9FGH5l/DKvI9BPafTYf3lwwnBe57XXfdF92Gk7V11RyuNJNUfoEPg5pgr8oBCAluq a4pCAm36UvLQSAz2czXvEUZRehCyW0GQHKqTBbYR+b1K/Ufi6nWI1eBCqK5Xxir0krI3 UZdLeDAxg+iZdKgG18p6Dc+AonrG7N/49dLG47R9t/7bJ7NmWfNgrErk+cnSB8aMjFbR t5JfMN2TWpVMn0vmlC0O91VAlMzNdNbu/4TDIHsi1079YeolfpLpyUbEvSJXQ6YcZHSm cQe8fCk7qeJGhLJuEsFl88hAagS5UC+JCLAk4konQm25lZh1bkK9TL14JuPT4UiaiJaM 8HaQ== X-Forwarded-Encrypted: i=1; AJvYcCVv5es71dsn/twMVB4rfVGCaKYCLOMaEEmEeJQge1xOPdE+WCbwl8YHI01VG0Jgsc9SR2PY3RJfcl8Pa/E=@vger.kernel.org X-Gm-Message-State: AOJu0Yylaz3CERtgqsu7StYbwAsqaLikMMgasSoSfcRAsEN3qxJmES5e 7L9Cm9PjHP9G6v8wRkS0iC0321iC5rr4/K8NaXOZmQmnZIFXZaJk0YsG1AGH45s0rPUJjqEnFO7 ON2onBVaW6860GcxQ2XJF7KfHwCIsw2EVTuagdSpkboTJ+bdE87jImcX0XB5EEMRvlIjByGqycE cqyA== X-Gm-Gg: ASbGncu8kYtNE4ETcroXfyNPSA19ef9oRoJV1t0Zq0z+UIgNbUVgxZeCONdw2aPCBBN ui0VYhV0pUxFTTqih/q4N5/dmGk01Tel/q/KujRYa7NOnlcP29t7uiE+EW0vqJONlhZ+1b6VETY OUTycEFRezkq3wYXRUVzWNcDaNbL8MBYiEiflcgqkVrD/L5o3KtdbHolynvNaFGHnu7dzBzH1IS oUY3mkELg0kPXB1SsSStUKoCMBZ7LKD65HnNRa5hgx3bNLTmGbMJheV8VZ+TMmxThVikF/9UcYg N/Zi625SAhXjLKi4/tFJ2mhEnlJ0fKiuQnx1Bq5FdXji2jdvYFNVxhlwaGGeqhj3ORT00+jhCPb Jj5VD0PuQxb6yC0q5q+PLgH0BYGT9EzB/foe0XNJMEixkP7Geb4FA09LgCKoI6MIWDS7BQRof2M E5UclR X-Received: by 2002:a17:902:ebca:b0:298:485d:5576 with SMTP id d9443c01a7336-29b5cccdb92mr23444785ad.8.1763629724627; Thu, 20 Nov 2025 01:08:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAH62cUQ+tdqLl8UgT0ThXtjWfj7cqkt5nH/Im2b6NF937Lzu04lbfzZwMTb2BWazn175b3Q== X-Received: by 2002:a17:902:ebca:b0:298:485d:5576 with SMTP id d9443c01a7336-29b5cccdb92mr23444225ad.8.1763629723913; Thu, 20 Nov 2025 01:08:43 -0800 (PST) Received: from [10.133.33.205] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b00e1fasm19903285ad.0.2025.11.20.01.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 01:08:43 -0800 (PST) Message-ID: <63fea0e6-1ce5-4f71-8531-a01535326374@oss.qualcomm.com> Date: Thu, 20 Nov 2025 17:08:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: kodiak: Add memory region for audiopd To: Bjorn Andersson , Mohammad Rafi Shaik References: <20251114055639.1050-1-jianping.li@oss.qualcomm.com> <20251117070819.492-1-jianping.li@oss.qualcomm.com> Content-Language: en-US From: Jianping Li Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, ekansh.gupta@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=J8WnLQnS c=1 sm=1 tr=0 ts=691eda9d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=hviViZdL3PNssb8YJeMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: Jwy4Gd6G1JsgwrwBrOKTzl-ojggDpyAt X-Proofpoint-ORIG-GUID: Jwy4Gd6G1JsgwrwBrOKTzl-ojggDpyAt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA1NCBTYWx0ZWRfX38yvVdZy9h/b RQI0eDBPPStK7MbnB0Oi6QgUmUGrli+Ca6pPxyadSZTdUlis4UKYy17hCQVCKSNAGubc24JRWOa Ax3oe0VYYCIku1U0piPr/uGsxuJXHiPUtXCrC4eJblsL6WHhnys53HUWRPjDgaOEcq8OJmERMZv 9ACirYUOcR1Lkx8JTB8Y+b5ywYVjab6xsmvinLr7Jsil6j4XfUpKY85lilKNmaHP0QKs84fFqfE lunz1uxZRWIgoJ+cjmnjkuA/WJTqj4Lasqp9WKyKrgiGDfR+s9As1GjO/rRpAM/gY4h2UfN0fOw COaXMCxJ6C9YcI3c1al7FeNfzBqcxw3XR2kFVX+Gji0XvRPfcfPJ0UAW3V4vH+DkfLP7g3jrgRb fjsQxm/SrHIozLhQR6Orr1PTENfNmg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_03,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200054 On 11/18/2025 11:39 PM, Bjorn Andersson wrote: > On Mon, Nov 17, 2025 at 03:08:19PM +0800, Jianping Li wrote: > > Please don't send new versions as replies to older ones, and please > adopt b4, it will take care of these practicalities for you. Ack. I'll fix this going forward. > >> Add reserved memory region for audio PD dynamic loading and remote >> heap requirement. Also add LPASS and ADSP_HEAP VMIDs. >> >> Signed-off-by: Jianping Li >> --- >> Patch v1: https://lore.kernel.org/all/20251114055639.1050-1-jianping.li@oss.qualcomm.com/ >> Changes in v2: >> - Fixed the alignment issue of the qcom,vmids properties, aligning >> the values in the second row with the first row. >> --- >> arch/arm64/boot/dts/qcom/kodiak.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> index 3ef61af2ed8a..7957a9151055 100644 >> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> @@ -190,6 +190,11 @@ rmtfs_mem: rmtfs@9c900000 { >> qcom,client-id = <1>; >> qcom,vmid = ; >> }; >> + >> + adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap@9cb80000 { >> + reg = <0x0 0x9cb80000 0x0 0x800000>; >> + no-map; >> + }; > Is the placement of this carveout hard code somewhere in non-HLOS > software? If so, its location and size universal across all Kodiak-based > devices? This information is not hard-coded on non-HLOS. Any region(irrespective of placement) allocated by fastrpc is moved to LPASS using qcom_scm calls. > Also, the presence of arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi > tells me that we have different audio stacks in play on Kodiak. Does all > of them have the same PD loading capabilities/needs? This DT looks to be audioreach specific. The one I'm adding is mostly used for audio PD dynamic loading purpose. Adding @Mohammad Rafi to give more details about audioreach. > > > PS. Others might ask these same questions in the future (I will probably > wonder in 6 months from now...), so let's make sure the git history > carries the answers to why things look the way they do. Ack. > > Thanks, > Bjorn > >> }; >> >> cpus { >> @@ -4139,6 +4144,9 @@ fastrpc { >> qcom,glink-channels = "fastrpcglink-apps-dsp"; >> label = "adsp"; >> qcom,non-secure-domain; >> + memory-region = <&adsp_rpc_remote_heap_mem>; >> + qcom,vmids = > + QCOM_SCM_VMID_ADSP_HEAP>; >> #address-cells = <1>; >> #size-cells = <0>; >> >> -- >> 2.43.0 >>