From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C703EE4993 for ; Tue, 22 Aug 2023 16:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237534AbjHVQNq (ORCPT ); Tue, 22 Aug 2023 12:13:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbjHVQNp (ORCPT ); Tue, 22 Aug 2023 12:13:45 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9546F137 for ; Tue, 22 Aug 2023 09:13:43 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D84E899; Tue, 22 Aug 2023 18:12:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1692720744; bh=pXAGmakmjiG9tclGDThSE3v81Zw+kHIuHhBkCItvcHU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AvI6AEbsnrJ2+uff57WM74SqJo5OnmTsDHukR6AJegRp/K+8DCDRk7JUvx9lBVk7J JpoeJ7cg4bgVBVaYWg49cy7C+S7l7tFDIXvPU5LweXk42go5On6RrWONLuaZrsoPw6 hSix0SCR2eWhuJiKhazxdMBzvoxLhEUnbXsJlmWg= Message-ID: <64087bda-aba5-dae4-40b4-3c6113a496ed@ideasonboard.com> Date: Tue, 22 Aug 2023 19:13:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 03/12] drm/bridge: tc358768: Fix bit updates To: Maxim Schwalm , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Francesco Dolcini Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Aradhya Bhatia References: <20230816-tc358768-v2-0-242b9d5f703a@ideasonboard.com> <20230816-tc358768-v2-3-242b9d5f703a@ideasonboard.com> Content-Language: en-US From: Tomi Valkeinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2023 01:22, Maxim Schwalm wrote: > Hi Tomi, > > On 16.08.23 13:25, Tomi Valkeinen wrote: >> The driver has a few places where it does: >> >> if (thing_is_enabled_in_config) >> update_thing_bit_in_hw() >> >> This means that if the thing is _not_ enabled, the bit never gets >> cleared. This affects the h/vsyncs and continuous DSI clock bits. >> >> Fix the driver to always update the bit. >> >> Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/bridge/tc358768.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c >> index bc97a837955b..b668f77673c3 100644 >> --- a/drivers/gpu/drm/bridge/tc358768.c >> +++ b/drivers/gpu/drm/bridge/tc358768.c >> @@ -794,8 +794,8 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) >> val |= BIT(i + 1); >> tc358768_write(priv, TC358768_HSTXVREGEN, val); >> >> - if (!(mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)) >> - tc358768_write(priv, TC358768_TXOPTIONCNTRL, 0x1); >> + tc358768_write(priv, TC358768_TXOPTIONCNTRL, >> + (mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) ? 0 : BIT(0)); >> >> /* TXTAGOCNT[26:16] RXTASURECNT[10:0] */ >> val = tc358768_to_ns((lptxcnt + 1) * dsibclk_nsk * 4); >> @@ -861,11 +861,12 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) >> tc358768_write(priv, TC358768_DSI_HACT, hact); >> >> /* VSYNC polarity */ >> - if (!(mode->flags & DRM_MODE_FLAG_NVSYNC)) >> - tc358768_update_bits(priv, TC358768_CONFCTL, BIT(5), BIT(5)); >> + tc358768_update_bits(priv, TC358768_CONFCTL, BIT(5), >> + (mode->flags & DRM_MODE_FLAG_PVSYNC) ? BIT(5) : 0); >> + >> /* HSYNC polarity */ >> - if (mode->flags & DRM_MODE_FLAG_PHSYNC) >> - tc358768_update_bits(priv, TC358768_PP_MISC, BIT(0), BIT(0)); >> + tc358768_update_bits(priv, TC358768_PP_MISC, BIT(0), >> + (mode->flags & DRM_MODE_FLAG_PHSYNC) ? BIT(0) : 0); >> >> /* Start DSI Tx */ >> tc358768_write(priv, TC358768_DSI_START, 0x1); >> > > shouldn't the last patch of this series be moved before this one? > Currently, this patch will still lead to a temporary regression until > patch #12 is applied. Indeed, good point. I'll change the patch order. Tomi