From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6C622B5AD for ; Mon, 16 Feb 2026 11:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771239930; cv=none; b=fApXkLHDYUBXc2YxKBDl8s3c5Tk6b6sjU6SpNeB7QOSqNr13KDGOCzRO7SjWc3GmvtBiZIXVm9Gr3KVZnKccNi87w29J2P2TEy9vKsESsmvoLkaevv5S+hTZwuAOWVPcfVFOWsJu3GIJatR9REkecS0cEY+yDXTEXfSBuO5U95w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771239930; c=relaxed/simple; bh=axEx3VHoc5uojuaL7EUNQLo4zjFgdBEAqt3gWqgER+Q=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=V5nAL/zQlKz7YEkILjtbUhNdWHlmozjxV1BqvYkc0kULQxpk1hviObcA2EmOKKXFggleZk/U5wO7vNv1yzSxNISujno0PV9xoLKqMPHq3gy/XZP+vdkiGhzC3t2T2h2TOQoeCAIw8pN7O7DfRX8w7Y6Fh9juBM4Kd4a3xj0cnWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YECjFPrT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LwQqwa52; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YECjFPrT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LwQqwa52" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61GAtBBL2647738 for ; Mon, 16 Feb 2026 11:05:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YMni5B+nUretOJRqmOjn0HSOX+2VPm/OmABagc+5UNs=; b=YECjFPrTbJi/78dy VTN+dqQabkXQsCm5po2S4ioJtsaTNDcUgJApYOxY0afbfs6J54c98f/VNPJamoCi TBEBl6e5CN05uBnD76Di8cnakJ5T7498UkuVzHIXVUPkcgC4l6/w2YC2Mf+fndtX kn79mRhaSyx/KqSbe3GX9m8VeCFTZdOV5qSWC1EGfAFxQm0UysFQMjG+UM8fQ3+n HQxg6SCpqO7LLnvYsGKcSqnWZ0LtWkngVHk5zNDj9q0s4I9i1K6Cw0RlL2O1VD2q YZXwMBC5D26/aoUMDGf+bQSXfF5lc86ba3TbNECXzMXouQ9Q1ikGpIqT3tIEEq+I R4lTEg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cbfuw1ve0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Feb 2026 11:05:28 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b630753cc38so12262268a12.1 for ; Mon, 16 Feb 2026 03:05:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771239928; x=1771844728; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=YMni5B+nUretOJRqmOjn0HSOX+2VPm/OmABagc+5UNs=; b=LwQqwa52ORg7bzE+BtwWEsSdLFcuCdxypbbgilAK8vflUYURFcOkGSVyFNntBw5JOC ulJz4pjFd4JTmQOIx27uFRyGPqJpKkR5SUx8nZ+XH9tSCtwUEQ2ZD1ZQigEkWJzAMkIm 73jba1uqGWyfeXmnr4s1PVyF50OHpDoqy03o01pS2Yin6CBOACaOIVAFReWXV9mCmVig 8ESynmc/nv6MTMh8bVaKGvxYyzXsuhyTMKvzVLv6VAgUWMGVOP2icbgDMSxT5JnwEObb gd3tbt+IgGjfabpla32dnBO+I0LNDnmg16nN66z3UeZGbbCqm+cSm+Z0a+MIVzvO8qjt QlDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771239928; x=1771844728; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YMni5B+nUretOJRqmOjn0HSOX+2VPm/OmABagc+5UNs=; b=Uvs1+ZdGME9SG2WajG15TLlQ8rvLSj7qQWuTqm+fc+Gd/SdcFCMNs6SuhRLcrFkDVt d6QSBVaDf4t1JKx7cVQCn9BhIoSs8rSPqTzRqyfGn0zI4h13Sk/aDgoH9YmbNLmZ/Oel dw+rMEzTRF4WZUwmP07m1qY0p/nwrruPpCvb4LnxfKYl6LmGjZY2vo8Mwh5dQL3Zr+uq P3iX29kB6pXV3zvB/leitq5xfGx3n7eFQE/8SpD51/kKPOd/XaLNDMU8ZCOmwEE+LJzS 5S58cLvh1YEifF9Uu2oDX4WTy5MT3regJ4VAx/Dirc/QPKvDxxa3djT4KzmZU+Pm4/0O L/cQ== X-Forwarded-Encrypted: i=1; AJvYcCX/wWsLGgpkedTuDHHtT7MTTjJmMgBj2CinKOVyBFMFPSWWlItAR5GkfFdiHpc1EeBxD/lz1gYpll7kwts=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl/Y9kp3miFrYiZn/ABqPsWjGFP26Bbgnl4yfgz001DFE+kGpG Phz75F/aL7oWpgCcG6n6jt4UN4ZtM8wNqE1OHn2k11gidvyNVCQp97BOa1WNokb1WuTAchgn+DL z6+cF1IRjVO+VR2/IrgM5w1NwJpicQYyul/3d9F65tFPb18mIW0M7UjF3eXJcQ8QIj6WbaK6M4l Y= X-Gm-Gg: AZuq6aLs34JJY+DNgNZfl59Wns4Ekui4GgYqYb55X5rC15hH3rJ4K9NlNvusE1s96W3 DZVoXSIhc8d0XUOSVlM5/v6jq+Y1uYyN9SxMtyWh7mllDzxOH1tqp82znVsU9+006RFsv4DEPMP grpiAdA3ZSLwoiUsLj9qaf5YBo/Zd9juAlNmAn+mRjIjwBg7rvWkVoRii/TNBSf54FoJyRdFWBt jbu8dJd5D6b2TPuuEHgLircwQp+wbFEnJ34Njo80GYyioV/70VKimRrhsflFbYkMmFBKBFRZDF4 dtPhGPQKsC/0K6zAlv7AtvsjrF7d9gUcmFruTgBsI45Wr9nvoTY7YzMuIFjDBNEebz1PinhQ+Is ZLArco2jueXBZh5ySusONJGgEPgI+K5jsR3yVWF2WT96GCX0+Dg== X-Received: by 2002:a05:6a20:3d8e:b0:366:19a5:b492 with SMTP id adf61e73a8af0-394671146c2mr10383861637.5.1771239927842; Mon, 16 Feb 2026 03:05:27 -0800 (PST) X-Received: by 2002:a05:6a20:3d8e:b0:366:19a5:b492 with SMTP id adf61e73a8af0-394671146c2mr10383837637.5.1771239927339; Mon, 16 Feb 2026 03:05:27 -0800 (PST) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e532f2ba0sm6281191a12.25.2026.02.16.03.05.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 03:05:26 -0800 (PST) Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle To: Krzysztof Kozlowski , ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Abhinaba Rakshit References: <20260206112053.3287756-1-neeraj.soni@oss.qualcomm.com> <20260206112053.3287756-2-neeraj.soni@oss.qualcomm.com> From: Neeraj Soni Message-ID: <640e2eca-1656-1723-38e8-d6cd97e6e2e3@oss.qualcomm.com> Date: Mon, 16 Feb 2026 16:35:22 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Jb+xbEKV c=1 sm=1 tr=0 ts=6992f9f8 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=GgeKcXs6izqwwY2gQxYA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ExvnccqzCCEplK-VVcMsNizTyWvVUNRw X-Proofpoint-GUID: ExvnccqzCCEplK-VVcMsNizTyWvVUNRw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE2MDA5MyBTYWx0ZWRfX0uQYuEMQYWIS ErrzkbSFWNT7v60Xmy/X0YyeAvSC5fMPVLYWlnYoQ+U7EW9DgTPTZ2UVWtfY/rSph3U0WRpY3KP eHfXAO9s5mPEq3pTOw2zVImnPdFMrK6iyJ2IWZGnAKgl2S6/JGJmJDyrH+Qi1l64MjrzOY0G/Lu aE+fE1mV5crA0UvNzb5rM2cB3/AQT70MEONGzFSiv3+TpL3p88SZ3liurRwQZYr3NMlQQr5Dvkp 1rsu23qMSrQNombsyzzNQM0wp1DXKDSh05af+7mMjHXxEs2lFFgpzFG4RBS+bmB4qUE0wyMSOJT FPM1OmbGyYmoVK/hy5WQtC1bMwHJcLMUt+xVqOXo+qbjOQRNjQnLbZRSbZrC+cLBZC8oU/iyzkr Eo3wNU0ki9EgiKTNJFccBNUE5hkW71g5Xr7QsWVI6E6BU3/Vo9ONqJslRCp6oc9a5R3XGVmyXhH dNGR6jDxCVy7hgVO8DQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-16_04,2026-02-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602160093 On 2/6/2026 4:56 PM, Krzysztof Kozlowski wrote: > On 06/02/2026 12:20, Neeraj Soni wrote: >> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >> So add the qcom,ice property to reference it. >> >> Co-developed-by: Abel Vesa >> Signed-off-by: Abel Vesa >> Co-developed-by: Abhinaba Rakshit >> Signed-off-by: Abhinaba Rakshit >> Signed-off-by: Neeraj Soni >> >> --- >> >> Some initial work is done by Abel here: >> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/ >> and by Abhinaba here: >> https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/ >> >> This patch adds the purpose and usage for phandle in the description and encodes >> it properly in the schema. >> --- >> .../devicetree/bindings/mmc/sdhci-msm.yaml | 26 +++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> index 938be8228d66..f35b675c9f16 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> @@ -140,6 +140,12 @@ properties: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: platform specific settings for DLL_CONFIG reg. >> >> + qcom,ice: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: | >> + phandle to the Inline Crypto Engine node. ICE having its own platform driver will use this phandle to > > Please wrap code according to the preferred limit expressed in Kernel > coding style (checkpatch is not a coding style description, but only a > tool). However don't wrap blindly (see Kernel coding style). > Sure. While executing dt_binding_check the tool reported max limit as 110 characters so i wrapped around it. I will consolidate the description to single line in next patch. > Do not need '|' unless you need to preserve formatting. > Ack. I will limit the description to single line. > > I do not understand the platform driver reference here. You are supposed > to explain how the hardware uses it, for what purpose. If I change Linux > to use auxilary driver, then the binding is incorrect? > > >> + manage its resources independently. Either add this phandle or ICE address space for ICE to work. > > Don't repeat constraints in free form text> Ack. Will fix in next patch. > Such trivialities should not happen, I am sometimes skipping deep dive > review, so I skipped the rest. > > : > > > Best regards, > Krzysztof > Best Regards, Neeraj