mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Mauricio Faria de Oliveira <mfo@igalia.com>,
	Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chao Shi <coshi036@gmail.com>,
	kernel-dev@igalia.com, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: reject completions for requests that are not in flight
Date: Wed, 4 Nov 2026 13:01:36 -0700	[thread overview]
Message-ID: <641c7c0d-0455-490a-8811-e6eda728a7e7@kernel.dk> (raw)
In-Reply-To: <65414ea51d23fdbeb5d8b7bb4bd9d535@igalia.com>

> I agree that a device in this state can't be used successfully, but the
> kernel should, IMHO. 
> Say, in case the device hits this due to firmware which needs an update,
> the kernel crash might prevent the user from applying it, in the first
> place.

OK, now we're really reaching... If the device is so buggy that it can't
even do basic operations without violating protocol and crashing the
kernel, then there's nothing the kernel can (or should) do to try and
prevent that. We don't cater to severely broken firmware or devices.

Please stop all of this nonsense.

-- 
Jens Axboe

  reply	other threads:[~2026-11-04 20:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 19:18 Mauricio Faria de Oliveira
2026-11-03 19:21 ` K
2026-11-03 19:41   ` Mauricio Faria de Oliveira
2026-11-03 19:43 ` Keith Busch
2026-11-03 19:47   ` Jens Axboe
2026-11-03 19:54   ` Mauricio Faria de Oliveira
2026-11-03 19:59     ` Jens Axboe
2026-11-03 20:06     ` Keith Busch
2026-11-04 19:46       ` Mauricio Faria de Oliveira
2026-11-04 20:01         ` Jens Axboe [this message]
2026-11-04 20:08           ` Mauricio Faria de Oliveira
2026-11-04 20:11         ` Keith Busch
2026-11-04 20:21           ` Mauricio Faria de Oliveira
  -- strict thread matches above, loose matches on Subject: below --
2026-05-22 15:30 Chao Shi
2026-05-25 20:27 ` Chao S
2026-05-27 14:19 ` Christoph Hellwig
2026-05-27 15:02   ` Jens Axboe
2026-07-15  0:03     ` Chao S
2026-05-27 15:00 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=641c7c0d-0455-490a-8811-e6eda728a7e7@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=coshi036@gmail.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mfo@igalia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®