From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCEEC433F5 for ; Thu, 23 Sep 2021 03:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 265DD61038 for ; Thu, 23 Sep 2021 03:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239098AbhIWDbr (ORCPT ); Wed, 22 Sep 2021 23:31:47 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:9909 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239084AbhIWDbq (ORCPT ); Wed, 22 Sep 2021 23:31:46 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HFLCS56bjz8ylZ; Thu, 23 Sep 2021 11:25:40 +0800 (CST) Received: from dggpeml500023.china.huawei.com (7.185.36.114) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 23 Sep 2021 11:30:08 +0800 Received: from [10.67.77.175] (10.67.77.175) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 23 Sep 2021 11:30:07 +0800 Subject: Re: [PATCH] sched: Make cookie functions static To: Peter Zijlstra CC: , Ingo Molnar , Juri Lelli , Vincent Guittot References: <20210922085735.52812-1-zhangshaokun@hisilicon.com> <20210922125034.GS4323@worktop.programming.kicks-ass.net> From: Shaokun Zhang Message-ID: <641d5dfb-1c72-9fc3-0844-d4eab8115173@hisilicon.com> Date: Thu, 23 Sep 2021 11:30:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210922125034.GS4323@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.77.175] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500023.china.huawei.com (7.185.36.114) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 2021/9/22 20:50, Peter Zijlstra wrote: > On Wed, Sep 22, 2021 at 04:57:35PM +0800, Shaokun Zhang wrote: >> Make cookie functions static as these are no longer invoked directly >> by other code. > > Yeah, this was supposed to get used from the cgroup code, but that never > happened. I suppose we can do this for now, easy enough to revert Got it, Thanks your reply. > if/when etc.. > . >