From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932780AbcILKfn (ORCPT ); Mon, 12 Sep 2016 06:35:43 -0400 Received: from foss.arm.com ([217.140.101.70]:46406 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbcILKfm (ORCPT ); Mon, 12 Sep 2016 06:35:42 -0400 Subject: Re: [PATCH] arm-cci: add cci_enable_port_for_self() declaration in arm-cci.h To: Baoyou Xie , will.deacon@arm.com, olof@lixom.net, mark.rutland@arm.com, bigeasy@linutronix.de, a.hajda@samsung.com References: <1473676381-11049-1-git-send-email-baoyou.xie@linaro.org> Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Suzuki K Poulose Message-ID: <641df89f-541e-dea1-4144-2c6d43fac7b2@arm.com> Date: Mon, 12 Sep 2016 11:35:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473676381-11049-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/16 11:33, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/bus/arm-cci.c:2027:25: warning: no previous prototype for 'cci_enable_port_for_self' [-Wmissing-prototypes] > > In fact, this function is used in a few files, > but should be declared in a header file. > > So this patch adds the declaration in arm-cci.h. > > Signed-off-by: Baoyou Xie > --- > include/linux/arm-cci.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/arm-cci.h b/include/linux/arm-cci.h > index 521ec1f..b88f6fb 100644 > --- a/include/linux/arm-cci.h > +++ b/include/linux/arm-cci.h > @@ -30,8 +30,10 @@ struct device_node; > > #ifdef CONFIG_ARM_CCI > extern bool cci_probed(void); > +extern asmlinkage void __naked cci_enable_port_for_self(void); > #else > static inline bool cci_probed(void) { return false; } > +static inline void ci_enable_port_for_self(void) { return; } > #endif > Don't you think the above definitions should depend on ARM_CCI400_PORT_CTRL than ARM_CCI ? Suzuki