From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E1902ECD1B for ; Mon, 19 Jan 2026 16:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768840342; cv=none; b=NnbzoFD5hYzAX4O9rEpeiybTvBAZ8S23+AQxMAtO1hnuBNLgBtSHS8g+Rq9gjobAEmfnZiWwG9lpHSqAy31MJb0rjTNc/TDR/H1mqi8wX3w2gN+kHGJa9eY4pOcUjo8tayqEt0TmC7L6YtmyE2576wNG6OJ9vJUjrKr7lRbPrkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768840342; c=relaxed/simple; bh=B+g+zAeh2+pzoK5A+M8dGusGX4B9hC1X9nkV+EwZ4qU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dwb6iYUEggb0fvonmYWyZWGfNy8VnIhoii0T9CDVDHQ7AgyPE4NKOnJLq9OsKD3HMU2aQxylsxWqMJDipJ5dKQONVDquTZPWFg5dctpl5zOE/YOq0rbM39w768/vyMkg/Cp47OIWTyy+KTCY9XgFVtHBYmFWU5YwwzSaccdAtiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fT49PWUe; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fT49PWUe" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa4so3983505f8f.1 for ; Mon, 19 Jan 2026 08:32:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768840340; x=1769445140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZGRyge8mUxn1upWUm4+fpElZBMmBnwRd/xao08TqzY8=; b=fT49PWUekaP+4uT9XYY2eb3M3iXaHQW7xhP9I0aBCE8uARy+ak+8rM2ilhWkFsHwU6 Oj3vi299MOg4BMf9JB/wiRdofm0RIyRnyNCIoGiBcQnPrRa1X7OqgSdxRYm68+0EIYhu cjEN9KSeuh6WscXs7uUgZ5aWPK5wkWlelVSMTbbPUeq9G/TPjhYp4yoIE+CPt97QQ6AH RIEgaJuPwH5+8h3LepMZQxRnd8Kh4shLzbJzblG+VgVRsDrD9S+7A2JF+2PUSg82sk5e wR0TfaH8kOrCRKoXsB3uOerQo1DpCIZ5Kbob2mJtoEx9yaNdFBDudLYQR8EhIAFyT3NN BzTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768840340; x=1769445140; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZGRyge8mUxn1upWUm4+fpElZBMmBnwRd/xao08TqzY8=; b=rb1vOX9aonVjLHzDEtwXT79vEDwCmDB+nADnNKrHGqlUJFvEUYpHmc5ET2OhNgQRTc oP/NMghgm65v0bf2VCm0OJj9SDL0Q24L2zorBilpbVOe3FpVUgl9HTW1/uHFrYXkloEF 2yBTP+vYkoR9ZCkblKePXlc8OAfrgD3oSENQ7WQdrfifOWH/9p9Fqx67mGya2bP74nIN 2HWd601ikUIX00KCkGKAQrOVMqwakALfpmNE0ddXlNT+WH4Lyu14jE2weYHleZC4AYk9 e65e+b3nRQqkcv6LqUKwgMhsL/r2yX4SHT9gtUgwSknw9HAIXu/yjwCx7HADTWPsKkKS x2Hg== X-Forwarded-Encrypted: i=1; AJvYcCU+ghAv+3inyrmz3lRSjYh3MdzDXuuoOfL90jdxzNOEQb86lF0Lzgztt9mU9dZUMIU3L1Qj1vuPlCfg3Ws=@vger.kernel.org X-Gm-Message-State: AOJu0YxkTNHAu6udtsVJXjjZKrl/Dxg4OC/g5x6xIlYq7ovAGYjdVPZM 4ku+vdEwOr/SDL81hexqVMBVmfrH8flWpFrQ/NhBPBO6WmrNkfsRNZNrAyY4rAb49eYa92xIyDy Y+VzjVNc= X-Gm-Gg: AZuq6aJysPGlANlcZpn62CmzOwewjZcr5yJRbnJbiisvrr+UJafYyPPkMPx8oIqL9a7 gITVD+LQALW2ENh2wWyiB9C7u+ffONQCm4j/8yvaF9Z42bDDZHrFGQNjj7dpds4Oesebw61Igra eMqsxJx56SEUK+qEx+jBKQewj1eEI+4dRr+yBFUrlz2X08nelN/BUp5kPRH+Yw/9XAFH++T7nEd SOOE6s6IKfAXuQftevCM62x3DKzCsR67YpJTgBpi/AEaRJA7w7rKfAGntRxONOxn+zvQjWD0Zel 9ke1puLWB+H9LP9kYxuCjkWDP8YDhQjWEqVFuif8t+RKBuPxQf+jhMDh6yxfCok5Dn8IziX8KNm vgJozi+IiNRDido0l6fKSBaLifMa0L7DkHLzvjfjeQmuDwRe53zUDV2tYgIxiQGkkEFLYAWrE6i 75EQk+e9jz8Fe7dz4D X-Received: by 2002:a05:6000:186b:b0:430:f255:14b3 with SMTP id ffacd0b85a97d-4356a082ecamr13614502f8f.43.1768840339646; Mon, 19 Jan 2026 08:32:19 -0800 (PST) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43569926ffcsm23594664f8f.18.2026.01.19.08.32.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 08:32:19 -0800 (PST) Message-ID: <641fad10-e693-43ae-a278-1bf70d56b6d3@linaro.org> Date: Mon, 19 Jan 2026 16:32:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] stm class: Fix Kconfig symbols To: Leo Yan Cc: Alexander Shishkin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , Greg Kroah-Hartman References: <20251217-fix_stm_kconfig-v1-1-531fb3674549@arm.com> <8d48dd55-d78d-4cbf-88b0-5427a731ba7d@linaro.org> <20260119154606.GE2732125@e132581.arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260119154606.GE2732125@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/01/2026 3:46 pm, Leo Yan wrote: > On Mon, Jan 19, 2026 at 12:35:23PM +0000, James Clark wrote: > > [...] > >>> @@ -28,7 +28,7 @@ config STM_PROTO_BASIC >>> config STM_PROTO_SYS_T >>> tristate "MIPI SyS-T STM framing protocol driver" >>> - default CONFIG_STM >>> + default STM >> >> The help below here says "If you don't know what this is, say N." which >> makes me wonder if this should be on by default or not? > > STM_PROTO_BASIC is a must have config when enabling STM. While > STM_PROTO_SYS_T is not mandatory, but it is useful to build it so that > users can select the protocol dynamically at runtime. > Should probably change that text to say "If you don't know what this is, say Y" then? Otherwise it makes the default-on look like a mistake. >> Also everything is in an "if STM" block, so "default STM" is a bit >> redundant. It's not that obvious what the intention was. > > They are two different things. > > "if STM" expresses a dependency (the module depends on STM), while > "default STM" means the module will be selected by default if STM is > enabled. > Yeah they're the same, it was just a minor nit that "if STM, depends on STM" seemed redundant (and obviously more error prone). "default y" would also be the same and not repeat the same thing twice. Don't think it matters too much either way. > Thanks, > Leo > > P.s. I also tried using the "select" and "imply" syntax to enable the > protocol configurations. Based on testing, I did not observe any > difference compared to using the "default" syntax.