From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755076AbdAFL2a (ORCPT ); Fri, 6 Jan 2017 06:28:30 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:51468 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdAFL1e (ORCPT ); Fri, 6 Jan 2017 06:27:34 -0500 From: Arnd Bergmann To: Raviteja Garimella Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, BCM Kernel Feedback , linux-usb@vger.kernel.org, John Youn Subject: Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver Date: Fri, 06 Jan 2017 12:20:39 +0100 Message-ID: <6422487.mhqDBHHcCr@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1483604597-26160-1-git-send-email-raviteja.garimella@broadcom.com> <1861880.7pouM4E6RB@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:mun1ZAY+YtAe8D/wjwhBvyobBjrwGpCz+1m56RPB/B/buuXL9Uz 0LXJueu6KemZwZqEWRhfPjIj5R8j5msfq4DqAQ5IsHeaXcDwaXr0LlwZSZ0vAmEZ6/IBTMA 5m1j8b4y4FyR/R1HTgkWQqIO/Zp4VQ2aIV14GZ9E7lUbF4Dqkg6g002F5xMkcMZgHvgQiVX wzySuPjlxP6Phx+M9AXbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:YHIxvxTWXSU=:BXaeZil9obqSRsWRIPwrrV 5M1aD61xTzZ5wscC0VDjVruxOOpPUHRYipQiPiX9LI5kWaCqw14z7A8sOmYWoHY9RuigcVEbT ETDIYGMxAlkDx2FAVbeabhJocrygUNYdwC+eTHyopV6bI1+SJDNZe98f1YZ7VsTEpiN3kIFg2 Qt2MLMOENzL46qE8SUqCd8Jma++c5vBDnTV+j52dqvjBz/d0gsXSkKuQVV8FJwfOfG2MZkvt3 ayO18MfYhZd9CipCNQLeTRUOo4spholiW8mN6QF1qf/TYnI+Nnc6k/2MVig29fV017yqiP/6s JzesHAZA6A7gGFofXQkwWxN9gmGvmpBcXU/2ULt5/A6gbmF+YaOKJ81sBmkLCqXd6BReil2aG akLB4T8JNQWUX5G6DNEY3y/Uyy1cl7kNm5xrVx7N/OqHdges+Yz3NOEm9WzdEy3rJtEGhs8/s CnghQFPD7F2szLrvoNUOxR7GXmdHXd06PM/cp/YH01j2GbPUNxkz021NhSOIYq/OWWj6BJni2 sdRAfnCwxBTZZckWOeKAH8LCUsFzISIXXSeJmBYpj/92Sig8Bz4Le00vDLgH6nP9T3ng7ZKGy 9aI1OCor0mo2+7BZbg5GTNwWfTsDHZRLpMzBuOlW8YH4DkckrUHc8bNW8wdtWK/k8YNvUDf1l RvseiIVywUdWGq0QHs3pCsFEvzeRyS0gFrAVdSJkwpjy0Aos8c85VaiqiD3/wJXHEjNQ334IY 7MpdlRseQeuiBqHG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote: > Hi Arnd, > > On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann wrote: > > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: > >> The UDC is based on Synopsys Designware core USB (2.0) Device controller > >> IP. > > ... > >> This is a request for comments from maintainers/others regarding approach > >> on whether to have 2 different drivers (one each for AMD and Broadcom) > >> with a common library (3 files in total), or have a single driver like > >> it's done in this patch and have the driver filename changed to some > >> common name based on ther underlying IP, like snps_udc.c. > > > > I have not looked at the code at all, so sorry for my ignorance, but > > isn't the IP block you describe the one that drivers/usb/dwc2/ is for? > > Could you add support for the Broadcom hardware there instead? > > The current driver I submitted is for a different Synopsys IP (USB > Device Controller IP, > not the HS OTG). It's confirmed by John Youn (from Synopsys) earlier. > Ok, sounds fine the. I'd suggest taking the current driver than and splitting out the pci_driver front-end into a separate module that calls exported symbols of the main driver, with the new platform driver in a third file that also calls the same exported symbols. Arnd