From: Paolo Bonzini <pbonzini@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Lendacky <thomas.lendacky@amd.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Kai Huang <kai.huang@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v4 6/6] KVM: x86: Refactor __kvm_emulate_hypercall() into a macro
Date: Tue, 10 Dec 2024 17:20:33 +0100 [thread overview]
Message-ID: <6423ec9d-46a2-43a3-ae9a-8e074337cd84@redhat.com> (raw)
In-Reply-To: <90577aad-552a-4cf8-a4a3-a4efcf997455@intel.com>
On 11/28/24 09:38, Adrian Hunter wrote:
>
> For TDX, there is an RFC relating to using descriptively
> named parameters instead of register names for tdh_vp_enter():
>
> https://lore.kernel.org/all/fa817f29-e3ba-4c54-8600-e28cf6ab1953@intel.com/
>
> Please do give some feedback on that approach. Note we
> need both KVM and x86 maintainer approval for SEAMCALL
> wrappers like tdh_vp_enter().
>
> As proposed, that ends up with putting the values back into
> vcpu->arch.regs[] for __kvm_emulate_hypercall() which is not
> pretty:
If needed we can revert this patch, it's not a big problem.
Paolo
next prev parent reply other threads:[~2024-12-10 16:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 0:43 [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX Sean Christopherson
2024-11-28 0:43 ` [PATCH v4 1/6] KVM: x86: Play nice with protected guests in complete_hypercall_exit() Sean Christopherson
2024-11-28 3:22 ` Xiaoyao Li
2024-11-29 9:01 ` Nikunj A. Dadhania
2024-12-02 18:54 ` Tom Lendacky
2024-12-03 7:29 ` Binbin Wu
2024-11-28 0:43 ` [PATCH v4 2/6] KVM: x86: Add a helper to check for user interception of KVM hypercalls Sean Christopherson
2024-12-02 18:57 ` Tom Lendacky
2024-11-28 0:43 ` [PATCH v4 3/6] KVM: x86: Move "emulate hypercall" function declarations to x86.h Sean Christopherson
2024-11-28 3:23 ` Xiaoyao Li
2024-12-02 20:05 ` Tom Lendacky
2024-12-03 7:33 ` Binbin Wu
2024-11-28 0:43 ` [PATCH v4 4/6] KVM: x86: Bump hypercall stat prior to fully completing hypercall Sean Christopherson
2024-11-28 3:24 ` Xiaoyao Li
2024-12-02 20:13 ` Tom Lendacky
2024-12-02 20:33 ` Tom Lendacky
2024-12-03 7:37 ` Binbin Wu
2024-11-28 0:43 ` [PATCH v4 5/6] KVM: x86: Always complete hypercall via function callback Sean Christopherson
2024-11-28 3:08 ` Xiaoyao Li
2024-12-02 18:44 ` Sean Christopherson
2024-12-02 20:57 ` Tom Lendacky
2024-12-02 20:59 ` Tom Lendacky
2024-12-03 0:14 ` Sean Christopherson
2024-11-28 0:43 ` [PATCH v4 6/6] KVM: x86: Refactor __kvm_emulate_hypercall() into a macro Sean Christopherson
2024-11-28 8:38 ` Adrian Hunter
2024-12-10 16:20 ` Paolo Bonzini [this message]
2024-12-10 20:03 ` Sean Christopherson
2024-12-12 7:32 ` Adrian Hunter
2024-12-12 15:42 ` Paolo Bonzini
2024-12-12 18:40 ` Sean Christopherson
2024-12-03 8:01 ` Binbin Wu
2024-12-10 16:17 ` Paolo Bonzini
2024-12-10 20:10 ` Sean Christopherson
2024-11-28 1:06 ` [PATCH v4 0/6] KVM: x86: Prep KVM hypercall handling for TDX Huang, Kai
2024-12-19 2:40 ` Sean Christopherson
2025-01-15 9:40 ` Binbin Wu
2025-01-17 19:31 ` Sean Christopherson
2025-01-20 0:37 ` Binbin Wu
2025-01-21 18:04 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6423ec9d-46a2-43a3-ae9a-8e074337cd84@redhat.com \
--to=pbonzini@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®