From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbbJMWYZ (ORCPT ); Tue, 13 Oct 2015 18:24:25 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:61797 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbbJMWYW (ORCPT ); Tue, 13 Oct 2015 18:24:22 -0400 From: Arnd Bergmann To: Jon Mason Cc: Michael Turquette , Stephen Boyd , Florian Fainelli , Hauke Mehrtens , Ray Jui , Scott Branden , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC Date: Wed, 14 Oct 2015 00:23:43 +0200 Message-ID: <6427519.eIBEvCNlle@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151013220450.GO12512@broadcom.com> References: <1444770485-11210-1-git-send-email-jonmason@broadcom.com> <5280890.6npshDUNFZ@wuerfel> <20151013220450.GO12512@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:iWQ8mmjaL/286foaqRG1wNH74BRKjbA2gu9SabRznWbMnRDCkF8 t2HM5noiBhNTBsvSZh7ssHIb0AI2s0sAOMHCV0wO6n/HqUrjSzQ14lpV0hMNmC+7f3r8zaD h6dlus1rw7Yj/YEQAwShE2Gn+pg0Ta6YiriaFCUx6lx/TRiJp9m6vDjsK8gzHq8tduoP+KE t1Cl+V2Q+fexaTewzqDug== X-UI-Out-Filterresults: notjunk:1;V01:K0:clj+wRMrtvU=:KE5nUKNUyc2RTayfLr+Vx4 40nBuxyCvf/ThidrdBzd1YTuFI8jIoK6PZp/KndmOaMRdHT9athRXCNPVJ0azzidOfFzbGyj8 S4Ols3af6AlswoFFCg5WtVQUd44MUtunFvFsw1hkmqd8hZoGGCvCFyT8+34VrMXimzguMXMQN oizOnEa8XTFEkjf8QQPeU59WZ9u1amV9HfVyaQgueS58JrIVZZN33xi/fc+hgQJyksgRv/z9N 9ji0XUjx7TYzE6ahyk7c674nCkul5NEg6DEnW+en9tKovBIa0imEPma0+9/rrRJZR97EDzMwx 5R+7g+XXzqQeHQIsU4nrTmT/r21S1qd9C8aqIPzrU9WaI1cEnXcBjeQ3IbrraWjIDo9vKTgOb 8Lh1SJQeU4Eie7UyMt8KW4u8L34a3YjhthaVQ2mR+HEWJnHfprk9vgsHoAUlY/3aUHcrBT+SI K6DhIWElNp4shjixivQ1GKl2JPJUBEdb9aQQs/vzzCdV/byD3Uq+eXHoDGFUdUANzIJLm8s3o uT/qsc9Ct9cT4NgqhcEJj71Qbt1x219PrR0FVTdjKm1ErjYQw6lOepWP3qv9dRrHjXq/xf7dn yHmMwIX+aTblK4JB0S00Z5Vgt+rDbW8C+Nzh0oL7tDSj9V48aJIasyerpsK0phCnNqbD1HCFE 7unfnQRYBwR5O8nm4FnuIG0ZUv8MxJzgbm0+WoAYL5bhT4XSEFBt0saDQaTAV+PRjskaPdoQc CLGu5hVouf2b/NEC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 13 October 2015 18:04:50 Jon Mason wrote: > > > On a related note, I'm seeing problems when CONFIG_CYGNUS is set but > > CONFIG_COMMON_CLK_IPROC is disabled, as that currently leads to a link > > failure. > > I can double check, but it should be on by default when Cygnus is > enabled. If you send me the error, I'll be happy to fix it. The problem is not that it's off by default but that it can be disabled, so it breaks some 'make randconfig' builds with this message: drivers/built-in.o: In function `cygnus_armpll_init': :(.init.text+0x1d290): undefined reference to `iproc_armpll_setup' drivers/built-in.o: In function `cygnus_genpll_clk_init': :(.init.text+0x1d2c4): undefined reference to `iproc_pll_clk_setup' drivers/built-in.o: In function `cygnus_lcpll0_clk_init': :(.init.text+0x1d304): undefined reference to `iproc_pll_clk_setup' drivers/built-in.o: In function `cygnus_mipipll_clk_init': :(.init.text+0x1d344): undefined reference to `iproc_pll_clk_setup' drivers/built-in.o: In function `cygnus_asiu_init': :(.init.text+0x1d370): undefined reference to `iproc_asiu_setup' My patch fixes it by always selecting COMMON_CLK_IPROC from ARCH_BCM_CYGNUS. I wasn't sure whether you want COMMON_CLK_IPROC to still be user-selectable, so I left that in place. Normally I'd expect it to be a silent option though, that just gets implicitly enabled whenever a platform that needs it is built into the kernel. Signed-off-by: Arnd Bergmann diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 1319c3c14327..35234e563cd8 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -29,6 +29,7 @@ config ARCH_BCM_IPROC config ARCH_BCM_CYGNUS bool "Broadcom Cygnus Support" if ARCH_MULTI_V7 select ARCH_BCM_IPROC + select COMMON_CLK_IPROC help Enable support for the Cygnus family, which includes the following variants: