From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbdKJBCu (ORCPT ); Thu, 9 Nov 2017 20:02:50 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59390 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755317AbdKJBCt (ORCPT ); Thu, 9 Nov 2017 20:02:49 -0500 Subject: Re: [PATCH] powerpc/powernv: Fix IMC_MAX_PMU macro To: Michael Ellerman , Anju T Sudhakar Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <1510229426-5547-1-git-send-email-anju@linux.vnet.ibm.com> <877euzp3mo.fsf@concordia.ellerman.id.au> From: Madhavan Srinivasan Date: Fri, 10 Nov 2017 06:32:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <877euzp3mo.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17111001-0040-0000-0000-0000040CA16A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111001-0041-0000-0000-000020AF4828 Message-Id: <6429f614-ab35-3c7f-6bfd-1f9f59545bbb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-09_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711100012 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 10 November 2017 02:32 AM, Michael Ellerman wrote: > Anju T Sudhakar writes: > >> IMC_MAX_PMU is used for static storage (per_nest_pmu_arr) which holds >> nest pmu information. Current value for the macro is 32 based on >> the initial number of nest pmu units supported by the nest microcode. >> Currently 29 nest units are enabled based on the system configuration. >> But going forward, microcode could support more nest units (max of 64 >> nest units). Hence fix the value for the macro. > There should be no reason to have a hard coded limit. > > We should just fix the code to dynamically size the array based on > what's found in the device tree. Yes. My bad. Device tree handling part is done in the platform/powernv side and this data (total number of nest pmus) can be extended from there. Will work on it. Thanks for review comments. Maddy > > cheers > >> Fixes:8f95faaac56c1 ('powerpc/powernv: Detect and create IMC device') >> Signed-off-by: Anju T Sudhakar >> --- >> arch/powerpc/include/asm/imc-pmu.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/include/asm/imc-pmu.h b/arch/powerpc/include/asm/imc-pmu.h >> index 7f74c28..f9f0f2e 100644 >> --- a/arch/powerpc/include/asm/imc-pmu.h >> +++ b/arch/powerpc/include/asm/imc-pmu.h >> @@ -23,7 +23,7 @@ >> /* >> * For static allocation of some of the structures. >> */ >> -#define IMC_MAX_PMUS 32 >> +#define IMC_MAX_PMUS 64 >> >> /* >> * Compatibility macros for IMC devices >> -- >> 2.7.4