From: Xin Li <xin@zytor.com>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
will@kernel.org, peterz@infradead.org, akpm@linux-foundation.org,
acme@kernel.org, namhyung@kernel.org
Subject: Re: [PATCH v1 0/3] x86/cpufeatures: Automatically generate required and disabled feature masks
Date: Mon, 18 Mar 2024 10:01:19 -0700 [thread overview]
Message-ID: <642a5625-126d-40f8-b4fc-df88172f1127@zytor.com> (raw)
In-Reply-To: <20240201054629.3816748-1-xin@zytor.com>
On 1/31/2024 9:46 PM, Xin Li (Intel) wrote:
> When a CPU feature is not configured, e.g., CONFIG_X86_FRED=n, in a
> build config, its feature disable flag, e.g. DISABLE_FRED, needs to
> be defined and added to a specific disabled CPU features mask in
> <asm/disabled-features.h>, as the following commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/fred&id=e554a8ca49d6d6d782f546ae4d7f036946e7dd87
>
> This patch set adds an awk script to automatically generate a header
> with required and disabled CPU features masks based on build config.
A gentle ping.
This is an infrastructural improvement which has a lower priority,
however it would be nice to get some feedback first.
Thanks!
Xin
>
>
> H. Peter Anvin (Intel) (2):
> x86/cpufeatures: Add {required,disabled} feature configs
> x86/cpufeatures: Generate a feature mask header based on build config
>
> Xin Li (Intel) (1):
> x86/cpufeatures: Remove {disabled,required}-features.h
>
> arch/x86/Kconfig | 4 +-
> arch/x86/Kconfig.cpu | 16 +-
> arch/x86/Kconfig.cpufeatures | 149 +++++++++++++++++
> arch/x86/Makefile | 17 +-
> arch/x86/boot/cpucheck.c | 3 +-
> arch/x86/boot/cpuflags.c | 1 -
> arch/x86/boot/mkcpustr.c | 3 +-
> arch/x86/include/asm/Kbuild | 1 +
> arch/x86/include/asm/asm-prototypes.h | 2 +-
> arch/x86/include/asm/atomic64_32.h | 2 +-
> arch/x86/include/asm/bitops.h | 4 +-
> arch/x86/include/asm/cmpxchg_32.h | 4 +-
> arch/x86/include/asm/cpufeature.h | 1 +
> arch/x86/include/asm/cpufeatures.h | 8 -
> arch/x86/include/asm/disabled-features.h | 154 ------------------
> arch/x86/include/asm/required-features.h | 104 ------------
> arch/x86/kernel/verify_cpu.S | 1 +
> arch/x86/lib/Makefile | 2 +-
> arch/x86/lib/cmpxchg8b_emu.S | 2 +-
> arch/x86/tools/featuremasks.awk | 108 ++++++++++++
> lib/atomic64_test.c | 2 +-
> tools/arch/x86/include/asm/cpufeatures.h | 8 -
> .../arch/x86/include/asm/disabled-features.h | 154 ------------------
> .../arch/x86/include/asm/required-features.h | 104 ------------
> tools/perf/check-headers.sh | 2 -
> 25 files changed, 303 insertions(+), 553 deletions(-)
> create mode 100644 arch/x86/Kconfig.cpufeatures
> delete mode 100644 arch/x86/include/asm/disabled-features.h
> delete mode 100644 arch/x86/include/asm/required-features.h
> create mode 100755 arch/x86/tools/featuremasks.awk
> delete mode 100644 tools/arch/x86/include/asm/disabled-features.h
> delete mode 100644 tools/arch/x86/include/asm/required-features.h
>
>
> base-commit: 078b7b997b47c7166c1240cf1d39db9f646a56be
--
Thanks!
Xin
next prev parent reply other threads:[~2024-03-18 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 5:46 Xin Li (Intel)
2024-02-01 5:46 ` [PATCH v1 1/3] x86/cpufeatures: Add {required,disabled} feature configs Xin Li (Intel)
2024-02-01 5:46 ` [PATCH v1 2/3] x86/cpufeatures: Generate a feature mask header based on build config Xin Li (Intel)
2024-02-01 5:46 ` [PATCH v1 3/3] x86/cpufeatures: Remove {disabled,required}-features.h Xin Li (Intel)
2024-03-18 17:01 ` Xin Li [this message]
2024-03-18 17:08 ` [PATCH v1 0/3] x86/cpufeatures: Automatically generate required and disabled feature masks H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642a5625-126d-40f8-b4fc-df88172f1127@zytor.com \
--to=xin@zytor.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®