From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750974AbdIRTee (ORCPT ); Mon, 18 Sep 2017 15:34:34 -0400 Received: from mout.gmx.net ([212.227.17.21]:60444 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdIRTed (ORCPT ); Mon, 18 Sep 2017 15:34:33 -0400 Subject: Re: [PATCH v4 1/2] wire: export w1_touch_bit To: GregKH Cc: LKML , Evgeniy Polyakov , Linux-I2C References: <20170918130346.3886-1-jjj@gmx.de> <20170918141929.GA10178@kroah.com> From: Jan Kandziora Message-ID: <642d1ff1-57ff-71ee-a516-c6028dd1d1c2@gmx.de> Date: Mon, 18 Sep 2017 21:34:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170918141929.GA10178@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qLff7ZSTvq6eVjhiZ1LQTUF7loq3fngZ23b5U9tBprRRanY7CV9 UrQ97HGBIq7XSKOzItG9zA6l5zGY5r8aWFVmnOYyI+krLMUzs1lR1nRaMzjMbAG7sW4KEM3 U2zZP4J9bSLyu19CjkRWn8SEuGUP9/41rTNaELqdkwdgbqPs2ucl1FNz0wIQAk9KwKJx25y jAhMvJGZi69hD59sfFFdg== X-UI-Out-Filterresults: notjunk:1;V01:K0:rbvBbexLuzo=:XiR2NWounBvcgxfpFP8EQZ aHKlkEhnc92B2oLXrMifIYy2qFv/bbwwnV2cD4HtupY+A/j7khCKEN//xZXHm6JEC3EvxNdES eJFJz8bPVkhIT5dvzAjyHMVPmBOdb11netulruA0ubbnNF4dfCLG57uPheVJylltDeRvcbItA lKL3/bojjRf13I1lFKKcK8MeioCAQuvcxJ/OwkJL5wENuU2pEc1VTbKHp1zhdvwniVs1MWFrH 2BH6BInD2tgLUzZBUwbTSr2ybUf96Oqs+2x4VrqhDkY5W5uF9xC5wGhNxrNzlXZSLUOLxywe0 8Qi9TVpj4lVnV33QpD4rzJkEONRhauuHW7IMlhH8visTNjh/zawBrmXabk1VmHYoj/yj0Mk2g 11oQ96HRtWJpLUpnnZNiFJZCer+lJU03TfYEmT4JLB+kq2SU4HGbpVrFfs0eakNqjKwffcLlB 7v9urUw4+QcyiJoX/Am7/QDMvAJqjkZOfZNsFhAronb7IeIqR0ZZckdUqBnvHawICTTm7zCR6 0gri6WN+C9tKErvKlNPCojIqQA2nO0kaQhFqtHDRuJ7mSPaQQkRwjL69biYsaYMXtdjuLlJAf h/P3jOriW0uGtrM68EEhcw7I2qzBu8sc0NKYffrnjInSpuSXUQ1aoWQrmJx8CIiNetsJh+2nw +7ZHltoWpyvTGI7h5gv/bRjRX4EW+yYnH7P0+CxDF25sKoa1MybBSPBzjiPMLWOp35dxsmRxH oXJiXAq+dhuIQiHV8A5YYw8nU2LYG3MomVT1H4DeQ+Pg/S1eMqe6h1I9s9dFIZq45eqMZdSin rsBMpQvdECfkXG/+Ts3ZSYHNnguU0DLYBXHfE8kadrujL9IwZw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 18.09.2017 um 16:19 schrieb GregKH: > On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote: >> The w1_ds28e17 driver from the next part of this patch needs to emit >> single-bit read timeslots to the DS28E17. The w1 subsystem already >> has this function but it is not exported outside drivers/w1/w1_io.c >> >> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL, >> same as the other exported symbols in drivers/w1/w1_io.c >> >> May be also useful later for writing drivers for other Onewire chips >> which do single-bit communication. >> >> Signed-off-by: Jan Kandziora >> Acked-by: Evgeniy Polyakov >> --- >> Changes in v4 against v3 in this subpatch: >> - adapted to linux-4.12.0 >> >> No changes in v3 against v2,v1 in this subpatch. > > You should change it as it does not apply to 4.14-rc1 :( > Okay, I will review them again. > Please rebase your patches and resend them, with Evgeniy's acks added to > them. > Now you caught me. I don't know how to do that. What's required? The Acked-by: line? Am I allowed to simply add these lines to my patches or is there a procedure to follow? Kind regards Jan