From: TGSP <tgsp002@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: xiongxin@kylinos.cn, rafael@kernel.org, len.brown@intel.com,
pavel@ucw.cz, huanglei@kylinos.cn, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PM: hibernate: fix spelling mistake for annotation
Date: Fri, 4 Nov 2022 17:47:07 +0800 [thread overview]
Message-ID: <6436e363-198f-3d0b-cef3-4456de225432@gmail.com> (raw)
In-Reply-To: <Y2TY120EAhfKgSvR@kroah.com>
在 2022/11/4 17:18, Greg KH 写道:
> On Fri, Nov 04, 2022 at 01:41:18PM +0800, TGSP wrote:
>> From: xiongxin <xiongxin@kylinos.cn>
>>
>> The actual calculation formula in the code below is:
>>
>> max_size = (count - (size + PAGES_FOR_IO)) / 2
>> - 2 * DIV_ROUND_UP(reserved_size, PAGE_SIZE);
>>
>> But function comments are written differently, the comment is wrong?
>>
>> By the way, what exactly do the "/ 2" and "2 *" mean?
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: xiongxin <xiongxin@kylinos.cn>
>
> Please do not use an anonymous gmail account for your corporate work
> like this. Work with your company email admins to allow you to send
> patches from that address so that they can be verified to actually come
> from there.
>
> thanks,
>
> greg k-h
I also wanted to send it directly through the company mailbox, but those
leaders didn't take it seriously.
Next time I don't use the company email and submit patches as I can as a
freelancer.
next prev parent reply other threads:[~2022-11-04 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 5:41 [PATCH v2 0/2] Fixes to the hibernate_preallocate_memory() TGSP
2022-11-04 5:41 ` [PATCH v2 1/2] PM: hibernate: fix spelling mistake for annotation TGSP
2022-11-04 9:18 ` Greg KH
2022-11-04 9:47 ` TGSP [this message]
2022-11-04 5:41 ` [PATCH v2 2/2] PM: hibernate: add check of preallocate mem for image size pages TGSP
2022-11-04 6:25 ` Jiri Slaby
2022-11-04 7:27 ` TGSP
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6436e363-198f-3d0b-cef3-4456de225432@gmail.com \
--to=tgsp002@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=huanglei@kylinos.cn \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®