From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE012FE56A for ; Sun, 12 Jul 2026 06:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783838678; cv=none; b=TyU6ENwQbd6EjZp/2iVS9+nD+K5q/XxBdOaY4tLDFsCtpR87CH1oCeV4tMTvQ1v2PaGNJxw9lgbmJgdjpMHK/fVZ2EeC+M8Omo9kdXXpnmATf06CFLsK2kt/trHamdhW2jdW7Rhsj57djqC0P7sTpclUPudoUqM8Xj3TX+H0XuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783838678; c=relaxed/simple; bh=K+KhjlKpEQaSBSeWKaWZOuXn7jb+3z6ScwiGkkbU8/E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TQKPpirfrFsnFw8VmHW9u1UGxlX3WdL1izee3+jYnwddAB238rRGZqJkLEtb8yejHEt1jprsCd1dLu9ahOpu7UayUkAF+xn5AfJaulDL46mupboZojd+HdKc/qYpoOk5FFGFFKvNuZLttgLvSrY9R3CEBSsVsTNeDhqO+pIP5P4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kX6VRgrb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JMqfN979; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kX6VRgrb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JMqfN979" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66C3wvaZ1586507 for ; Sun, 12 Jul 2026 06:44:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8MFG9unhRrvg7GeuVPVdKkz/kvu28Nz5klqNArkBW8o=; b=kX6VRgrbnvyE/nP2 Ym2FoYZa5ksphGrGd8OnsONEmCUl8IQJACEwkBRDQbYYoye8OdSu86PcrQhy5mj2 MhWL6klBCMIUwrfFaqidVoP5yqba3SFa/XHY2S+P0K0+Zh2T6fasnvhJcnw+SFaJ UkenkM9BQEcGj/4S95BIZ0xXdLNsMmGBhRJvxMIGRldKYZnfHCQZna7vmY7RjJ6X 01vKAuRQ3oDYDS6d+SkTPdBgmOIFT2BARqZfnYBJV9tX/IO0/5jUTP45XzvIN29n mLho94y21EzhWRrX+Ek58w52dytAKjk+dRy2hFQOk3GDdMhbLaeZMb0x3ZKovEdE gQbj1Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbe9hjc4p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 12 Jul 2026 06:44:33 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cc8bde6318so40618985ad.3 for ; Sat, 11 Jul 2026 23:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783838672; x=1784443472; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8MFG9unhRrvg7GeuVPVdKkz/kvu28Nz5klqNArkBW8o=; b=JMqfN979jXoUnaNbQLTMs+YPPLY1+i8hUN43kv6sic2TFskyK2KqFW4+JCsurhzce7 53aX+iBXU/CZHRWaVFHY6Nx5t/AFrmxtO4y0VrOd5t1QqHcmFADjve33vVH+GMjVlc2J 1vo2QPdxpiio2r4zrmojvmJ7Vh/Gwu5jSkwmWobPVsCuPYDmmKlpL/hB6SDFKsJyH2fR DZKkWXO5lEL895RyadcaePvRdwigxn0TH6WHr+4nmIjlpp1t6SfQj+8fgorqQFK1Wphg Nxu1qWC+3CVf0lU9HC0dDem40CMCjAvD3tzBBtqKbJclpfhSzJ1VwmW3JvtJlwMZnvYG bu2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783838672; x=1784443472; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8MFG9unhRrvg7GeuVPVdKkz/kvu28Nz5klqNArkBW8o=; b=TZErzjkB1P+At2daeoVx7+y/8EyRAq9PG41swE6LMcbNx1b8GE85UxDUWKiZslDJyK SUOa7kgcPvp4q4jG3WhPoepvOZ1L9j2YBZ8FZ1EmLwGHNZgDPwHhtnM76YtI+eRGUjwh HdPm+6uBHeuSuXDng+wqnbEaJeFI3Jbow6xJNCqJ8e5qEdDUBrXRI8QvcmPB1T/xTI/J jDCCgnXPu1PrXujXcaeFd8oyDzBzRhsqL2Gb6lovfsiOzx7WCKSHmofi8VWLwolUg6nS AOjgWnm8cjnRRyRn0HnMsgQ7/CxRytaT7fw8yzF3JruNSRxHNUUI6iwnlAsiOYbF7lIK DEFQ== X-Forwarded-Encrypted: i=1; AHgh+RooX6ZtxWxThVQ9RGSTa4Ake9+Ah4TaJvvh8X/GL2DzYWOQL9gKZCOlfOYYNTsBir0+NEN6xIvosNH+BM4=@vger.kernel.org X-Gm-Message-State: AOJu0Yws0ubfGWu6K3WWFyaNJPvxLQEM0jR6Qb2UC34jf2NRy3qKm2Tj nrt0vXdQPCbwFuVgvgUQWE/9tANlT2So7LNSNiNF6KUUF/JJSi3LTiUiMJ+QZS4O2mZQjaVxF7w T9rrRnTPQyM19rnKw3wl99l6hbcAEztzGIuYkPE60u+3qp7BBQLiLPIRtBotOGCvp+zw= X-Gm-Gg: AfdE7cn/xrw4NSAXtZDLnRAbXZULPsbQf/A9wzmTEL4aQ1DHKMax5ZJOrqS5PNojrwo 0EuWCZ+wed5uL0GDZszpr0iCIOxxWNf6fQbrNsqE9QI6dMsQHmYbjNG2Ts1k6gWSIKnxGepbBFc vE6nf3gGNdzTHfBzyzBbpGoTmMam+Q3EC6tgk8Mu7heKzkjIfuFaAddtwY13EbtWQbWIGt3srRY lTod0zxRzEhruFZnVa5d23wvYKhwx0P9dBbEdnDTW9jnVXbBdpgPKMYXVDm9B9RL4q2Z4+Dcu7Y coWFh40nxCCkyPX+j20VPpEu59aEb/Q1+X+683pv7F3cHXW1CckNMPj7tGL2zvhQAQNVVonzF0d UiM9E9hiBN70SalxxbMhRcF8N2IR+Bi6D5VO+8svCK3yW1loYlw== X-Received: by 2002:a17:90b:53c6:b0:381:fa5:521f with SMTP id 98e67ed59e1d1-38dc74b9530mr4799488a91.3.1783838672271; Sat, 11 Jul 2026 23:44:32 -0700 (PDT) X-Received: by 2002:a17:90b:53c6:b0:381:fa5:521f with SMTP id 98e67ed59e1d1-38dc74b9530mr4799475a91.3.1783838671780; Sat, 11 Jul 2026 23:44:31 -0700 (PDT) Received: from [192.168.1.5] ([122.164.92.133]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311a6115e61sm38644234eec.22.2026.07.11.23.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 23:44:30 -0700 (PDT) Message-ID: <6438237f-ccb4-4143-9ac7-43f5dcca955b@oss.qualcomm.com> Date: Sun, 12 Jul 2026 12:14:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , Krzysztof Kozlowski , Neil Armstrong References: <20260711125740.3083236-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260711125740.3083236-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260711-mauve-skunk-of-contentment-f51be0@quoll> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20260711-mauve-skunk-of-contentment-f51be0@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: bGJYMfAZGaIosM__T89H6z9hNc3iH501 X-Authority-Analysis: v=2.4 cv=SajHsPRu c=1 sm=1 tr=0 ts=6a5337d1 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=tlK9sNgGSfv7srgBb5RqhA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=LJDSKmyOq5XDa4FDNxEA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: bGJYMfAZGaIosM__T89H6z9hNc3iH501 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEyMDA2NyBTYWx0ZWRfXxRRlqWePSiQd ZM2ki+NWja/t7hbH1Fv/3Rm64oeD4WXq0xhKvn0xcegAGUJ5oSOegHPX1xoNU1AnwKKhd635Tj3 /N/x+xQrF7oNzXOTz7xa/S9Ms+THcERvv1euiYvaDgTeHNnpiL8d8GmALupTcxO8AB/teM2/v30 BeetZs74ugMnI8L3iC50rLhUB86pRLQOlbRXdFPsnLr+LHLuM1wZzWFcigClgMT0AVDa+Z3jqIJ ux/UO+tIL/uNHw4blZ2CqS5fDFFkK590Sep2NVHXBjNCnh41nVZq9dH4/JvG/FLQgnKuqOqxg89 DFzTemjlqInrSxxg6wxFuOTEYYkNTm/8APSQoSFi0Bn4DgrFat8lndoHArXDBCkYF+R62Uv1skb oY1v5jqo2QKiBeF8VdYvwpLX6/1fSMGvtIsXQP/G1jJE46VfRXDazB8YrmoJS+zXFjfAfUuCeqZ 8urkedL3/bQtLtqlgqg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEyMDA2NyBTYWx0ZWRfX7I7dHSow2k90 /WIWzVoq7DdYqbAE5OqizcoXOG1ubr8tEaLrlnucfK3/V7nodJppd8VcrrGpeQkXpM10a6Pj4Rn p89Yo1U0VioyKLA5cRlmDMycVrgRJsE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-12_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607120067 On 7/11/2026 8:41 PM, Krzysztof Kozlowski wrote: > On Sat, Jul 11, 2026 at 06:27:38PM +0530, Mohammad Rafi Shaik wrote: >> Extend the qcom,q6apm-lpass-dais device tree binding to explicitly >> describe Digital Audio Interface (DAI) child nodes. >> >> Add #address-cells and #size-cells to allow representation of multiple >> DAI instances as child nodes, and define a dai@ pattern to document >> per-DAI properties such as the interface ID and associated clocks. >> >> On platforms such as Monaco and Lemans, third-party codecs are hardware >> wired to the SoC and do not always have an in-tree codec driver to manage >> their clocks. For these designs, clock line enablement must be driven >> from the platform side, and this series provides the necessary support >> for that. >> >> On QAIF-based platforms such as Shikra and Hawi, responsibility for voting >> I2S MCLK and BCLK has moved from the DSP to the kernel. This series >> introduces the required device tree binding support to represent and >> vote for these clocks from the kernel. >> >> Co-developed-by: Srinivas Kandagatla >> Signed-off-by: Srinivas Kandagatla >> Reviewed-by: Krzysztof Kozlowski > > Drop my tag, you made a important change to ABI. > Ack >> Tested-by: Neil Armstrong > > Drop, you cannot test a binding (in the meaning of Tested-by tag). Ack, will drop Tested-by tag. > >> Signed-off-by: Mohammad Rafi Shaik >> --- >> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 58 +++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >> index 2fb95544db8b..f3a8b12d7fc8 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >> @@ -21,6 +21,49 @@ properties: >> '#sound-dai-cells': >> const: 1 >> >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> +# Digital Audio Interfaces >> +patternProperties: >> + '^dai@[0-9a-f]+$': >> + type: object >> + description: >> + Q6DSP Digital Audio Interfaces. >> + >> + properties: >> + reg: >> + maxItems: 1 >> + description: >> + Digital Audio Interface ID >> + >> + clocks: >> + minItems: 1 >> + items: >> + - description: MI2S master clock >> + - description: MI2S bit clock >> + - description: MI2S external bit clock >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 3 >> + items: >> + enum: > > That wasn't here and that's also not correct, usually. Especially that > it does not fit your clocks property. > The reason for changing this to enum was that some hardware may expose only a single clock, which can be bclk or eclk instead of mclk. With the previous positional const definition, such configurations fail schema validation because the first entry is always expected to be mclk. I agree that using enum makes the validation less strict and does not ensure the correct clocks and clock-names mapping. I'll check this and look for a better solution. Thanks & Regards, Rafi. > Best regards, > Krzysztof >