mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Chew <AChew@nvidia.com>
To: "'Erik Gilling'" <konkers@android.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ccross@android.com" <ccross@android.com>,
	"olof@lixom.net" <olof@lixom.net>
Subject: RE: [PATCH 1/1] [tegra] Make syncpt routines accessible by drivers
Date: Mon, 14 Feb 2011 16:08:36 -0800	[thread overview]
Message-ID: <643E69AA4436674C8F39DCC2C05F763816BD96CFB1@HQMAIL03.nvidia.com> (raw)
In-Reply-To: <AANLkTinvpo=R1pjvykEZVXV08D+uXLJa=R8CDcMFWWpT@mail.gmail.com>

> If you want to use syncpts you should be an nvhost_driver link the dc.

Looking at drivers/video/tegra/dc, I notice that it gets access to the syncpt functions by using a relative path (../host/dev.h) to include dev.h, which in turn includes nvhost_syncpt.h (in drivers/video/tegra/host).  Is this proper form?

This syncpt access is for a Tegra V4L2 driver, which will live in drivers/media/video.  I was trying to avoid using relative paths for #includes.  I assumed that the header files in drivers/video/tegra/host were not meant to be publicly available to other drivers, which is why I looked for some precedent in how nvhost functions were made available to other kernel drivers, hence I modeled this after nvmap.

  reply	other threads:[~2011-02-15  0:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 23:27 achew
2011-02-14 23:40 ` Erik Gilling
2011-02-15  0:08   ` Andrew Chew [this message]
2011-02-15  0:22     ` Erik Gilling
2011-02-15  0:47       ` Andrew Chew
2011-02-15  1:49         ` Erik Gilling
2011-02-15  1:52           ` Andrew Chew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=643E69AA4436674C8F39DCC2C05F763816BD96CFB1@HQMAIL03.nvidia.com \
    --to=achew@nvidia.com \
    --cc=ccross@android.com \
    --cc=konkers@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®