From: Andrew Chew <AChew@nvidia.com>
To: Stephen Warren <swarren@nvidia.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"olof@lixom.net" <olof@lixom.net>,
Dan Willemsen <dwillemsen@nvidia.com>,
Rhyland Klein <rklein@nvidia.com>,
Venkat Moganty <vmoganty@nvidia.com>
Cc: "devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.
Date: Tue, 19 Jul 2011 16:50:53 -0700 [thread overview]
Message-ID: <643E69AA4436674C8F39DCC2C05F76383CF0DD2271@HQMAIL03.nvidia.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049EBDED2A@HQMAIL01.nvidia.com>
> Although that said, since many of the USB properties are
> board-specific
> and determined by system characterization, they aren't generally
> applicable to all Tegra devices. As such, should those values be moved
> into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify
> the default values that the driver currently uses if not supplied with
> platform data though... I think the Seaboard values are the defaults,
> which still would make this patch obsolete.
Turns out the ones I put in tegra20.dtsi are NOT the defaults. The defaults are in arch/arm/mach-tegra/usb_phy.c, contained in "utmip_defaults[]".
I think I'm going to put those utmip_defaults[] stuff into tegra20.dtsi, and override them in tegra-seaboard.dts. How's that sound?
And since there are defaults specified in tegra20.dtsi, does it really make sense to also have default values assigned in ehci-tegra.c (for when a property is not present)? I worry that the information is now duplicated. If those properties aren't present, then someone's mucked with the tegra20.dtsi ehci properties.
next prev parent reply other threads:[~2011-07-19 23:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 22:46 [PATCH 1/3] usb: tegra20-ehci: Add devicetree support achew
2011-07-19 22:46 ` [PATCH 2/3] dt: tegra20: Add ehci host controller nodes achew
2011-07-19 23:00 ` Stephen Warren
2011-07-19 23:15 ` Stephen Warren
2011-07-19 23:58 ` Olof Johansson
2011-07-19 22:46 ` [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard achew
2011-07-19 23:04 ` Stephen Warren
2011-07-19 23:50 ` Andrew Chew [this message]
2011-07-19 23:53 ` Olof Johansson
2011-07-20 0:07 ` Andrew Chew
2011-07-20 0:14 ` Olof Johansson
2011-07-19 22:56 ` [PATCH 1/3] usb: tegra20-ehci: Add devicetree support Stephen Warren
2011-07-19 22:59 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643E69AA4436674C8F39DCC2C05F76383CF0DD2271@HQMAIL03.nvidia.com \
--to=achew@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwillemsen@nvidia.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
--cc=swarren@nvidia.com \
--cc=vmoganty@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®