From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbaBGBsN (ORCPT ); Thu, 6 Feb 2014 20:48:13 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:19786 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbaBGBsK convert rfc822-to-8bit (ORCPT ); Thu, 6 Feb 2014 20:48:10 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 06 Feb 2014 17:46:36 -0800 From: Andrew Chew To: Guenter Roeck , "wim@iguana.be" , "rob@landley.net" , "swarren@wwwdotorg.org" , "thierry.reding@gmail.com" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , "abrestic@chromium.org" , "dgreid@chromium.org" , "katierh@chromium.org" CC: "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-doc@vger.kernel.org" Date: Thu, 6 Feb 2014 17:48:08 -0800 Subject: RE: [PATCH v4 1/1] watchdog: Add tegra watchdog Thread-Topic: [PATCH v4 1/1] watchdog: Add tegra watchdog Thread-Index: Ac8jpRvSYi9l1s0hR1KllbOgM/Ot+QAAXVQQ Message-ID: <643E69AA4436674C8F39DCC2C05F76386319985EC6@HQMAIL03.nvidia.com> References: <1391724356-17034-1-git-send-email-achew@nvidia.com> <52F438A9.9000908@roeck-us.net> In-Reply-To: <52F438A9.9000908@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 02/06/2014 02:05 PM, Andrew Chew wrote: > > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 > > and later). This driver will configure one watchdog timer that will > > reset the system in the case of a watchdog timeout. > > > > This driver binds to the nvidia,tegra30-timer device node and gets its > > register base from there. > > > > Signed-off-by: Andrew Chew > > --- > > Hi Andrew, > > > + > > + /* This is the timer base. */ > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) { > > + dev_err(&pdev->dev, "incorrect resources\n"); > > + return -ENODEV; > > + } > > + > > I thought I mentioned that before - dem_iomap_resource() creates the very > same error message and returns an error if NULL is passed as res argument > to it. So the above error message (and error check) is really redundant. Sorry about that. I guess I misunderstood. I'll send a new one out shortly.