From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754505AbcFQHEx (ORCPT ); Fri, 17 Jun 2016 03:04:53 -0400 Received: from mga14.intel.com ([192.55.52.115]:2427 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbcFQHEw (ORCPT ); Fri, 17 Jun 2016 03:04:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,482,1459839600"; d="scan'208";a="829849058" Subject: Re: [RFC] regmap: Add regmap_pipe_read API To: Geert Uytterhoeven References: <7ca3857aa8869a1e1f4709860f57f7d92abf1c6b.1466089603.git.leonard.crestez@intel.com> Cc: Mark Brown , linux-spi , Wolfram Sang , Linux I2C , Jonathan Cameron , "linux-kernel@vger.kernel.org" From: Crestez Dan Leonard Message-ID: <643b0e6a-49a0-00bb-7aed-6d36c1e0bb6b@intel.com> Date: Fri, 17 Jun 2016 10:04:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote: > Hi Leonard, > > On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard > wrote: >> The regmap API usually assumes that bulk read operations will read a >> range of registers but some I2C/SPI devices have certain registers for >> which a such a read operation will return data from an internal FIFO >> instead. Add an explicit API to support bulk read with pipe rather than >> range semantics. > > Please settle on either "fifo" or "pipe", instead of mixing both. > Personally, I prefer the former. Well, it doesn't have to be a fifo. The device can return data from some other kind of buffer (maybe a stack). I can adjust the documentation to clarify. I considered naming it something like regmap_multi_read_one_reg or something but regmap_pipe_read sounds reasonable and short.