From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbcGAGna (ORCPT ); Fri, 1 Jul 2016 02:43:30 -0400 Received: from megous.com ([83.167.254.221]:49215 "EHLO xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbcGAGn1 (ORCPT ); Fri, 1 Jul 2016 02:43:27 -0400 Subject: Re: [PATCH v2 06/14] ARM: sun8i: clk: Add clk-factor rate application method To: Jean-Francois Moine References: <20160625034511.7966-1-megous@megous.com> <20160625034511.7966-7-megous@megous.com> <20160630204001.GC5485@lukather> <0b71ed7e-98c9-109e-85e6-ceb95131d88a@megous.com> <20160701073710.1a1fc684ae448577bad5b0db@free.fr> Cc: Maxime Ripard , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , dev@linux-sunxi.org, Michael Turquette , Stephen Boyd , open list , =?UTF-8?Q?Emilio_L=c3=b3pez?= , Chen-Yu Tsai , Rob Herring , "open list:COMMON CLK FRAMEWORK" , linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= Message-ID: <643c2648-ddd6-700a-68c0-2981134965c0@megous.com> Date: Fri, 1 Jul 2016 08:34:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160701073710.1a1fc684ae448577bad5b0db@free.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4bNxUTEGVlOMTDjw9LHONh3RHCn8pVmUf" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4bNxUTEGVlOMTDjw9LHONh3RHCn8pVmUf Content-Type: multipart/mixed; boundary="IIcQAmqR07FEsnkmRxpRKgmD9isjhWU8p" From: =?UTF-8?Q?Ond=c5=99ej_Jirman?= To: Jean-Francois Moine Cc: Maxime Ripard , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , dev@linux-sunxi.org, Michael Turquette , Stephen Boyd , open list , =?UTF-8?Q?Emilio_L=c3=b3pez?= , Chen-Yu Tsai , Rob Herring , "open list:COMMON CLK FRAMEWORK" , linux-arm-kernel@lists.infradead.org Message-ID: <643c2648-ddd6-700a-68c0-2981134965c0@megous.com> Subject: Re: [PATCH v2 06/14] ARM: sun8i: clk: Add clk-factor rate application method References: <20160625034511.7966-1-megous@megous.com> <20160625034511.7966-7-megous@megous.com> <20160630204001.GC5485@lukather> <0b71ed7e-98c9-109e-85e6-ceb95131d88a@megous.com> <20160701073710.1a1fc684ae448577bad5b0db@free.fr> In-Reply-To: <20160701073710.1a1fc684ae448577bad5b0db@free.fr> --IIcQAmqR07FEsnkmRxpRKgmD9isjhWU8p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1.7.2016 07:37, Jean-Francois Moine wrote: > On Fri, 1 Jul 2016 02:50:57 +0200 > Ond=C5=99ej Jirman wrote: >=20 >>> Since this is really specific, I guess you could simply make the >>> clk_ops for the nkmp clocks public, and just re-implement set_rate >>> using that logic. >> >> I would argue that this may be necessary for other PLL clocks too, if >> you can get out of bounds output frequency, by changing the dividers t= oo >> early or too late. So perhaps this code should be generalized for othe= r >> PLL clocks too, instead. >=20 > The documentation says that only the CPU and DDR PLLs can be dynamicall= y > changed after boot. The question is what exactly is meant by after boot. :) Anyway, if the kernel has no business changing some other PLLs, if there's code for changing them, should it be dropped? regards, Ondrej --IIcQAmqR07FEsnkmRxpRKgmD9isjhWU8p-- --4bNxUTEGVlOMTDjw9LHONh3RHCn8pVmUf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXdg7zAAoJEG5kJsZ3z+/xrngP/ip9+tVZKEa7Ih/J+LciNXkY H4shEKUJHnUd1vu/TmYyngXJ4S2kWTYcxyKHPTcEq70zmtsYQ+rxsZXuPZOY29El lm4LLaLFBueJ+yBwddZ12of5V8W67VuDVuHx21spu6/kso+46SqFQ83r0zK+owIA AXS1XAHY+F57mmTQT+7TLKH5DpM5UYQYrUXvsN0ecaMSN8m1qhP53AynhX9MNs5U oCDA/qp68HorfL/NHf0l2UAu8lWYqqQ7r0hgaoXCk9x6dql7rj1c1ctQEWJHplDZ YdI1ncojlHioy6m7k4/8jIDzQecTtJfn+c4vEwmaGqNeZnHEJUNG6eUTq6CL6zsG 2EzOQWzY06mZ25zwsQd6rzevLXIjlKzzRyEDTkp1BC8b07VxTt7AxtbL9WRvPVUC KAloFZ9kpOwGpxwQyivdBPnHt6In9HuZ1NVNnAYJEObisbQQmslATdg4N7efXaQm 3WV7yDbFa4O8PEyvqNBXEbZAZMQmYJ5kel7uCx6ak6/rm+AthpnjKuutb1b7HS6W eNqumOj3HKt2pUaLR5FgkBrkxuKvMswLheX3oS0sCeVv292NT9PeiAtCRQeWBYju wXiAnd+dJm+m6RfzDt38nLkttWhA2HWmzHefxLC6wzSsT7GomYGobPhpKoYfArnS AWNR7ioU18CcgQPHLDrR =1n/V -----END PGP SIGNATURE----- --4bNxUTEGVlOMTDjw9LHONh3RHCn8pVmUf--