From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC05371070 for ; Mon, 2 Feb 2026 14:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770044208; cv=fail; b=LwdFOte4qlUgC7AWPoo+7WP84vb3voxrN0SqK1A7AYAShMDWEZ/F0LDYPWuaCzs/13FuesKOfvpQqJijWFEtzrgTo0lMx8R5lvjVuOvAKfjqDCN2mpNnQrNFZ98PRloMxBCVCMCC1k5tKL6U8cwMPKbq3FaDzX+tM4gCuNL6dXg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770044208; c=relaxed/simple; bh=InhtWiFbn4gvr9coDVA6xCbh46AJPRJDFwbgivhuLRo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hFbusOHTrLrrlG0m97XrGdNMFBPNTc0p8fb64aglbsyoC0ZCebKbTYORo/57QAYYLGGXFQikolW8390OBa2i/qDk0uYOPxmNvf9RN8umak7k7o1CJry8zJuCONlm4DDJLZDpGLjiM93h/Ei7udGxLnc3ldZqqfZURp68FaSe+Zo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=bLTBoPTQ; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=k+FpNmuQ; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="bLTBoPTQ"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="k+FpNmuQ" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6124Y9al1487076; Mon, 2 Feb 2026 08:56:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=uiOYhf38DKIjBPK00j6goiqE9M1gZMMncsdo2EGoiGY=; b= bLTBoPTQ0tdccm1tExCgz+z8ocP/6lMd19fhB4Dl/KCsYS2qpjIAUKWjdlNnMXsn 6KMgzuLdGtlqFDRnZti7VgenBiaFINRQ4kPQql+ipHQ/OfrYxneOd4kmGDysN0vC OyjAns/pcH47qY/+/bk2/93uhSMwZTagR04juY7JNQVywqQvcTMAJ14FOHLppw5R 3zeTAchvZJiXBVhF8xZe/CEEugVJ7hbn+cK9sWwXaGWk6Hdgo/YgdxHvQmd/OGCY 3yxoC1idFJveliQSCDGjuncGMFM5ReWGkivNB6j5O44INrYItYejmrODiye01UjO Zz9UMttymM+S1f0Tk6oZ4A== Received: from ph7pr06cu001.outbound.protection.outlook.com (mail-westus3azon11020128.outbound.protection.outlook.com [52.101.201.128]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4c1g12susf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 02 Feb 2026 08:56:38 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kF7PxvQkj/d2k55iytYk/+HJIp/kQnpxtiwUHSTQ/smRSN3sVE8WApWJBPeIOVv5W89pRqWoR/xXhjv9Vkp4Vvqu/L/+ubyYhYWIbCvlNC48VSmX5GxtfROFGoCaTYwiw1WMZw+hoSSldcb58zR9fxtmhc7UJSImzz7ubesVKbJQ3CUqxqf/uBMvTGDCyuWZbzZgwkdTiLW5HCCyMS+iTqXcRN6b6e1II6oXrS4dHtIv2VkDbXn8hAQOsoCV6TKJH0B3cOAitJhCBScttOToyH0Wpa5Q5fJTwbdXBX6GfsVvEIxofzUf6N0kB4MZL5doTBld+950LYxYl+1Qw2NXwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uiOYhf38DKIjBPK00j6goiqE9M1gZMMncsdo2EGoiGY=; b=wGW/idzzvJRqhu95bCRrSuOPHnm54SyJQEHSEmY68ldfaGYW6F+BhgjbjvtUvhU0PRyR6Pd/h7SjAfV/2yeXVv39j5GvdtLPAaQxId37GgZ/GU6T2zeTWs+V4aIgMExjpArX63fLgMejcyuugLK+ndccqMyAR1ZKNmiyEAqKnM4ppLVV81ONtrU5EtomhlxlvW1HfQA5xou2eIou7fnxmn5BC7IeWVtkPR99zSDP8V5pUKGaC3h8wAICDyD+ehZsGrCjY3wGH/DwyX6xWYJx4FsFetji+Ggo0kKu5BqKbyuMFFnRTeV3T1AZRXsZJpUcIhkcNmCswrHwseePAtsBtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uiOYhf38DKIjBPK00j6goiqE9M1gZMMncsdo2EGoiGY=; b=k+FpNmuQWuNZzBix2iG5IC3DdfcEInvi/dq/atH8n7YqI1+GOYs4awqDTDHA/0WtgLLlODio2PLjNv4WMs0kjEYCG6FZBYHKubZQ0eHuh3MOXixOD2d1z8fu25ZnO47HJJZJJ6g1ijfB9pPMLh9Uf3Ra5CxzTLkEs6zo970ySlQ= Received: from BN9PR03CA0888.namprd03.prod.outlook.com (2603:10b6:408:13c::23) by IA0PPFEED3F51F3.namprd19.prod.outlook.com (2603:10b6:20f:fc04::cdd) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.16; Mon, 2 Feb 2026 14:56:34 +0000 Received: from BN2PEPF000055DA.namprd21.prod.outlook.com (2603:10b6:408:13c:cafe::f3) by BN9PR03CA0888.outlook.office365.com (2603:10b6:408:13c::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9564.16 via Frontend Transport; Mon, 2 Feb 2026 14:56:33 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BN2PEPF000055DA.mail.protection.outlook.com (10.167.245.4) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9587.0 via Frontend Transport; Mon, 2 Feb 2026 14:56:33 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id F13A9406540; Mon, 2 Feb 2026 14:56:32 +0000 (UTC) Received: from [198.90.208.24] (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id D68CB820249; Mon, 2 Feb 2026 14:56:32 +0000 (UTC) Message-ID: <643cb846-ffbe-471b-b805-48a8401e4b01@opensource.cirrus.com> Date: Mon, 2 Feb 2026 14:56:32 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_stop() To: Ziyi Guo , Simon Trimmer , Charles Keepax Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org References: <20260202144153.1668326-1-n7l8m4@u.northwestern.edu> Content-Language: en-GB From: Richard Fitzgerald In-Reply-To: <20260202144153.1668326-1-n7l8m4@u.northwestern.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DA:EE_|IA0PPFEED3F51F3:EE_ X-MS-Office365-Filtering-Correlation-Id: c059dbf6-75a3-4710-f1d2-08de626b41ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|82310400026|61400799027|7053199007|54012099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MGhoS1pYODAxNCtCTUR0S1hTSXk0c3FtYloxUWt2QlpHWEI4aW05TXZ2Q09O?= =?utf-8?B?Z3EwVnZEY1FBdHJ3OUsxcThFNkJJZTRIb09yWEw3Q2svbTVldHlad08vN0RX?= =?utf-8?B?UDg1bzJoM0hHNlNEMWQxOWsvRGVEaFlDQm5VNUh0TTk3S2gxN0RTT2Uya05n?= =?utf-8?B?eWx6ejEvTXhBbzcrTTlyM3pabXRzdzZFTW50NEd4MW9XaHh1WWRaVW9RbzBI?= =?utf-8?B?SUxtTmMzdnZaTW45cXJwcTNwb1VOVWVtR1EzMFNsZkozcDBDbUVPMThYVDhi?= =?utf-8?B?SHlJakdYb25zWGlHMThFQS8vREFQTzM1NTUrR1k4WFFkVTNyUk45S3Jhdm9K?= =?utf-8?B?ZzN5VzltKzBOK1FDR0N4T0tmZVpobnBvaHNKaVBBNTBsSFZpOVl5elM5VFlM?= =?utf-8?B?NFVMK25BWjMzMHNMMXdraVMrb0FtZ25aMnlTRFNZRjFXM2QrTVdNQnFDOWFq?= =?utf-8?B?TnB6KzR1WFcyblZuOE1hMnc4ZWEwbXdJd2RHWXFhS2pHY24xU2I1Sk85UkNo?= =?utf-8?B?YVNKYkhKSEFSTWVEaTNKcW1kcS9MT2F0V0h5bW5VTmhUb2YxdTFvcitxYy83?= =?utf-8?B?QitaM3laSGFpeXdDa2dpTDB0eEdUWElUa3VPVWlJMFdoVUVVbGtDV25IMDhF?= =?utf-8?B?aWN6SUE2VHRKQitLNEtERFhIV0JQb2xCOVRXWGhWQkltL2ZqR0wwcUZQUkpZ?= =?utf-8?B?UFZlYkV1NEd0UHNmbkJGTXg3QWpBVTd5N1JiT3VGdVo1U0VlVHhZMm5mV1Vv?= =?utf-8?B?WFREc3RqRU53TDdPVUJ2b0hrL1NqTWF6QzFna0RzVnI0cDNsMlg0RklhU3RE?= =?utf-8?B?a3BXb1FLeUVqbCs4cmlVaTZGc080dDVTbUZxUEt2dFRJcnExVW92dUViMWZI?= =?utf-8?B?VGRuL3RoWjU5YkxhTWFzeVZtVUVQNW4rUVErcTRTNmNJRDdTUVBqWWlHd2t3?= =?utf-8?B?WUNZU0hRSmhiTmttNUVOUkhuNWR3Tys3SEYzVjFVYjBkNUpobkx4UExZTm1z?= =?utf-8?B?UVlqYzJuYkdwdHZiT1lUTmFCUjRYYzBoNjJSVTdwYWE5cWVRcDNadWFXTWdQ?= =?utf-8?B?LzN5SEhFYVJ2a1phVllIVGJDTU5PRUFVbkFod2JPaGsvand5VFhVNmxmRVI2?= =?utf-8?B?ejlLTWF3SHJhcHlPUHQ0Rzd3WmxIekVXT3c1UkNYRitrSTFJMThRSTFoSHFJ?= =?utf-8?B?MnRsenJiZndNVlVNZWFzRy9MNE42b0tMeTRFcGFpV3lUZ0lFcy9vOXJFR3Zw?= =?utf-8?B?bUt5THJEUnAxd2JGN2NOSXZqQUxJQnpKL01BUjJaUDQ4eDZML1Z3T25SYjNq?= =?utf-8?B?NHJieTBMSG1TSEgxVWZHVHRmQXA4QjBYWXIzOEptL0V2ZE1RWk11SVpLNzQz?= =?utf-8?B?NVI3Vi9vcWo4Q1kwUXRkUTRSVjN6V2Q5VDNoZThxQk1GQjcrZ2JEM2dROXFF?= =?utf-8?B?cjBZc2VhTldaU2EvOHYxQjFINkc2WWlDQ3ozTmhHR0ZqaG9iZ3RSZFRvRDlB?= =?utf-8?B?MEh0K0t6Ykc4S1MxaXRWbmdQL2wvZW56M3p5bUxEZWliWDFxc21YRkJxVmNU?= =?utf-8?B?aTdLYUV3Tks3cldtS0NoOTNZWXJQOEtsaHEySTlKeTFURXZVdkxjeEQ3bnls?= =?utf-8?B?a01jaDdkREpHMEVWNzZSc0dWeHNuYVVYdTczbzlXYXdYUUV0S00zV0pWUTN5?= =?utf-8?B?WU90cjNGTWFJVWhpRm5acFZuKzN0T1YvMHJobCtEWXZlVTRUb05FK3h2S3lB?= =?utf-8?B?b21HNk9DaWVWdHFVaHFFVUVvRDRFdVExU3hrOUdkREtJN2c2a1Nld0xTbUkv?= =?utf-8?B?UWpQSkU4V05yaWJBVjk3TVVPTUl2c0dTbEc5dC9oamJ5VVV1TmMxbktIM1c0?= =?utf-8?B?dThZbTYraThhNVhtRzZFMVpySWFlYmxBNmJ1QVpxTWRzQjlYVks5V1czNFVq?= =?utf-8?B?RjlQa282U25VSG84NjVOWkMxRDNCRHcxOStvTkdZQlBCRWJZNnhsRnVDaUk4?= =?utf-8?B?VG9GZXJEWFgxVVgwNnZZQS8yTnU0UXkzdnBzZDdVcU90UmJVUmgzNU9GZzRC?= =?utf-8?B?NnVPMVFRc0V5b0hkM3ZpN1R4Rld6ZUJPcE45RGcvZkVIbktWUHlWZktucWdW?= =?utf-8?B?U3lTdkdIQWl4L0hBOXVuSjF5K1o1Yk5VYkFtaDhGTnc0Z0hWR28vTGZjVjE5?= =?utf-8?B?RDVPRlRqYUlqN0ZMd04yQisxNlhnVE4xMDhibHF6eTBVR2hqSW83NlRaQXd5?= =?utf-8?B?QTBrdGF2U25lNGNnSkRBUjRTUlNnPT0=?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(82310400026)(61400799027)(7053199007)(54012099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vltl4estqmOn8S/ifhm6PtSf6mPsiSjE6sjCX5tGUnI6EN2ExF+VzTNfXqkyEneyef/zecZpxxH4X0tuJbrbZvozkBUThnS7FjZEm0MnT/raVMW78JNH3gD6sTU9dL8N5BoHxJbIDwupxNlBHH6c/jwugTMJSPYPl0DW925EbTy4WsrbfuExOLJy5cdfp3eM+AlwbIKR6dsB1XX3nOFBBA/bmqQXJPLyAvsN9DPb3QfXRoy6t/RU9GNppdulA22qH8E9dSFVcLeNqw7yaTPBbr8oJRT4B7XL9NhFSQSXt52uWL/zsFtvZqZpizzhWM1YYiayUMuZooCnsdU4l271NubEcpwjolKT1nri8xNZ6FK6yZ4NmWpYiNt4x20jrCQ8xodKeDpxf9wqd6KTbqxjjDPQ+N2LsBPXiYjIuWiwJSgCz78dLMHs8abnvZ+DJlEK X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2026 14:56:33.8303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c059dbf6-75a3-4710-f1d2-08de626b41ef X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BN2PEPF000055DA.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPFEED3F51F3 X-Proofpoint-GUID: 9QmUWfivEHVAjfI23tny08FrSds0IN85 X-Authority-Analysis: v=2.4 cv=Mdthep/f c=1 sm=1 tr=0 ts=6980bb26 cx=c_pps a=4KArvT8Zi35IyF0Kdx8dHw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=Yu9lCUDHaK6DjO-y4qsA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: 9QmUWfivEHVAjfI23tny08FrSds0IN85 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDExNyBTYWx0ZWRfX0gUjgZ0KhSda clHZIT6oodcXFlE7rTbae6sWNIx0OKQW7puEgsrp87x03YO7loyfRa/ZqnhBNKa2vMV0SRPegVL dQH+zeYoEC6vm/c0p+XoYajommylzquts9Tnn2dyRLda93prjpd31wbCg3Bit8rF50LVKN6QmBs QKpiow4hNsUiZmCxlH5IyGwxzjUYDCGFybeIUsJNhnLjoYmqGlrjV9bFqwNH4gqNWew/ApS9Qoa ghrHQS8QaP2QH+ANFVVNQ1coqBF6CjLUv0L6dBbFUVBOL+8HKbMCHVHU9OC2XxRt8Fli9jD7Upr C5ifkh3vWW8QQVGQ8rrFxKqOYvx+0tPMq8adBhG2+ifKlBNdZqaKOEmjyffCTwEjcvpD66NKl5o EJRLC7UYHWcNypCBBUFBvWKzA8qJoNEZfIyx/pEmzJ1pu1eO92MdMYBypz2tl1HZO9U0+2G8SHd c2dSqvLCF1xglhyxo5g== X-Proofpoint-Spam-Reason: safe On 02/02/2026 2:41 pm, Ziyi Guo wrote: > cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control() > which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held. > > cs_dsp_signal_event_controls() is invoked from cs_dsp_stop(). > > Put mutex_lock() at the top of cs_dsp_stop() to fix the > missing lock protection, also align with cs_dsp_run(). > > Signed-off-by: Ziyi Guo > --- > v2: > - Put mutex_lock() at the top of cs_dsp_stop() to fix and align with cs_dsp_run() > > drivers/firmware/cirrus/cs_dsp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c > index 525ac0f0a75d..a491e89c0c97 100644 > --- a/drivers/firmware/cirrus/cs_dsp.c > +++ b/drivers/firmware/cirrus/cs_dsp.c > @@ -2864,6 +2864,8 @@ EXPORT_SYMBOL_NS_GPL(cs_dsp_run, "FW_CS_DSP"); > */ > void cs_dsp_stop(struct cs_dsp *dsp) > { > + mutex_lock(&dsp->pwr_lock); > + > /* Tell the firmware to cleanup */ > cs_dsp_signal_event_controls(dsp, CS_DSP_FW_EVENT_SHUTDOWN); > > @@ -2874,7 +2876,6 @@ void cs_dsp_stop(struct cs_dsp *dsp) > if (dsp->ops->show_fw_status) > dsp->ops->show_fw_status(dsp); > > - mutex_lock(&dsp->pwr_lock); > > if (dsp->client_ops->pre_stop) > dsp->client_ops->pre_stop(dsp); Nitpick: Commit title "fix missing pwr_lock in cs_dsp_stop()", it's not missing. Just in the wrong place. Apart from that: Reviewed-by: Richard Fitzgerald