From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755643Ab3KMBKj (ORCPT ); Tue, 12 Nov 2013 20:10:39 -0500 Received: from mail-pa0-f73.google.com ([209.85.220.73]:38475 "EHLO mail-pa0-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754011Ab3KMBKb (ORCPT ); Tue, 12 Nov 2013 20:10:31 -0500 From: David Decotigny To: linux-scsi@vger.kernel.org Cc: "James E.J. Bottomley" , linux-kernel@vger.kernel.org, David Decotigny Subject: [PATCH] scsi: avoid use of reclaimed reference Date: Tue, 12 Nov 2013 17:10:19 -0800 Message-Id: <643cda2192c25962f37c8bba65e22f70a57167d0.1384304973.git.decot@googlers.com> X-Mailer: git-send-email 1.8.4.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch avoids to use an object after it was potentially reclaimed by scsi_device_put(). Signed-off-by: David Decotigny --- drivers/scsi/scsi_scan.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 307a811..16e4a44 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1498,12 +1498,14 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags, out_err: kfree(lun_data); out: - scsi_device_put(sdev); - if (scsi_device_created(sdev)) + if (scsi_device_created(sdev)) { /* * the sdev we used didn't appear in the report luns scan */ __scsi_remove_device(sdev); + } + + scsi_device_put(sdev); return ret; } -- 1.8.4.1