From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A482BC76195 for ; Tue, 28 Mar 2023 11:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232671AbjC1LYQ (ORCPT ); Tue, 28 Mar 2023 07:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbjC1LYL (ORCPT ); Tue, 28 Mar 2023 07:24:11 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39E831FFB; Tue, 28 Mar 2023 04:23:59 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id C39BF5FD16; Tue, 28 Mar 2023 14:23:56 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1680002636; bh=dJk0VhVFxTihh+TBGBXcxtL9YxXttn8vWx345uiojAw=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; b=P7p/H6aS5KM8I5eD7aGalT70Sx0PKpAn2U+NvQStqTXKQARqS6H+lU/4ZJwS2YD1Q X1nFYnWOOipJxtphHWem3DpsZgKb2dy0m8+LKMc47ehLbnnGJQYS/Oe8pR+zrLVpNs QpJlAQo2/Yj9sZqrx58azHUdaawP0gpPOMHQvwyqfDTOSQ2xmgNi1Gq9jhuQd2dk+y pTjfa3kyt14Ux6NPtjoQgvKZeRu07BI/2+3ldFr0/NumavqHVXSmnKGgbKQDPM7sjA MbNcEaZiG32Jvc+nsT0m1QmW1pbRJua7RHvcJN17rpPBdjO3AaNduSi3FbOVOl84Bd ALk2pMxyGxFIA== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Tue, 28 Mar 2023 14:23:53 +0300 (MSK) Message-ID: <64451c35-5442-73cb-4398-2b907dd810cc@sberdevices.ru> Date: Tue, 28 Mar 2023 14:20:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH v1 1/2] vsock: return errors other than -ENOMEM to socket Content-Language: en-US To: Stefano Garzarella , Vishnu Dasa CC: Bryan Tan , VMware PV-Drivers Reviewers , Stefan Hajnoczi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman , , , , , , References: <97f19214-ba04-c47e-7486-72e8aa16c690@sberdevices.ru> <99da938b-3e67-150c-2f74-41d917a95950@sberdevices.ru> <0f0a8603-e8a1-5fb2-23d9-5773c808ef85@sberdevices.ru> From: Arseniy Krasnov In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/28 06:38:00 #21021220 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.03.2023 14:19, Stefano Garzarella wrote: > On Tue, Mar 28, 2023 at 01:42:19PM +0300, Arseniy Krasnov wrote: >> >> >> On 28.03.2023 12:42, Stefano Garzarella wrote: >>> I pressed send too early... >>> >>> CCing Bryan, Vishnu, and pv-drivers@vmware.com >>> >>> On Tue, Mar 28, 2023 at 11:39 AM Stefano Garzarella wrote: >>>> >>>> On Sun, Mar 26, 2023 at 01:13:11AM +0300, Arseniy Krasnov wrote: >>>>> This removes behaviour, where error code returned from any transport >>>>> was always switched to ENOMEM. This works in the same way as: >>>>> commit >>>>> c43170b7e157 ("vsock: return errors other than -ENOMEM to socket"), >>>>> but for receive calls. >>>>> >>>>> Signed-off-by: Arseniy Krasnov >>>>> --- >>>>> net/vmw_vsock/af_vsock.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >>>>> index 19aea7cba26e..9262e0b77d47 100644 >>>>> --- a/net/vmw_vsock/af_vsock.c >>>>> +++ b/net/vmw_vsock/af_vsock.c >>>>> @@ -2007,7 +2007,7 @@ static int __vsock_stream_recvmsg(struct sock *sk, struct msghdr *msg, >>>>> >>>>>               read = transport->stream_dequeue(vsk, msg, len - copied, flags); >>>> >>>> In vmci_transport_stream_dequeue() vmci_qpair_peekv() and >>>> vmci_qpair_dequev() return VMCI_ERROR_* in case of errors. >>>> >>>> Maybe we should return -ENOMEM in vmci_transport_stream_dequeue() if >>>> those functions fail to keep the same behavior. >> >> Yes, seems i missed it, because several months ago we had similar question for send >> logic: >> https://www.spinics.net/lists/kernel/msg4611091.html >> And it was ok to not handle VMCI send path in this way. So i think current implementation >> for tx is a little bit buggy, because VMCI specific error from 'vmci_qpair_enquev()' is >> returned to af_vsock.c. I think error conversion must be added to VMCI transport for tx >> also. > > Good point! > > These are negative values, so there are no big problems, but I don't > know what the user expects in this case. > > @Vishnu Do we want to return an errno to the user or a VMCI_ERROR_*? Small remark, as i can see, VMCI_ERROR_ is not exported to user in include/uapi, so IIUC user won't be able to interpret such values correctly. Thanks, Arseniy > > In both cases I think we should do the same for both enqueue and > dequeue. > >> >> Good thing is that Hyper-V uses general error codes. > > Yeah! > > Thanks, > Stefano > >> >> Thanks, Arseniy >>>> >>>> CCing Bryan, Vishnu, and pv-drivers@vmware.com >>>> >>>> The other transports seem okay to me. >>>> >>>> Thanks, >>>> Stefano >>>> >>>>>               if (read < 0) { >>>>> -                      err = -ENOMEM; >>>>> +                      err = read; >>>>>                       break; >>>>>               } >>>>> >>>>> @@ -2058,7 +2058,7 @@ static int __vsock_seqpacket_recvmsg(struct sock *sk, struct msghdr *msg, >>>>>       msg_len = transport->seqpacket_dequeue(vsk, msg, flags); >>>>> >>>>>       if (msg_len < 0) { >>>>> -              err = -ENOMEM; >>>>> +              err = msg_len; >>>>>               goto out; >>>>>       } >>>>> >>>>> -- >>>>> 2.25.1 >>>>> >>> >> >