From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3B2C433FE for ; Wed, 13 Apr 2022 08:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233813AbiDMIdu (ORCPT ); Wed, 13 Apr 2022 04:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230395AbiDMIds (ORCPT ); Wed, 13 Apr 2022 04:33:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 28A9345067 for ; Wed, 13 Apr 2022 01:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649838687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NeUqm+ne36F4xgLJ0X00uzh5NyAKLt8TFOnpvu4oBhU=; b=Wz5/thO0BRBU/DLju2mJyh10fOIErs0OEFxngTrVWRV7NLBBOplaEM0/coCzGfbOE3iJ/C IRwnV7hlmMbRNoYOXoSTkxZ+GbRnZrZN4AdzvPLcphNrmY/3Pd9u/LKHNn0xQ+U3QdI7Qm IdwYuPkO/328qahR7+nBQJEFtVkP7rQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-209-yF-yiED1NrmLh90wvSMHXg-1; Wed, 13 Apr 2022 04:31:25 -0400 X-MC-Unique: yF-yiED1NrmLh90wvSMHXg-1 Received: by mail-wm1-f70.google.com with SMTP id v62-20020a1cac41000000b0038cfe6edf3fso2520041wme.5 for ; Wed, 13 Apr 2022 01:31:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NeUqm+ne36F4xgLJ0X00uzh5NyAKLt8TFOnpvu4oBhU=; b=Kz/YCe2zrHX0gwTs6w9I2jcMdtXRmcgy0PWf08hf3VbdOaOZ581YOjuTm1X3bQg0+1 pA0YvOymIb0Dt72xMz0sfNtpNu3SCp1EXr04LL81QRd+05D9UOjvWAkEpJUSAillsBDB M47w+tjNpHdxSfwGDNFjYG6/2uCCBP5yLjk/ze5HjloSvJWWwvkW7tlqL95sKjmSvcYL NH0X/XRKE8srfefU/p5DVXh54GJuEfVncMcRy+BKvw1XPtnWqaj9xb1n7R12Uoljk1L3 o6KjgNl/awKU88+y1ioPPcoq6DoPGLLENIGD44qnQB/1BX+TDygi0NpBgrBIqHIUhz1R F7UA== X-Gm-Message-State: AOAM531UWbRCkyb9fXM4/BQ2T87ouHNv+LC+G+hI0EFet4iErrJ/DKph NW9oNRioE/ZjTiRS8kFoQD9Z+TASrFm6UBuW8hwARyYL7OEPwFiVWjRVP3gp3+GKlqPfQAr/xsA HitwF//CqA2KHBgwb6QriK4+4 X-Received: by 2002:a05:6000:1864:b0:207:b1b8:8344 with SMTP id d4-20020a056000186400b00207b1b88344mr4345735wri.172.1649838684606; Wed, 13 Apr 2022 01:31:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyE77uz5Z4qxBFMdWfSHiOPeKoA86guzdUMpVNT5mhHJZqAhkmBKh6Y3vvYaiB/aZOzrfokaw== X-Received: by 2002:a05:6000:1864:b0:207:b1b8:8344 with SMTP id d4-20020a056000186400b00207b1b88344mr4345721wri.172.1649838684401; Wed, 13 Apr 2022 01:31:24 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id e10-20020a056000178a00b00207b6905778sm1243846wrg.33.2022.04.13.01.31.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 01:31:23 -0700 (PDT) Message-ID: <64456e38-0994-f2bb-39df-a7614c98c62c@redhat.com> Date: Wed, 13 Apr 2022 10:31:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] KVM: x86: Don't snapshot "max" TSC if host TSC is constant Content-Language: en-US To: Anton Romanov Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Suleiman Souhlal References: <20220225013929.3577699-1-seanjc@google.com> <609de7ff-92e2-f96e-e6f5-127251f6e16d@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/22 19:38, Anton Romanov wrote: >> Queued, but I'd rather have a subject that calls out that max_tsc_khz >> needs a replacement at vCPU creation time. In fact, the real change >> (and bug, and fix) is in kvm_arch_vcpu_create(), while the subject >> mentions only the change in kvm_timer_init(). >> >> What do you think of "KVM: x86: Use current rather than max TSC >> frequency if it is constant"? > > Ping. This said "queued" but I don't think this ever landed. > What's the status of this? > Paolo, does this need more work? The features in my second pull request were rejected by Linus so they will be in 5.19. I'm going to open kvm/next today and the patches will be there. Unfortunately he hasn't replied to my rebuttal at https://lore.kernel.org/kvm/30ffdecc-6ecd-5194-14ec-40e8b818889a@redhat.com/#t so I have no idea what his opinion is. I'll try to get more stuff in early for the next releases. Paolo