From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754557AbdGUQDG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Jul 2017 12:03:06 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:38090 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750849AbdGUQDF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Jul 2017 12:03:05 -0400
Cc: Sudeep Holla <sudeep.holla@arm.com>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: Convert to using %pOF instead of full_name
To: Rob Herring <robh@kernel.org>, arm@kernel.org
References: <20170718214339.7774-21-robh@kernel.org>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <6445babc-73d3-005c-8b83-22290c5d8bab@arm.com>
Date: Fri, 21 Jul 2017 17:03:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170718214339.7774-21-robh@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 18/07/17 22:43, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  drivers/firmware/arm_scpi.c | 2 +-
>  drivers/firmware/psci.c     | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 8043e51de897..59190c374696 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
> 
>  	count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
>  	if (count < 0) {
> -		dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
> +		dev_err(dev, "no mboxes property in '%pOF'\n", np);
>  		return -ENODEV;
>  	}
> 

(For the SCPI part)
Acked-by: Sudeep Holla <sudeep.holla@arm.com>

I assume you will ask ARM-SoC guys to pick this up. Let us know if you
think otherwise.

-- 
Regards,
Sudeep