From: David Brownell <david-b@pacbell.net>
To: linux-usb@vger.kernel.org, Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: gadget: mass storage: use proper device class in device desc
Date: Thu, 1 Jul 2010 03:09:48 -0700 (PDT) [thread overview]
Message-ID: <644607.54176.qm@web180308.mail.gq1.yahoo.com> (raw)
In-Reply-To: <59b191a020300966e20eef4e942bc75982d792fb.1277735580.git.m.nazarewicz@samsung.com>
--- On Thu, 7/1/10, Michal Nazarewicz <m.nazarewicz@samsung.com> wrote:
> to match the real class and protocol instead of leaving it
> as per
> interface.
It works now though ... why change it,
and risk causing breakage??
>
>
> Each time I see the device descriptor of the File Storage
> Gadget
> I wonder if it shouldn't be set to the real value rather
> then leaving
> it as per interface.
>
> Is there a reason to leave it as per interface? Will
> chenging it to
> the real value change anything?
>
> I checked my pendrive and an IDE<->USB adapter they
> as well use a per
> interface class ...
next prev parent reply other threads:[~2010-07-01 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 9:17 Michal Nazarewicz
2010-07-01 10:09 ` David Brownell [this message]
2010-07-01 10:15 ` Michał Nazarewicz
2010-07-01 14:09 ` Alan Stern
2010-07-01 14:26 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644607.54176.qm@web180308.mail.gq1.yahoo.com \
--to=david-b@pacbell.net \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®