mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: Will Deacon <will@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
	"Elena Reshetova" <elena.reshetova@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Jan Glauber <jglauber@marvell.com>
Subject: Re: [PATCH v3 00/10] Rework REFCOUNT_FULL using atomic_fetch_* operations
Date: Wed, 9 Oct 2019 18:01:00 +0800	[thread overview]
Message-ID: <644616a9-ec05-1d2e-22fc-93890adb3324@huawei.com> (raw)
In-Reply-To: <20191007154703.5574-1-will@kernel.org>

On 2019/10/7 23:46, Will Deacon wrote:
> Hi all,
> 
> This is version three of the patches I previously posted here:
> 
>   v1: https://lkml.kernel.org/r/20190802101000.12958-1-will@kernel.org
>   v2: https://lkml.kernel.org/r/20190827163204.29903-1-will@kernel.org
> 
> Changes since v2 include:
> 
>   - Remove the x86 assembly version and enable this code unconditionally
>   - Move saturation warnings out-of-line to reduce image bloat
> 
> Cheers,
> 
> Will
> 
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Elena Reshetova <elena.reshetova@intel.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Hanjun Guo <guohanjun@huawei.com>
> Cc: Jan Glauber <jglauber@marvell.com>
> 

I tested on top of 5.4-rc2 (with Jan's open-read-close file test case), on a 96 CPU
cores ARM64 server, I can see no much difference under 24 cores (each 24 core is
a NUMA node), but +5.9% performance improve on 48 cores and +8.4% for 96 cores.

For the ARM64 arch,

Tested-by: Hanjun Guo <guohanjun@huawei.com>

Thanks
Hanjun


      parent reply	other threads:[~2019-10-09 10:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 15:46 Will Deacon
2019-10-07 15:46 ` [PATCH v3 01/10] lib/refcount: Define constants for saturation and max refcount values Will Deacon
2019-10-07 15:46 ` [PATCH v3 02/10] lib/refcount: Ensure integer operands are treated as signed Will Deacon
2019-10-07 15:46 ` [PATCH v3 03/10] lib/refcount: Remove unused refcount_*_checked() variants Will Deacon
2019-10-07 15:46 ` [PATCH v3 04/10] lib/refcount: Move bulk of REFCOUNT_FULL implementation into header Will Deacon
2019-10-07 15:46 ` [PATCH v3 05/10] lib/refcount: Improve performance of generic REFCOUNT_FULL code Will Deacon
2019-10-09  9:25   ` Peter Zijlstra
2019-10-09 11:35     ` Peter Zijlstra
2019-10-09 16:44     ` Will Deacon
2019-10-09 17:41       ` Peter Zijlstra
2019-10-07 15:46 ` [PATCH v3 06/10] lib/refcount: Move saturation warnings out of line Will Deacon
2019-10-10 20:48   ` Kees Cook
2019-10-11 12:09     ` Will Deacon
2019-10-07 15:47 ` [PATCH v3 07/10] lib/refcount: Consolidate REFCOUNT_{MAX,SATURATED} definitions Will Deacon
2019-10-07 15:47 ` [PATCH v3 08/10] refcount: Consolidate implementations of refcount_t Will Deacon
2019-10-10 20:49   ` Kees Cook
2019-10-07 15:47 ` [PATCH v3 09/10] lib/refcount: Remove unused 'refcount_error_report()' function Will Deacon
2019-10-10 20:50   ` Kees Cook
2019-10-11 12:12     ` Will Deacon
2019-10-07 15:47 ` [PATCH v3 10/10] drivers/lkdtm: Remove references to CONFIG_REFCOUNT_FULL Will Deacon
2019-10-10 20:50   ` Kees Cook
2019-10-09 10:01 ` Hanjun Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=644616a9-ec05-1d2e-22fc-93890adb3324@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=elena.reshetova@intel.com \
    --cc=jglauber@marvell.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®