From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbdK3WX7 (ORCPT ); Thu, 30 Nov 2017 17:23:59 -0500 Received: from ale.deltatee.com ([207.54.116.67]:50086 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbdK3WX6 (ORCPT ); Thu, 30 Nov 2017 17:23:58 -0500 To: Serge Semin , jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com, Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com Cc: Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org References: <20170808101147.24625-1-fancer.lancer@gmail.com> <20171130213707.20910-1-fancer.lancer@gmail.com> From: Logan Gunthorpe Message-ID: <644da251-a309-14dc-02b2-cf565b3e3e17@deltatee.com> Date: Thu, 30 Nov 2017 15:23:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171130213707.20910-1-fancer.lancer@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, Sergey.Semin@t-platforms.ru, Xiangliang.Yu@amd.com, Shyam-sundar.S-k@amd.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, fancer.lancer@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/11/17 02:37 PM, Serge Semin wrote: > Changelog v2: > - Remove driver Author/Description/License macros This patch is already very long and should be split up, and you added more to it? If you want to fix these macros it should be in it's own patch with it's own justification. > - u64 db_bits; > char *buf, cmd; > - ssize_t rc; > + ssize_t ret; I commented on this last time we saw these patches and changing the variable name from 'rc' to 'ret' (in a number of places) is unnecessary and just adds to the noise of an already gigantic patch. I'm personally not going to review it further until I see a cleaner easier to read patch or series. Logan