From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D48C2BD09 for ; Tue, 10 Dec 2019 01:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E853020637 for ; Tue, 10 Dec 2019 01:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbfLJBmp (ORCPT ); Mon, 9 Dec 2019 20:42:45 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:19740 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbfLJBmo (ORCPT ); Mon, 9 Dec 2019 20:42:44 -0500 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBA1fnQL141195 for ; Mon, 9 Dec 2019 20:42:43 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wsmftjwyc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Dec 2019 20:42:42 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Dec 2019 01:42:41 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 10 Dec 2019 01:42:38 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xBA1gbPr54394894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 01:42:37 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19DDA11C04A; Tue, 10 Dec 2019 01:42:37 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6145311C052; Tue, 10 Dec 2019 01:42:35 +0000 (GMT) Received: from localhost.localdomain (unknown [9.199.59.157]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 10 Dec 2019 01:42:35 +0000 (GMT) Subject: Re: [PATCH v5 3/6] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files To: Greg KH Cc: corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, mahesh@linux.vnet.ibm.com, hbathini@linux.ibm.com References: <20191209045826.30076-1-sourabhjain@linux.ibm.com> <20191209045826.30076-4-sourabhjain@linux.ibm.com> <20191209081023.GC706232@kroah.com> From: Sourabh Jain Date: Tue, 10 Dec 2019 07:12:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20191209081023.GC706232@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19121001-0012-0000-0000-00000373505B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19121001-0013-0000-0000-000021AF20DB Message-Id: <64537bac-5fc3-bda8-4cac-338436b30d3e@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-09_05:2019-12-09,2019-12-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912100014 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/9/19 1:40 PM, Greg KH wrote: > On Mon, Dec 09, 2019 at 10:28:23AM +0530, Sourabh Jain wrote: >> +#define CREATE_SYMLINK(target, symlink_name) do {\ >> + rc = compat_only_sysfs_link_entry_to_kobj(kernel_kobj, fadump_kobj, \ >> + target, symlink_name); \ >> + if (rc) \ >> + pr_err("unable to create %s symlink (%d)", symlink_name, rc); \ >> +} while (0) > > > No need for a macro, just spell it all out. And properly clean up if an > error happens, you are just printing it out and moving on, which is > probably NOT what you want to do, right? Yeah actually there is no point in keeping the fadump_enabled symlink if fadump_registered symlink creation fails. And it is even better to unregister the FADump if fadump_group creation fails. > >> +static struct attribute_group fadump_group = { >> + .attrs = fadump_attrs, >> +}; > > ATTRIBUTE_GROUPS()? Thanks, I will use this macro. -Sourabh Jain