From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973CEC47088 for ; Wed, 26 May 2021 06:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 771CA61028 for ; Wed, 26 May 2021 06:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232817AbhEZGNd (ORCPT ); Wed, 26 May 2021 02:13:33 -0400 Received: from mga03.intel.com ([134.134.136.65]:9993 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232734AbhEZGNb (ORCPT ); Wed, 26 May 2021 02:13:31 -0400 IronPort-SDR: NGRhW1Bu98CWIBXWKNp4zUjX2MCJq0ul8zlEZO6w5rBL7zzp/CCF7oMjOyEJHQf9CFHcwIrZyd lPiGTPaD+r7w== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="202427906" X-IronPort-AV: E=Sophos;i="5.82,330,1613462400"; d="scan'208";a="202427906" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 23:12:00 -0700 IronPort-SDR: HXzVmDFmx9YLRavm+0HGn3TbVDMu+xTUzDV+jZmKfV/9Ex232tslEmWG004A1DePsLC1+B4Ij0 BRGP3VJZaCbg== X-IronPort-AV: E=Sophos;i="5.82,330,1613462400"; d="scan'208";a="476776700" Received: from unknown (HELO [10.238.130.158]) ([10.238.130.158]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 23:11:58 -0700 Subject: Re: [PATCH RFC 4/7] kvm: x86: Add new ioctls for XSAVE extension To: Jim Mattson Cc: Paolo Bonzini , Sean Christopherson , kvm list , LKML , jing2.liu@intel.com References: <20210207154256.52850-1-jing2.liu@linux.intel.com> <20210207154256.52850-5-jing2.liu@linux.intel.com> From: "Liu, Jing2" Message-ID: <645508cb-abf5-350d-f0ae-6044ecc3ceb8@linux.intel.com> Date: Wed, 26 May 2021 14:11:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/2021 6:06 AM, Jim Mattson wrote: > On Sat, Feb 6, 2021 at 11:00 PM Jing Liu wrote: >> The static xstate buffer kvm_xsave contains the extended register >> states, but it is not enough for dynamic features with large state. >> >> Introduce a new capability called KVM_CAP_X86_XSAVE_EXTENSION to >> detect if hardware has XSAVE extension (XFD). Meanwhile, add two >> new ioctl interfaces to get/set the whole xstate using struct >> kvm_xsave_extension buffer containing both static and dynamic >> xfeatures. Reuse fill_xsave and load_xsave for both cases. >> >> Signed-off-by: Jing Liu >> --- >> +#define KVM_GET_XSAVE_EXTENSION _IOW(KVMIO, 0xa4, struct kvm_xsave_extension) >> +#define KVM_SET_XSAVE_EXTENSION _IOW(KVMIO, 0xa5, struct kvm_xsave_extension) > Isn't the convention to call these KVM_GET_XSAVE2 and KVM_SET_XSAVE2? > > Do you have any documentation to add to Documentation/virt/kvm/api.rst? Thanks for reviewing the patch. I'll change the name as convention and add documentation if new apis are needed. BRs, Jing