From: Sekhar Nori <nsekhar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Kevin Hilman <khilman@kernel.org>,
Patrick Titiano <ptitiano@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Tejun Heo <tj@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
David Lechner <david@lechnology.com>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock
Date: Thu, 26 Jan 2017 23:10:49 +0530 [thread overview]
Message-ID: <645778dd-6727-abd0-3dd9-a7e0d5aa4983@ti.com> (raw)
In-Reply-To: <93a3bbb3-2d9f-bc38-c7b4-5eb3325d985d@ti.com>
On Thursday 26 January 2017 10:26 PM, Grygorii Strashko wrote:
>
>
> On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
>> The ahci-da850 SATA driver is now capable of retrieving clocks by
>> con_id. Add the connection id for the sysclk2-derived SATA clock.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> arch/arm/mach-davinci/da850.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>> index 1d873d1..dbf1daa 100644
>> --- a/arch/arm/mach-davinci/da850.c
>> +++ b/arch/arm/mach-davinci/da850.c
>> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
>> CLK("spi_davinci.0", NULL, &spi0_clk),
>> CLK("spi_davinci.1", NULL, &spi1_clk),
>> CLK("vpif", NULL, &vpif_clk),
>> - CLK("ahci_da850", NULL, &sata_clk),
>> + CLK("ahci_da850", "sata", &sata_clk),
>
> I'm worry a bit - wouldn't this cause future problems with PM runtime
> (if it will be the case)?
>
> If this is functional clock - shouldn't it be "fck" to
> follow PM domain con_id list for davinci? (arch/arm/mach-davinci/pm_domain.c)
I agree with Grygorii. Calling this clock "fck" will make it easy to
convert the DA850 AHCI driver to use pm_runtime at a future date (no
mach-davinci changes should be needed).
Sorry about not spotting this earlier.
Thanks,
Sekhar
next prev parent reply other threads:[~2017-01-26 17:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 17:00 [PATCH v6 00/14] ARM: da850-lcdk: add SATA support Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 01/14] devicetree: bindings: add bindings for ahci-da850 Bartosz Golaszewski
2017-01-27 20:58 ` Rob Herring
2017-01-23 17:00 ` [PATCH v6 02/14] ARM: davinci_all_defconfig: enable SATA modules Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 03/14] ARM: davinci: add a clock lookup entry for the SATA clock Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 04/14] sata: ahci-da850: get the sata clock using a connection id Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock Bartosz Golaszewski
2017-01-26 16:56 ` Grygorii Strashko
2017-01-26 17:40 ` Sekhar Nori [this message]
2017-01-27 9:55 ` Bartosz Golaszewski
2017-01-27 9:58 ` Sekhar Nori
2017-01-23 17:00 ` [PATCH v6 06/14] ARM: davinci: da850: model the SATA refclk Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 07/14] sata: ahci-da850: add device tree match table Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 08/14] sata: ahci-da850: implement a workaround for the softreset quirk Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 09/14] sata: ahci: export ahci_do_hardreset() locally Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 10/14] sata: ahci-da850: add a workaround for controller instability Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 11/14] sata: ahci-da850: un-hardcode the MPY bits Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 12/14] ARM: davinci: remove BUG_ON() from da850_register_sata() Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 13/14] ARM: dts: da850: add the SATA node Bartosz Golaszewski
2017-01-23 17:00 ` [PATCH v6 14/14] ARM: dts: da850-lcdk: enable " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645778dd-6727-abd0-3dd9-a7e0d5aa4983@ti.com \
--to=nsekhar@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=ptitiano@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®