From: "Thomas, Rijo-john" <Rijo-john.Thomas@amd.com>
To: Colin King <colin.king@canonical.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Jens Wiklander <jens.wiklander@linaro.org>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Gary R Hook <gary.hook@amd.com>,
tee-dev@lists.linaro.org,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee
Date: Thu, 16 Jan 2020 13:37:03 +0530 [thread overview]
Message-ID: <645872d0-02fe-84f7-209a-dd43cb8264a1@amd.com> (raw)
In-Reply-To: <20200116070544.doegatlwgsftbhc4@gondor.apana.org.au>
Hi Colin,
On 16/01/20 12:35 pm, Herbert Xu wrote:
> On Wed, Jan 08, 2020 at 12:33:08PM +0530, Thomas, Rijo-john wrote:
>> +linux-crypto
>>
>> On 07/01/20 8:06 pm, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Currently the memory allocation failure checks on drv_data and
>>> amdtee are using IS_ERR rather than checking for a null pointer.
>>> Fix these checks to use the conventional null pointer check.
>>>
>>> Addresses-Coverity: ("Dereference null return")
>>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
>
> This patch needs to be resubmitted to the linux-crypto list for
> it to be picked up by patchwork.
Can you please resubmit this patch to linux-crypto list?
Thanks,
Rijo
>
> Thanks,
>
prev parent reply other threads:[~2020-01-16 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 14:36 Colin King
2020-01-08 7:03 ` Thomas, Rijo-john
2020-01-08 7:53 ` Jens Wiklander
2020-01-16 7:05 ` Herbert Xu
2020-01-16 8:07 ` Thomas, Rijo-john [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=645872d0-02fe-84f7-209a-dd43cb8264a1@amd.com \
--to=rijo-john.thomas@amd.com \
--cc=Devaraj.Rangasamy@amd.com \
--cc=colin.king@canonical.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=jens.wiklander@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®