mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"frederic@kernel.org" <frederic@kernel.org>,
	"Dutka, Gianfranco" <gianfranco.dutka@arista.com>
Cc: "bsegall@google.com" <bsegall@google.com>,
	"vschneid@redhat.com" <vschneid@redhat.com>,
	"tj@kernel.org" <tj@kernel.org>,
	"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
	"vincent.guittot@linaro.com" <vincent.guittot@linaro.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"mgorman@suse.de" <mgorman@suse.de>,
	"bristot@redhat.com" <bristot@redhat.com>
Subject: Re: Modifying isolcpus, nohz_full, and rcu_nocb kernel parameters at runtime
Date: Tue, 12 Dec 2023 15:13:21 -0500	[thread overview]
Message-ID: <64589863-d878-4daf-9eac-00717f317022@redhat.com> (raw)
In-Reply-To: <2059341ff4189c8828a41082248f11712edd2b9e.camel@intel.com>

On 12/12/23 09:04, Pandruvada, Srinivas wrote:
> Hi Fredric,
> On Tue, 2023-12-12 at 14:27 +0100, Frederic Weisbecker wrote:
>> On Fri, Dec 08, 2023 at 09:18:53AM -0500, Gianfranco Dutka wrote:
>>>> The isolcpus, nohz_full and rcu_nocbs are boot-time kernel
>>>> parameters. I am in the process of improving dynamic CPU
>>>> isolation at runtime. Right now, we are able to do
>>>> isolcpus=domain with the isolated cpuset partition functionality.
>>>> Other aspects of CPU isolation are being looked at with the goal
>>>> of reducing the gap of what one can do at boot time versus what
>>>> can be done at run time. It will certain take time to reach that
>>>> goal.
>>>>
>>>> Cheers,
>>>> Longman
>>>>
>>> Thank you Waiman for the response. It would seem that getting
>>> similar
>>> functionality through cgroups/cpusets is the only option at the
>>> moment. Is it
>>> completely out of the question to possibly patch the kernel to
>>> modify these
>>> parameters at runtime? Or would that entail a significant change
>>> that might
>>> not be so trivial to accomplish? For instance, the solution
>>> wouldn’t be as
>>> simple as patching the kernel to make these writeable and then
>>> calling the
>>> same functions which run at boot-time when these parameters are
>>> originally
>>> written?
>> As for nohz_full (which implies rcu_nocb), it's certainly possible to
>> make it
>> tunable at runtime via cpusets. If people really want it, I'm willing
>> to help.
>>
> We have a case for dynamically isolating CPUs at run time.
>
> https://lore.kernel.org/lkml/ZNM5qoUSCdBwNTuH@chenyu5-mobl2/
>
> It was suggested by Vincent to use house keeping cpumask for solving
> unnecessary wake ups on isolated CPUs. Can this house keeping cpu mask
> and type be updated at runtime?

The house keeping cpumasks are statically set up at boot time. The 
cpuset code will have an internal isolated_cpus cpumask that lists all 
the CPUs that are in isolated partitions. It will also expose it with a 
new cpuset_cpu_is_isolated() function. The code is currently in the 
cgroup tree and will be merged into the upcoming v6.8 kernel. As the new 
isolated_cpus mask can be changed at run time, some synchronization may 
be needed depending on how it is being used. So the cpumask itself will 
not be exported, new API can be provided to copy out the cpumask if needed.

Cheers,
Longman


  reply	other threads:[~2023-12-12 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 15:07 Gianfranco Dutka
2023-12-07 16:32 ` Vincent Guittot
2023-12-07 22:41   ` Tejun Heo
     [not found]     ` <d46834f4-a490-4a4a-9e95-cca4a6316570@redhat.com>
2023-12-08 14:21       ` Gianfranco Dutka
     [not found]       ` <25E6E1E4-DC16-490E-B907-A3236FB9317A@arista.com>
2023-12-08 15:39         ` Waiman Long
2023-12-12 13:27         ` Frederic Weisbecker
2023-12-12 14:04           ` Pandruvada, Srinivas
2023-12-12 20:13             ` Waiman Long [this message]
2023-12-12 18:48           ` Phil Auld
2023-12-12 20:18           ` Waiman Long
2023-12-12 23:57             ` Frederic Weisbecker
2023-12-13  2:28               ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64589863-d878-4daf-9eac-00717f317022@redhat.com \
    --to=longman@redhat.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=frederic@kernel.org \
    --cc=gianfranco.dutka@arista.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=srinivas.pandruvada@intel.com \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®