From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2847A22D78A for ; Fri, 13 Feb 2026 06:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770963703; cv=none; b=maIKgmRq7aFEoLI9ZLHmKEWbISBf5y8Z0GOgUEvz/Jp7lvbUBoIb0MqHY+Jod3X8INwtLJvpG1i8f2lkfS7U27cCraxCUm0WbNSXlkMdeu+M/wFhrEaB6yoVvNVY20ZtURbqXsKv3rj+jgKVOn88D8i0nuty6xeaJ7jFZSHAIzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770963703; c=relaxed/simple; bh=QdH4O1A8pUU3ZzK+jSr8OFhJzuwTAf9sNHwTqyfdHjs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BRT3a6fyFaIFwetNG2cHycxPZP3NHlpXFlwPTYmpCOZpC0vRJsekIpl38wLHSbcdl8Hhnf1fDPm8QH5UrlD5a55AWX3AYTC/oQTVwoHAhsBtxr0KNFTP1naGAqNcfJI33y2zcusmiSPEkn0SkCacTpdT1+zEKqJQSTBOglDcXNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iYhj5Q4S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZUC9PLyH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iYhj5Q4S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZUC9PLyH" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CLGqjc1068459 for ; Fri, 13 Feb 2026 06:21:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CbshBBilHLyCNF/Met/2kiZTR1AF1t09ooB2XufK8E4=; b=iYhj5Q4SlNTu7EAu V1Lkfaw6Fsl0314erPinzoHQVzYsOomZ7NUrQGAZUNlcJWn8av6LY7FlMapqpiq4 FqgK39LG1AW8lCgmUf+ZS8fWqym2rPzHKgHCBtfcxf70FoKtUjTwtBDz5Df90cGh ZbDeqCCwGTz3FKsM8KECYGwfqp1IRBju6c/JFdnDABv8bDp6mAR7ike7iKyMClzr 2dcMHRmZHrO5UnpZWhINfaouG5rHJIamTq+7vXkMEgy64G4X/J+iscf3c0sbRMoP +qI7NUdZ7ekc9sHecKYGGFym4hhGBmdtUPVBpsIY9X/v6s5HjDYCZfsPasoP5GAE 3LsZhQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9d09kurc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 06:21:41 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a92a3f5de9so5237875ad.2 for ; Thu, 12 Feb 2026 22:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770963701; x=1771568501; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CbshBBilHLyCNF/Met/2kiZTR1AF1t09ooB2XufK8E4=; b=ZUC9PLyHu3/BZ3HmEmAojL90KN+AN85+0gT3PAYmUx4n/ty9OtzKIo0Q4WV7GEn8Pn Bg6Z+gmiYrBezmVSfNgS6ARxHmCX2nbKUvIugWvEdLj6zEoWMaxy8GgU7+ij5KozhmTk IS/d7ndBKWcBYgERhKvlVkJJAxVL6+lpxMiVEuRaA8LEaXqFPyzq+YtbTEoNqpguWG8R kFwTOTd7aaF9NTFotorWI/a7JEjvCemQRLdU2vATwETykTCgtKvlkWLRjh48iAfXNW28 XAhkUOwysEz9X5ws02QMV6la6cMX8TA+YenkhBEDgIa4DstuhmNhV4BUMepRNdTfyEg6 Nrpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770963701; x=1771568501; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CbshBBilHLyCNF/Met/2kiZTR1AF1t09ooB2XufK8E4=; b=vH7bFX01P50/T8tjsgxaI8zPjaQXYW2OqWp3BfQz8ZAq7x6uO5j5ngKYInF3w5duoZ EvK0UAO94BboLt+SCcZMJkg80AHfZeNW6ISJAhrtGO1wCGxYMwOFwErDikRN3ZarYMYE omhYltXc5VuUFooVyvCZdh+EJ6Ng5Jz7Hnlaj23yMAasS/ml6c4Bl4US6GGbTRiAt0JO MTjYn80VN0yQG0drcbPgvh1T4Z6AKWkSzD/rkmCubhf2LDOXswr3gvDsQ7g/MkD7dFrW ZsfdNQf998LHk13ms+7QNtmJFhROkfMJvB3CVHKkwTothT79fs4KJ1wNysehHBIGDRm9 0zJQ== X-Forwarded-Encrypted: i=1; AJvYcCUU25Ft4C/9G3crYeoq6LD+3Xo6ix0yrCoe64JaPpwyzhfC3QbxY921y1GSIo+1aFYCKbqx5p1zEJ14zPc=@vger.kernel.org X-Gm-Message-State: AOJu0YwWqawQItBtaeaUL27t/xIQq5CV2SSciStUmli7S06z0sMAEmHz lGC0i/sCFKh5347gtz2V8Jfa5/iBu5qKl7jMBXD5zvnJW8uYBZqNPYvL3lZDylRxKMG4VbPvAr8 SBeDwHIz825maA2OxZ9eFgBDhsyEOPqA8RGa2LoJAZfcp8wP2AYvxJq2y4uawR8nZvsI= X-Gm-Gg: AZuq6aIRMBd7RsOW+B8b+cJKho48Ek+nYp2QlLuWclZO5I3bVglvSpsfgE944lMiehH lqMqQLcLkyk/B/3eCy0QPPbXUV2VLvY0rSg/n2SRRzu4SWKzJ+oBEVYYwA9QMoTELCQHO9gAc1i 6aGvwPpvzB9gzENTb3BpZYdGZnLRAjgGLivn0delSkwwCNZomWZaE3gpCx8Ivwp0qmJcD9TDSBf kQIVhCpaMnP3r8611PsnfxURI1Rvt5Cr4+MDP0Tjha8kMzwuJoGJe6FWhZC6ftJnUrE2sA1x58x I54rEo/5X9ScnKAuXRzsE4zIb6Zsty9GlPdnVcO0Wtx9mBSwmu19Ii1d4518cdLwppAWtwFSNSc MVFRCPK/mazLNHOBwEntA1HDFyYcCM4rWXUh/CWsddwZSvRfa57VJPgtHDQ== X-Received: by 2002:a17:903:3545:b0:29d:a26c:34b6 with SMTP id d9443c01a7336-2ab506145ffmr7602395ad.50.1770963700537; Thu, 12 Feb 2026 22:21:40 -0800 (PST) X-Received: by 2002:a17:903:3545:b0:29d:a26c:34b6 with SMTP id d9443c01a7336-2ab506145ffmr7602065ad.50.1770963699961; Thu, 12 Feb 2026 22:21:39 -0800 (PST) Received: from [10.217.198.130] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab29848585sm71963005ad.2.2026.02.12.22.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 22:21:39 -0800 (PST) Message-ID: <64597399-3c38-436a-8d7e-f05dcb5aced0@oss.qualcomm.com> Date: Fri, 13 Feb 2026 11:51:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] hwmon: Add Qualcomm PMIC BCL hardware monitor driver To: Krzysztof Kozlowski Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , amit.kucheria@oss.qualcomm.com, Daniel Lezcano , Gaurav Kohli , linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260206-qcom-bcl-hwmon-v1-0-7b426f0b77a1@oss.qualcomm.com> <20260206-qcom-bcl-hwmon-v1-2-7b426f0b77a1@oss.qualcomm.com> <20260206-garrulous-lilac-porcupine-083b08@quoll> Content-Language: en-US From: Manaf Meethalavalappu Pallikunhi In-Reply-To: <20260206-garrulous-lilac-porcupine-083b08@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDA0NyBTYWx0ZWRfX5hVdhQcAQ5Uf iZjnUCcmelVnI+REqTRNM2EqHxQwmK90n6PTwFQtfc5ZnqxWNF6DzTNJAndk8lvjGIYAPN3qK2H 7egnwdr8e1pdF5Ncv5ynL5frW+s1H9wvrtvzEIjiINRbKsHDd//h6676Hr+K4T3Q3D9MABv7t2L DzwGcd9sOfqyIOdxrVxwx4F+xtm22hoOyqd46v+eQzV/pPIlCbkUQQvpYpqdWdy+VSyzfn7Nu2P jsjfqPk4H0bFlqWB50zce1w3IOXEGYaX9LdtiLFG7ntreLSjEmdIxt1NhIEMOoaTmsohLRws5lR +X2sxAaKI+5xRtT9H5dtM45KTA+tMe2lDYN01h5gSyizQtga5spz8b5lxLAMmYPB3pY5zxEl4bJ 3wN5ZkkjVon8+5qeQuBA8ea9VQpIBnlrhMCi0WruUnOjiKBLurpTzFhKcpzH1v/iXigDBWpWq+P WfyDPKr/RqU3AsWroUw== X-Proofpoint-GUID: N2gjFRj2VPxgHKBfkW0IOyYG8wlJ00p- X-Authority-Analysis: v=2.4 cv=Y6j1cxeN c=1 sm=1 tr=0 ts=698ec2f5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=HmNDJNLBL1k4sQOxQ4sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: N2gjFRj2VPxgHKBfkW0IOyYG8wlJ00p- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130047 Hi Krzysztof, On 2/6/2026 1:42 PM, Krzysztof Kozlowski wrote: > On Fri, Feb 06, 2026 at 02:44:06AM +0530, Manaf Meethalavalappu Pallikunhi wrote: >> + bcl->hwmon_dev = devm_hwmon_device_register_with_info(&pdev->dev, >> + bcl->hwmon_name, >> + bcl, >> + &bcl_hwmon_chip_info, >> + NULL); >> + if (IS_ERR(bcl->hwmon_dev)) { >> + dev_err(&pdev->dev, "Failed to register hwmon device: %ld\n", >> + PTR_ERR(bcl->hwmon_dev)); >> + return PTR_ERR(bcl->hwmon_dev); >> + } >> + >> + dev_dbg(&pdev->dev, "BCL hwmon device with version: %u.%u registered\n", >> + bcl_get_version_major(bcl), bcl_get_version_minor(bcl)); >> + >> + return 0; >> +} >> + >> +static const struct of_device_id bcl_match[] = { >> + { >> + .compatible = "qcom,bcl-v1", >> + .data = &pm7250b_data, > And that's the proof that your binding is just repeating downstream > bollocks pattern. Something like "v1" does not exist if you even here > claim this is not "v1", but pm7250. ACK, I will update to pmic names > >> + }, { >> + .compatible = "qcom,bcl-v2", >> + .data = &pm8350_data, >> + }, { >> + .compatible = "qcom,bcl-v3-bmx", >> + .data = &pm8550b_data, >> + }, { >> + .compatible = "qcom,bcl-v3-wb", >> + .data = &pmw5100_data, >> + }, { >> + .compatible = "qcom,bcl-v3-core", >> + .data = &pm8550_data, >> + }, { >> + .compatible = "qcom,bcl-v4-bmx", >> + .data = &pmih010_data, >> + }, { >> + .compatible = "qcom,bcl-v4-wb", >> + .data = &pmw6100_data, >> + }, { >> + .compatible = "qcom,bcl-v4-core", >> + .data = &pmh010_data, >> + }, { >> + .compatible = "qcom,bcl-v4-pmv010", >> + .data = &pmv010_data, >> + }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, bcl_match); >> + >> +static struct platform_driver bcl_driver = { >> + .probe = bcl_probe, >> + .driver = { >> + .name = BCL_DRIVER_NAME, > No, just use name here. ACK > >> + .of_match_table = bcl_match, >> + }, >> +}; >> + >> +MODULE_AUTHOR("Manaf Meethalavalappu Pallikunhi "); >> +MODULE_DESCRIPTION("QCOM BCL HWMON driver"); >> +module_platform_driver(bcl_driver); >> +MODULE_LICENSE("GPL"); > ... > >> + >> +/** >> + * bcl_disable_irq - Generic helper to disable alarm irq >> + * @alarm: BCL level alarm data >> + */ >> +static inline void bcl_disable_irq(struct bcl_alarm_data *alarm) > Why do you write actual functions/code in the headers? > > Please follow standard C rules, which mean that the C unit contains code > intended for execution. Headers are only for declarations. ACK, I will move all codes from header to driver and remove header in next revision based on this and other's comment. Thanks, Manaf > >> +{ >> + if (!alarm->irq_enabled) >> + return; >> + alarm->irq_enabled = false; >> + disable_irq_nosync(alarm->irq); >> + disable_irq_wake(alarm->irq); >> +} >> + >> +#endif /* __QCOM_BCL_HWMON_H__ */ >> >> -- >> 2.43.0 >>