Re: [PATCH v5 5/5] Documentation: laptops: Update documentation for uniwill laptops

[Werner Sembach <wse@tuxedocomputers.com>]

Am 11.03.26 um 20:35 schrieb Armin Wolf:
> Am 11.03.26 um 00:34 schrieb Werner Sembach:
>
>> Adds short description for two new sysfs entries, ctgp_offset and
>> usb_c_power_priority, to the documentation of uniwill laptops.
>>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>>   .../ABI/testing/sysfs-driver-uniwill-laptop   | 25 +++++++++++++++++++
>>   .../admin-guide/laptops/uniwill-laptop.rst    | 12 +++++++++
>>   2 files changed, 37 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-driver-uniwill-laptop 
>> b/Documentation/ABI/testing/sysfs-driver-uniwill-laptop
>> index 2df70792968f3..cba4138604601 100644
>> --- a/Documentation/ABI/testing/sysfs-driver-uniwill-laptop
>> +++ b/Documentation/ABI/testing/sysfs-driver-uniwill-laptop
>> @@ -51,3 +51,28 @@ Description:
>>             Reading this file returns the current status of the breathing 
>> animation
>>           functionality.
>> +
>> +What:        /sys/bus/platform/devices/INOU0000:XX/ctgp_offset
>> +Date:        January 2026
>> +KernelVersion:    7.0
>> +Contact:    Werner Sembach <wse@tuxedocomputers.com>
>> +Description:
>> +        Allows userspace applications to set the configurable TGP offset on 
>> top of the base
>> +        TGP. Base TGP and max TGP and therefore the max cTGP offset are 
>> device specific.
>> +        Note that setting the maximal cTGP leaves no window open for Dynamic 
>> Boost,
>> +        effectively disabling that feature for the GPU to always be 
>> prioritized.
>> +
>> +        Reading this file returns the current configurable TGP offset.
>> +
>> +What: /sys/bus/platform/devices/INOU0000:XX/usb_c_power_priority
>> +Date:        February 2026
>> +KernelVersion:    7.1
>> +Contact:    Werner Sembach <wse@tuxedocomputers.com>
>> +Description:
>> +        Allows userspace applications to choose the USB-C power distribution 
>> profile between
>> +        one that offers a bigger share of the power to the battery and one 
>> that offers more
>> +        of it to the CPU. Writing "charging"/"performance" into this file 
>> selects the
>> +        respective profile.
>> +
>> +        Reading this file returns the profile names with the currently 
>> active one in
>> +        brackets.
>> diff --git a/Documentation/admin-guide/laptops/uniwill-laptop.rst 
>> b/Documentation/admin-guide/laptops/uniwill-laptop.rst
>> index aff5f57a6bd47..be4aeb9c023dd 100644
>> --- a/Documentation/admin-guide/laptops/uniwill-laptop.rst
>> +++ b/Documentation/admin-guide/laptops/uniwill-laptop.rst
>> @@ -50,6 +50,10 @@ between 1 and 100 percent are supported.
>>   Additionally the driver signals the presence of battery charging issues 
>> through the standard
>>   ``health`` power supply sysfs attribute.
>>   +It also lets you set whether a USB-C power source should prioritise 
>> charging the battery or
>> +delivering immediate power to the cpu. See 
>> Documentation/ABI/testing/sysfs-driver-uniwill-laptop for
>> +details.
>> +
>>   Lightbar
>>   --------
>>   @@ -58,3 +62,11 @@ LED class device. The default name of this LED class 
>> device is ``uniwill:multico
>>     See Documentation/ABI/testing/sysfs-driver-uniwill-laptop for details on 
>> how to control the various
>>   animation modes of the lightbar.
>> +
>> +Configurable TGP
>> +--------
>> +
>
> Hi,
>
> i think you forgot to extend the underline a bit. Please do so for the next 
> revision.
ack
>
> Thanks,
> Armin Wolf
>
>> +The ``uniwill-laptop`` driver allows to set the configurable TGP for devices 
>> with NVIDIA GPUs that
>> +allow it.
>> +
>> +See Documentation/ABI/testing/sysfs-driver-uniwill-laptop for details.