From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B315C3998AF for ; Mon, 8 Jun 2026 20:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780949945; cv=none; b=lHbkxzaecCLnByLYQn3JV1lTos/s1+U1r+4G9XlceFoa/9yK/ZxGOz4vmEN7564BN5ohJCVtdEiIGXVkd1/JfgiiqBIow6IIbIc0JYeNtCXogUYbHwuObjhCB0avIkIv+b9Lp2KDolOI7ZHk0BccW0/mGsffRp+2K4+Qk/DXLoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780949945; c=relaxed/simple; bh=c6LhB50xzTUNM67LpJOLAQIsNPeE/Mn8reenaq+1+g4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=pEa1of4+06TH3El/+jxP5HKJ2NFc0yfCno7usQrWePLq41s1zfeLj+TyQ4G2u+yuY/Kxm0QnZRWEB9Wbay9LPbRJRbl+JqUJ1O7lowNIUt4np/ih6stUfw6xotp06Bnwp5pY7EOfX0++0IQsH+LUadxl3t/WkrpKZtTerKQMuVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O3O6MtKe; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O3O6MtKe" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-490b613a17bso46882075e9.3 for ; Mon, 08 Jun 2026 13:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780949943; x=1781554743; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=eKc1RLhWdFzWQ4b3KniR44zhLEyDJi6XrNMBugE7zEg=; b=O3O6MtKeLHexvHm3F2c9fDIXf04fOxLh8rM+xeOieMjRFlALWx89AL79IGb186MSFp odLbmrfV9bDrRRn1WnChnV+rjAnZN7GU6GvFwtxx6RTznEoaKppI6sHQJJoInssqEI5t ERUPIRIWw2zm7ftgu+Od4OxUU/qQE0nfSAIXgIlXfIA/xY/W2xgX8pQdrDarDVUP68Q0 y6X/5dyy+xoxm6eAuuyTtvDCy1ePWylaKR+72/fU+KG7bfEH/ZwbQSbfj1+kVLBeM3o7 yS+K5zcpEgU2bCVqVVplDDNGuHYZuWX9+fxfaTaLgc6WahIDL00qxBk8Zi78mK3c1gQn x46w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780949943; x=1781554743; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eKc1RLhWdFzWQ4b3KniR44zhLEyDJi6XrNMBugE7zEg=; b=FOVBRSg0OD8+9UkLpsoHiYIYFNNdlcB4krQ4sKpYbvfAlPD5VjomK/hQun7iGZ0soL /WuMNLTLcfHoJd/cr3YxpJkPKcd8ZxNEi+PoepNITAHfcg2oQ9Ro0Wffct6vofmVHIOK q3dEFomwNCUUIfGoiUaIxAtKW1q5VDSeg+ujZ7HQ3/tpfkIsYx/jvfIa6WMq0WWzmM+t xm0/cYf3pwuRI744JRHOxHQfe2zrTSptZQYRaBRkBi3v+8sZJW/cpyhXCipv/yhLeGfg Eml6jeZMTOzLihwZEZr5apqezd5PxxopVCfVfmFwq7qOu67NCN/WAOn2I/sWvo8gN09H vz+A== X-Forwarded-Encrypted: i=1; AFNElJ+THSnv8RlnpmqZs193bSRDhPUIww03QCzEN9lsbd5wBKWMOQoFbaMQRPArGegKEY7ty1VopTVf2wdcAGI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg5Nk59pm92AZ8ZgpkdxelE35RKNeDhjgW2xhN2BwXfdGBusr3 mn1YXyddGJdxUOiiFb+7z614HwynCg4qUSGEVQSz7UUKiTlEU9idfl2Q X-Gm-Gg: Acq92OE1+jj/INtIpcK1/7p4mK3hrniBJtHPI624EBIV2AjOkVPrYaBDTU6l/q+uvSn EgXc9AhvRqvFe28dV/RxSY92r9sJsURO9mL/di27LuML99Q+hHoicZKmTAimFvkRG9LwPDsIsv/ 4y/s5BqVls+oLOFYIjNX/WtdFjqxUTaDA/E9N3wchEU6S56uDvGU5O2n5ApE2qXTcjawsE8T5vW Ji66VeRSLWscg+GUl96hG0OcHXUiDiUbcPrkC18Rw321KrBcm2oi+jEwkYQBJi86W6nDc3+wKuP NkgyNx6jZvoN/wAj9vcEJkY/nh/39C+R33uK8v4evglvdlp2Lm6B3WOkH5xhcXB8yfSNBleS3up PnldEL5PIyAAp1wZLtKFF8A2qo4s/uOHQyvcASzY57SRX97/QbTw9b2hMKY8zBy4k4oVUyq0Ta3 O6nZrcZ1YNPT+y6XLZOTGN3XHadb7dF5fS3pQtqDU5ifISHkli+Jb4Gl7qn+uMdUQLbyxf08Osl u2JUm0hZLJAadV4QUcsUnk= X-Received: by 2002:a05:600c:5246:b0:490:b55c:cec3 with SMTP id 5b1f17b1804b1-490c25d4c13mr281403645e9.12.1780949942907; Mon, 08 Jun 2026 13:19:02 -0700 (PDT) Received: from ?IPv6:2001:818:ea56:d000:56e0:ceba:7da4:6673? ([2001:818:ea56:d000:56e0:ceba:7da4:6673]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc413541sm452015575e9.14.2026.06.08.13.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 13:19:02 -0700 (PDT) Message-ID: <645b6be8c47fe772902aa7b004701f977a0b6aa6.camel@gmail.com> Subject: Re: [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit From: Nuno =?ISO-8859-1?Q?S=E1?= To: Hungyu Lin , jagathjog1996@gmail.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 08 Jun 2026 21:20:09 +0100 In-Reply-To: <20260608121558.85429-1-dennylin0707@gmail.com> References: <20260608121558.85429-1-dennylin0707@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-08 at 12:15 +0000, Hungyu Lin wrote: > Remove the explicit u32 cast in the watermark limit calculation. >=20 > The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with > min() without triggering type issues. >=20 > Signed-off-by: Hungyu Lin > --- Reviewed-by: Nuno S=C3=A1 > Changes in v2: > - Drop the unnecessary cast instead of using min_t(). > - Follow reviewer feedback from David Laight and Andy Shevchenko. >=20 > =C2=A0drivers/iio/imu/bmi323/bmi323_core.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/imu/bmi323/bmi323_core.c > b/drivers/iio/imu/bmi323/bmi323_core.c > index f3d499423399..72955a697a93 100644 > --- a/drivers/iio/imu/bmi323/bmi323_core.c > +++ b/drivers/iio/imu/bmi323/bmi323_core.c > @@ -1128,7 +1128,7 @@ static int bmi323_set_watermark(struct iio_dev *ind= io_dev, > unsigned int val) > =C2=A0{ > =C2=A0 struct bmi323_data *data =3D iio_priv(indio_dev); > =C2=A0 > - val =3D min(val, (u32)BMI323_FIFO_FULL_IN_FRAMES); > + val =3D min(val, BMI323_FIFO_FULL_IN_FRAMES); > =C2=A0 > =C2=A0 guard(mutex)(&data->mutex); > =C2=A0 data->watermark =3D val;