From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbcGAPeq (ORCPT ); Fri, 1 Jul 2016 11:34:46 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:51152 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcGAPep (ORCPT ); Fri, 1 Jul 2016 11:34:45 -0400 From: Arnd Bergmann To: Hans Verkuil Cc: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [media] cec: add missing inline stubs Date: Fri, 01 Jul 2016 17:37:17 +0200 Message-ID: <6460555.uRUCQj0uFx@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <975908ec-c95c-170d-e7b7-31a810ad82ba@xs4all.nl> References: <20160701112027.102024-1-arnd@arndb.de> <6419506.V8JtZUoqT3@wuerfel> <975908ec-c95c-170d-e7b7-31a810ad82ba@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:cI1lV+VWDkIb9hTMdCXfET7DqWFhAAtcZ+Z35VnlbmdcuK7yMUn sG4bm2hPIijCtfVuFKGWIpUvcYekcy9W4bh1/WtI6o4spB5MdKl/A2+Dsm1uqv31cNyfEFv yWNfdylEGS/1B97KgSnBvBC/BiIy4wkTqfguhqQE06xrAsEmvAS7Yy24pblamo6k1FZ2MWY wHkFwui+KhYAiFjTzqrpQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6FEmJ1iWuxg=:Mn+403MEjbo5BIugBHMetN GB21kGrD5C+IboBIkBJq+51hV1hML6MPquxw1wKv8SSdNc15/7XuJ6ZMa4QJDjQEHKBttOJSq 7UOTUEDnZiqNlnM78U11TBCRHP5BvMCRf3Me0okKqTmVIWtN403kWAbfz5AuQmqXGvZNK5DPD /NzXaSHfKLhQo8TZlPpwTjEyc6r7NEWWbxc6h/DfAE9evy6WEJlQoDnWAbhzSzvQ/YOMcAq2W NtEQxPZ8aKQbHvpsGo3RYaKgKtrMtvbZ468XPTnFLolbS4rflLET/tjzDGQ1MAbdx1Hi7Ztzq SLL6kZfaT7pXDre5AMfTNsbEXg9TQfMiaK0keh8UaK/wQSJH+AtvxYpMOXd6Ibb88r8XnfuFI debdwPMYTF87ziYz9If9oU680hU8zFPqrAFf3LIyn5y4vlJ6sXd0+3vp7Do7GbyulVsCZasMh vbfJJJrOElZJiQWYxKeFmYNck3q9cpRR7Dvcar1mEKHr6qLVxq9aEiy1oALHkCyNOcZeFZiav jJVkKvBLGfziHtV8c0I1B9qN7MTsVUGpyVHEJZ+P25tdwbzeZABXRfgkpdLEuDgP5/GGR72wm xQYY5hHmrALtPcEH92NaiHek/9p21RVO5NTloPKt35cbVlA9tsWA9pz4uhd5moMkNkU0FSBNO CfIFbWS4qjwBbfjhFdxkf0pPXazV/LdLPR1yi3//elKzzVLch+FGJM4XduyQVjdik6k3uRSUz QpWvji7QfTVG/TFJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 1, 2016 5:22:32 PM CEST Hans Verkuil wrote: > > diff --git a/drivers/media/platform/vivid/Kconfig b/drivers/media/platform/vivid/Kconfig > > index 8e6918c5c87c..8e31146d079a 100644 > > --- a/drivers/media/platform/vivid/Kconfig > > +++ b/drivers/media/platform/vivid/Kconfig > > @@ -26,6 +26,7 @@ config VIDEO_VIVID > > config VIDEO_VIVID_CEC > > bool "Enable CEC emulation support" > > depends on VIDEO_VIVID && MEDIA_CEC > > + depends on VIDEO_VIVID=m || MEDIA_CEC=y > > ---help--- > > When selected the vivid module will emulate the optional > > HDMI CEC feature. > > > > which is still not overly nice, but it manages to avoid the > > IS_REACHABLE() check and it lets MEDIA_CEC be a module. > > The only IS_REACHABLE is for the RC_CORE check, and that should remain. I believe that is already taken care of by my earlier "[media] cec: add RC_CORE dependency" patch, https://patchwork.linuxtv.org/patch/34892/ which seems to handle the dependency more gracefully (preventing nonsense configurations rather than just not using RC_CORE). > With my patch MEDIA_CEC can remain a module provided MEDIA_SUPPORT is also > a module. All drivers depending on MEDIA_CEC also depend on MEDIA_SUPPORT, > so that works. To clarify, the problem with the option above is that VIDEO_VIVID_CEC is a 'bool' option, and Kconfig lets that be turned on if both VIDEO_VIVID and MEDIA_CEC are enabled, including the case where MEDIA_CEC is a module and VIDEO_VIVID is not. Your patch avoids that problem by making MEDIA_CEC a 'bool', my patch above is an alternative by ensuring that VIDEO_VIVID_CEC cannot be enabled if MEDIA_CEC is a module and VIDEO_VIVID is not. Arnd